[iOS] Phone Number flags. [chromium/src : main]

Elmehdi Rahmaoui (Gerrit)

unread,

Nov 23, 2022, 12:32:03 PM11/23/22

to ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, David Jean, chromium...@chromium.org

Attention is currently required from: David Jean.

View Change

To view, visit change 4051161. To unsubscribe, or for help writing mail filters, visit settings.

David Jean (Gerrit)

unread,

Nov 24, 2022, 3:38:50 AM11/24/22

to Elmehdi Rahmaoui, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, chromium...@chromium.org

Attention is currently required from: Elmehdi Rahmaoui.

View Change

3 comments:

File ios/chrome/browser/flags/about_flags.mm:
- Patch Set #2, Line 1046: phone-number
  Bit dried for a flag name. Maybe intents-on-phone-number?
File ios/chrome/browser/flags/ios_chrome_flag_descriptions.h:
- Patch Set #2, Line 126: const
  Comment above
File ios/chrome/browser/flags/ios_chrome_flag_descriptions.cc:
- Patch Set #2, Line 149: dummy
  Description a bit unclear 😊

To view, visit change 4051161. To unsubscribe, or for help writing mail filters, visit settings.

Elmehdi Rahmaoui (Gerrit)

unread,

Nov 25, 2022, 6:55:06 AM11/25/22

to ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, David Jean, chromium...@chromium.org

Attention is currently required from: David Jean.

View Change

2 comments:

File ios/chrome/browser/flags/about_flags.mm:

- Patch Set #2, Line 1046: phone-number

- Bit dried for a flag name. […]
  Done
File ios/chrome/browser/flags/ios_chrome_flag_descriptions.cc:

- Patch Set #2, Line 149: dummy
  Description a bit unclear 😊

- Done

To view, visit change 4051161. To unsubscribe, or for help writing mail filters, visit settings.

Elmehdi Rahmaoui (Gerrit)

unread,

Nov 25, 2022, 6:58:29 AM11/25/22

to ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, David Jean, chromium...@chromium.org

Attention is currently required from: David Jean.

View Change

1 comment:

File ios/chrome/browser/flags/ios_chrome_flag_descriptions.h:

- Patch Set #2, Line 126: const
  Comment above

- Done

To view, visit change 4051161. To unsubscribe, or for help writing mail filters, visit settings.

David Jean (Gerrit)

unread,

Nov 26, 2022, 7:04:54 AM11/26/22

to Elmehdi Rahmaoui, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Elmehdi Rahmaoui.

Patch set 4:Code-Review +1

View Change

To view, visit change 4051161. To unsubscribe, or for help writing mail filters, visit settings.

Elmehdi Rahmaoui (Gerrit)

unread,

Nov 28, 2022, 11:14:38 AM11/28/22

to ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, David Jean, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Elmehdi Rahmaoui.

Patch set 5:Commit-Queue +2

View Change

To view, visit change 4051161. To unsubscribe, or for help writing mail filters, visit settings.

Chromium LUCI CQ (Gerrit)

unread,

Nov 28, 2022, 11:19:57 AM11/28/22

to Elmehdi Rahmaoui, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, David Jean, chromium...@chromium.org

Chromium LUCI CQ submitted this change.

View Change



4 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: chrome/browser/flag-metadata.json
Insertions: 5, Deletions: 5.

@@ -3497,11 +3497,6 @@
     "expiry_milestone": 111
   },
   {
-    "name": "intents-on-phone-number",
-    "owners": [ "dj...@google.com", "erah...@google.com", "bling...@google.com" ],
-    "expiry_milestone": 112
-  },
-  {
     "name": "explore-sites",
     "owners": [ "chili", "dewittj" ],
     "expiry_milestone": 102
@@ -4177,6 +4172,11 @@
     "expiry_milestone": 112
   },
   {
+    "name": "intents-on-phone-number",
+    "owners": [ "dj...@google.com", "erah...@google.com", "bling...@google.com" ],
+    "expiry_milestone": 112
+  },
+  {
     "name": "interest-feed-notice-card-auto-dismiss",
     "owners": [ "//chrome/android/feed/OWNERS", "fe...@chromium.org", "edc...@chromium.org" ],
     "expiry_milestone": 95
```

Approvals:
  Elmehdi Rahmaoui: Commit
  David Jean: Looks good to me

[iOS] Phone Number flags.

Enable phone number flags.

Bug: 1348196
Change-Id: Ieff4f9291eb3f3a9ea40482fed153ff7b715f407
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4051161
Commit-Queue: Elmehdi Rahmaoui <erah...@google.com>
Reviewed-by: David Jean <dj...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1076233}
---
M chrome/browser/flag-metadata.json
M ios/chrome/browser/flags/about_flags.mm
M ios/chrome/browser/flags/ios_chrome_flag_descriptions.cc
M ios/chrome/browser/flags/ios_chrome_flag_descriptions.h
4 files changed, 34 insertions(+), 0 deletions(-)

To view, visit change 4051161. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward