Move more files to build on Android [chromium/src : main]

0 views
Skip to first unread message

Min Qin (Gerrit)

unread,
2:40 PM (9 hours ago) 2:40 PM
to Siddhartha S, David Bokan, chromium...@chromium.org, dewitt...@chromium.org, mfoltz+wa...@chromium.org
Attention needed from Siddhartha S

Min Qin voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Siddhartha S
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I1302d04f09bfbc1507713b9f1616f472b691b7ce
Gerrit-Change-Number: 7298485
Gerrit-PatchSet: 3
Gerrit-Owner: Siddhartha S <ss...@chromium.org>
Gerrit-Reviewer: David Bokan <bo...@chromium.org>
Gerrit-Reviewer: Min Qin <qin...@chromium.org>
Gerrit-Attention: Siddhartha S <ss...@chromium.org>
Gerrit-Comment-Date: Fri, 26 Dec 2025 19:39:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Siddhartha S (Gerrit)

unread,
6:53 PM (4 hours ago) 6:53 PM
to Siddhartha S, Chromium LUCI CQ, Min Qin, David Bokan, chromium...@chromium.org, dewitt...@chromium.org, mfoltz+wa...@chromium.org

Siddhartha S voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I1302d04f09bfbc1507713b9f1616f472b691b7ce
Gerrit-Change-Number: 7298485
Gerrit-PatchSet: 3
Gerrit-Owner: Siddhartha S <ss...@chromium.org>
Gerrit-Reviewer: David Bokan <bo...@chromium.org>
Gerrit-Reviewer: Min Qin <qin...@chromium.org>
Gerrit-Reviewer: Siddhartha S <ss...@chromium.org>
Gerrit-Comment-Date: Fri, 26 Dec 2025 23:53:10 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Siddhartha S (Gerrit)

unread,
6:54 PM (4 hours ago) 6:54 PM
to Siddhartha S, Chromium LUCI CQ, Min Qin, David Bokan, chromium...@chromium.org, dewitt...@chromium.org, mfoltz+wa...@chromium.org

Siddhartha S voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I1302d04f09bfbc1507713b9f1616f472b691b7ce
    Gerrit-Change-Number: 7298485
    Gerrit-PatchSet: 4
    Gerrit-Owner: Siddhartha S <ss...@chromium.org>
    Gerrit-Reviewer: David Bokan <bo...@chromium.org>
    Gerrit-Reviewer: Min Qin <qin...@chromium.org>
    Gerrit-Reviewer: Siddhartha S <ss...@chromium.org>
    Gerrit-Comment-Date: Fri, 26 Dec 2025 23:54:20 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Siddhartha S (Gerrit)

    unread,
    6:55 PM (4 hours ago) 6:55 PM
    to Siddhartha S, Chromium LUCI CQ, Min Qin, David Bokan, chromium...@chromium.org, dewitt...@chromium.org, mfoltz+wa...@chromium.org

    Siddhartha S voted

    Commit-Queue+2
    Owners-Override+1
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I1302d04f09bfbc1507713b9f1616f472b691b7ce
    Gerrit-Change-Number: 7298485
    Gerrit-PatchSet: 4
    Gerrit-Owner: Siddhartha S <ss...@chromium.org>
    Gerrit-Reviewer: David Bokan <bo...@chromium.org>
    Gerrit-Reviewer: Min Qin <qin...@chromium.org>
    Gerrit-Reviewer: Siddhartha S <ss...@chromium.org>
    Gerrit-Comment-Date: Fri, 26 Dec 2025 23:55:11 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Siddhartha S (Gerrit)

    unread,
    7:00 PM (4 hours ago) 7:00 PM
    to Siddhartha S, Chromium LUCI CQ, Min Qin, David Bokan, chromium...@chromium.org, dewitt...@chromium.org, mfoltz+wa...@chromium.org

    Siddhartha S voted

    Commit-Queue+2
    Owners-Override+1
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I1302d04f09bfbc1507713b9f1616f472b691b7ce
      Gerrit-Change-Number: 7298485
      Gerrit-PatchSet: 5
      Gerrit-Owner: Siddhartha S <ss...@chromium.org>
      Gerrit-Reviewer: David Bokan <bo...@chromium.org>
      Gerrit-Reviewer: Min Qin <qin...@chromium.org>
      Gerrit-Reviewer: Siddhartha S <ss...@chromium.org>
      Gerrit-Comment-Date: Sat, 27 Dec 2025 00:00:33 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Chromium LUCI CQ (Gerrit)

      unread,
      7:39 PM (4 hours ago) 7:39 PM
      to Siddhartha S, Min Qin, David Bokan, chromium...@chromium.org, dewitt...@chromium.org, mfoltz+wa...@chromium.org

      Chromium LUCI CQ submitted the change

      Unreviewed changes

      3 is the latest approved patch-set.
      No files were changed between the latest approved patch-set and the submitted one.

      Change information

      Commit message:
      Move more files to build on Android
      Binary-Size: Size increase is necessary
      Bug: 470475787, 465208148
      Change-Id: I1302d04f09bfbc1507713b9f1616f472b691b7ce
      Commit-Queue: Siddhartha S <ss...@chromium.org>
      Owners-Override: Siddhartha S <ss...@chromium.org>
      Reviewed-by: Min Qin <qin...@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#1562812}
      Files:
      • M chrome/browser/actor/BUILD.gn
      • M chrome/browser/glic/actor/BUILD.gn
      Change size: M
      Delta: 2 files changed, 42 insertions(+), 44 deletions(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by Min Qin
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I1302d04f09bfbc1507713b9f1616f472b691b7ce
      Gerrit-Change-Number: 7298485
      Gerrit-PatchSet: 6
      Gerrit-Owner: Siddhartha S <ss...@chromium.org>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: David Bokan <bo...@chromium.org>
      Gerrit-Reviewer: Min Qin <qin...@chromium.org>
      Gerrit-Reviewer: Siddhartha S <ss...@chromium.org>
      open
      diffy
      satisfied_requirement
      Reply all
      Reply to author
      Forward
      0 new messages