[WebView] Add MessagePort(postMessage) support to JavaScript Sandbox. [chromium/src : main]
0 views
Skip to first unread message
Alex Mîrzea (Gerrit)
Sep 9, 2025, 11:00:41 AMSep 9
to Richard (Torne) Coles, Ashley Newson, chromium...@chromium.org, android-web...@chromium.org
Attention needed from Ashley Newson and Richard (Torne) Coles
Alex Mîrzea added 4 comments![]( "Open in Gerrit")
File android_webview/js_sandbox/java/src/org/chromium/android_webview/js_sandbox/service/JsSandboxMessagePort.java
Line 36, Patchset 14:
Executor executor = Runnable::run;Richard (Torne) Coles . resolved
Alex Mîrzeanit: i'd just remove this so it's clearer in the code that it's currently running synchronously.
Done
File android_webview/js_sandbox/service/js_sandbox_isolate.cc
Line 934, Patchset 14:
args->ThrowTypeError("getNamePort requires exactly one argument.");Richard (Torne) Coles . resolved
Alex Mîrzeanit: spelling
Done
File android_webview/js_sandbox/service/js_sandbox_message_port.cc
Line 72, Patchset 14:
JsSandboxMessagePort::~JsSandboxMessagePort() {Richard (Torne) Coles . resolved
Alex Mîrzeanit: blank line between things
Done
Line 195, Patchset 14:
std::ranges::copy(Richard (Torne) Coles . resolved
Alex MîrzeaThis is also copying the data twice like the code you already fixed for the other direction, and can be fixed similarly.
Done
Related details
Attention is currently required from:
- Ashley Newson
- Richard (Torne) Coles
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Richard (Torne) Coles (Gerrit)
Sep 23, 2025, 1:17:58 PM (3 days ago) Sep 23
to Alex Mîrzea, Richard (Torne) Coles, Code Review Nudger, Ashley Newson, chromium...@chromium.org, android-web...@chromium.org
Attention needed from Alex Mîrzea and Ashley Newson
Richard (Torne) Coles voted and added 1 comment![]( "Open in Gerrit")
Votes added by Richard (Torne) Coles
| Code-Review | +1 |
1 comment
File android_webview/js_sandbox/service/js_sandbox_message_port.cc
Line 89, Patchset 23 (Latest):
jsize length = env->GetArrayLength(j_array_buffer.obj());Richard (Torne) Coles . unresolved
why not just get the length in the function that actually uses the data?
Related details
Attention is currently required from:
- Alex Mîrzea
- Ashley Newson
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Mîrzea (Gerrit)
Sep 23, 2025, 6:28:49 PM (3 days ago) Sep 23
to Richard (Torne) Coles, Code Review Nudger, Ashley Newson, chromium...@chromium.org, android-web...@chromium.org
Attention needed from Ashley Newson and Richard (Torne) Coles
Alex Mîrzea added 1 comment![]( "Open in Gerrit")
File android_webview/js_sandbox/service/js_sandbox_message_port.cc
Line 89, Patchset 23:
jsize length = env->GetArrayLength(j_array_buffer.obj());Richard (Torne) Coles . resolved
why not just get the length in the function that actually uses the data?
Attention is currently required from:
- Ashley Newson
- Richard (Torne) Coles
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Mîrzea (Gerrit)
Sep 25, 2025, 12:01:35 PM (yesterday) Sep 25
to Richard (Torne) Coles, Code Review Nudger, Ashley Newson, chromium...@chromium.org, android-web...@chromium.org
Attention needed from Ashley Newson and Richard (Torne) Coles
Alex Mîrzea added 1 comment![]( "Open in Gerrit")
File android_webview/js_sandbox/java/src/org/chromium/android_webview/js_sandbox/service/JsSandboxMessagePort.java
Line 14, Patchset 9:
public class JsSandboxMessagePort {Ashley Newson . resolved
Alex MîrzeaA TODO, which I'd be happy to postpone to a follow-up CL:
We will need to account for the memory of messages that haven't yet reached the isolate thread. This would probably be done by lifting some of the existing accounting logic out of our arraybuffer allocator class for more general (and thread safe!) usage.
CL is uploaded.
Related details
Attention is currently required from:
- Ashley Newson
- Richard (Torne) Coles
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Richard (Torne) Coles (Gerrit)
3:34 PM (7 hours ago) 3:34 PM
to Alex Mîrzea, Richard (Torne) Coles, Code Review Nudger, Ashley Newson, chromium...@chromium.org, android-web...@chromium.org
Attention needed from Alex Mîrzea and Ashley Newson
Richard (Torne) Coles voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Alex Mîrzea
- Ashley Newson
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages