Viktoriya Bryhider (Gerrit)

unread,

Jun 5, 2026, 5:06:26 PMJun 5

to Chromium LUCI CQ, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, chromium-a...@chromium.org, creis...@chromium.org, navigation...@chromium.org, extension...@chromium.org, alexmo...@chromium.org

Attention needed from Viktoriya Bryhider

Message from Viktoriya Bryhider

Set Ready For Review

Open in Gerrit

Related details

Attention is currently required from:

Viktoriya Bryhider

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Viktoriya Bryhider (Gerrit)

unread,

Jun 5, 2026, 5:08:35 PMJun 5

to Alex Moshchuk, Chromium LUCI CQ, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, chromium-a...@chromium.org, creis...@chromium.org, navigation...@chromium.org, extension...@chromium.org, alexmo...@chromium.org

Attention needed from Alex Moshchuk

Viktoriya Bryhider added 1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Viktoriya Bryhider . resolved

Hi - this is another follow-up to previous discussion - crrev.com/c/7794385/10/content/public/browser/security_principal.h#76 Could you please take a look at is when there is time. Thanks.

Open in Gerrit

Related details

Attention is currently required from:

Alex Moshchuk

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Alex Moshchuk (Gerrit)

unread,

Jun 10, 2026, 5:47:17 PMJun 10

to Viktoriya Bryhider, Chromium LUCI CQ, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, chromium-a...@chromium.org, creis...@chromium.org, navigation...@chromium.org, extension...@chromium.org, alexmo...@chromium.org

Attention needed from Viktoriya Bryhider

Alex Moshchuk voted and added 1 comment

Votes added by Alex Moshchuk

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Alex Moshchuk . resolved

Thanks, LGTM

Open in Gerrit

Related details

Attention is currently required from:

Viktoriya Bryhider

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Viktoriya Bryhider (Gerrit)

unread,

Jun 15, 2026, 7:36:22 PMJun 15

to Chromium IPC Reviews, Reilly Grant, Alex Moshchuk, Chromium LUCI CQ, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, chromium-a...@chromium.org, creis...@chromium.org, navigation...@chromium.org, extension...@chromium.org, alexmo...@chromium.org

Attention needed from Chromium IPC Reviews and Reilly Grant

Viktoriya Bryhider added 1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Viktoriya Bryhider . resolved

Decreasing number of string creations, could you please review when you have a chance. Thank you!

Open in Gerrit

Related details

Attention is currently required from:

Chromium IPC Reviews
Reilly Grant

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

gwsq (Gerrit)

unread,

Jun 15, 2026, 7:40:42 PMJun 15

to Viktoriya Bryhider, Chromium IPC Reviews, Kinuko Yasuda, Reilly Grant, Alex Moshchuk, Chromium LUCI CQ, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, chromium-a...@chromium.org, creis...@chromium.org, navigation...@chromium.org, extension...@chromium.org, alexmo...@chromium.org

Attention needed from Kinuko Yasuda and Reilly Grant

Message from gwsq

From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
IPC: kin...@chromium.org

📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).

IPC reviewer(s): kin...@chromium.org

Reviewer source(s):
kin...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)

Open in Gerrit

Related details

Attention is currently required from:

Kinuko Yasuda
Reilly Grant

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reilly Grant (Gerrit)

unread,

Jun 15, 2026, 8:04:46 PMJun 15

to Viktoriya Bryhider, Reilly Grant, Chromium IPC Reviews, Kinuko Yasuda, Alex Moshchuk, Chromium LUCI CQ, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, chromium-a...@chromium.org, creis...@chromium.org, navigation...@chromium.org, extension...@chromium.org, alexmo...@chromium.org

Attention needed from Kinuko Yasuda and Viktoriya Bryhider

Reilly Grant voted and added 1 comment

Votes added by Reilly Grant

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Reilly Grant . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:

Kinuko Yasuda
Viktoriya Bryhider

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Viktoriya Bryhider (Gerrit)

unread,

Jul 14, 2026, 9:20:36 PM (7 days ago) Jul 14

to Reilly Grant, Chromium IPC Reviews, Kinuko Yasuda, Alex Moshchuk, Chromium LUCI CQ, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, chromium-a...@chromium.org, creis...@chromium.org, navigation...@chromium.org, extension...@chromium.org, alexmo...@chromium.org

Attention needed from Kinuko Yasuda

Viktoriya Bryhider added 1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Viktoriya Bryhider . resolved

@kin...@chromium.org - hi, I still would like to merge this CL - could you please review it or suggest the other owner? It is one line change creating string from string_view. Thank you.

Open in Gerrit

Related details

Attention is currently required from:

Kinuko Yasuda

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

gwsq (Gerrit)

unread,

Jul 15, 2026, 6:43:22 PM (6 days ago) Jul 15

to Viktoriya Bryhider, Chromium IPC Reviews, Giovanni Ortuno Urquidi, Reilly Grant, Alex Moshchuk, Chromium LUCI CQ, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, chromium-a...@chromium.org, creis...@chromium.org, navigation...@chromium.org, extension...@chromium.org, alexmo...@chromium.org

Attention needed from Giovanni Ortuno Urquidi and Viktoriya Bryhider

Message from gwsq

From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
IPC: ort...@chromium.org

📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).

IPC reviewer(s): ort...@chromium.org

Reviewer source(s):
ort...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)

Open in Gerrit

Related details

Attention is currently required from:

Giovanni Ortuno Urquidi
Viktoriya Bryhider

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Giovanni Ortuno Urquidi (Gerrit)

unread,

Jul 17, 2026, 10:21:20 AM (4 days ago) Jul 17

to Viktoriya Bryhider, Giovanni Ortuno Urquidi, Chromium IPC Reviews, Reilly Grant, Alex Moshchuk, Chromium LUCI CQ, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, chromium-a...@chromium.org, creis...@chromium.org, navigation...@chromium.org, extension...@chromium.org, alexmo...@chromium.org

Attention needed from Viktoriya Bryhider

Giovanni Ortuno Urquidi voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Viktoriya Bryhider

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Viktoriya Bryhider (Gerrit)

unread,

Jul 17, 2026, 12:13:18 PM (4 days ago) Jul 17

to Giovanni Ortuno Urquidi, Chromium IPC Reviews, Reilly Grant, Alex Moshchuk, Chromium LUCI CQ, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, chromium-a...@chromium.org, creis...@chromium.org, navigation...@chromium.org, extension...@chromium.org, alexmo...@chromium.org

Viktoriya Bryhider voted and added 1 comment

Votes added by Viktoriya Bryhider

Commit-Queue

+2

1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Viktoriya Bryhider . resolved

Thank you Reilly, thanks all.

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Viktoriya Bryhider (Gerrit)

unread,

Jul 20, 2026, 1:09:40 PM (23 hours ago) Jul 20

to Giovanni Ortuno Urquidi, Chromium IPC Reviews, Reilly Grant, Alex Moshchuk, Chromium LUCI CQ, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, chromium-a...@chromium.org, creis...@chromium.org, navigation...@chromium.org, extension...@chromium.org, alexmo...@chromium.org

Attention needed from Alex Moshchuk, Giovanni Ortuno Urquidi and Reilly Grant

Viktoriya Bryhider added 1 comment

Patchset-level comments

File-level comment, Patchset 5:

Viktoriya Bryhider . resolved

I was needed to fix build breaks because there were new callers which were using API. Review votes got reset as outdated. Could you please check again. Thank you.

Open in Gerrit

Related details

Attention is currently required from:

Alex Moshchuk
Giovanni Ortuno Urquidi
Reilly Grant

Submit Requirements:

Code-Coverage

Code-Owners

Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Giovanni Ortuno Urquidi (Gerrit)

unread,

Jul 20, 2026, 1:20:24 PM (23 hours ago) Jul 20

to Viktoriya Bryhider, Giovanni Ortuno Urquidi, Chromium IPC Reviews, Reilly Grant, Alex Moshchuk, Chromium LUCI CQ, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, chromium-a...@chromium.org, creis...@chromium.org, navigation...@chromium.org, extension...@chromium.org, alexmo...@chromium.org

Attention needed from Alex Moshchuk, Reilly Grant and Viktoriya Bryhider

Giovanni Ortuno Urquidi voted and added 2 comments

Votes added by Giovanni Ortuno Urquidi

Code-Review

+1

2 comments

Patchset-level comments

File-level comment, Patchset 6 (Latest):

Giovanni Ortuno Urquidi . resolved

mojo lgtm

File chrome/browser/chrome_content_browser_client_receiver_bindings.cc

Line 334, Patchset 6 (Latest): .GetByID(std::string(render_frame_host->GetSiteInstance()

Giovanni Ortuno Urquidi . unresolved

Should this be ExtensionId?

Open in Gerrit

Related details

Attention is currently required from:

Alex Moshchuk
Reilly Grant
Viktoriya Bryhider

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Viktoriya Bryhider (Gerrit)

unread,

Jul 20, 2026, 1:25:17 PM (23 hours ago) Jul 20

to Giovanni Ortuno Urquidi, Chromium IPC Reviews, Reilly Grant, Alex Moshchuk, Chromium LUCI CQ, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, chromium-a...@chromium.org, creis...@chromium.org, navigation...@chromium.org, extension...@chromium.org, alexmo...@chromium.org

Attention needed from Alex Moshchuk, Giovanni Ortuno Urquidi and Reilly Grant

Viktoriya Bryhider added 1 comment

File chrome/browser/chrome_content_browser_client_receiver_bindings.cc

Line 334, Patchset 6 (Latest): .GetByID(std::string(render_frame_host->GetSiteInstance()

Giovanni Ortuno Urquidi . unresolved

Should this be ExtensionId?

Viktoriya Bryhider

I intentionally left string for mojo one to be more explicit - will ExtensionId work for you here?

Open in Gerrit

Related details

Attention is currently required from:

Alex Moshchuk

Giovanni Ortuno Urquidi
Reilly Grant

satisfied_requirement

unsatisfied_requirement

open

diffy

Giovanni Ortuno Urquidi (Gerrit)

unread,

Jul 20, 2026, 1:29:43 PM (23 hours ago) Jul 20

to Viktoriya Bryhider, Giovanni Ortuno Urquidi, Chromium IPC Reviews, Reilly Grant, Alex Moshchuk, Chromium LUCI CQ, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, chromium-a...@chromium.org, creis...@chromium.org, navigation...@chromium.org, extension...@chromium.org, alexmo...@chromium.org

Attention needed from Alex Moshchuk, Reilly Grant and Viktoriya Bryhider

Giovanni Ortuno Urquidi added 1 comment

File chrome/browser/chrome_content_browser_client_receiver_bindings.cc

Line 334, Patchset 6 (Latest): .GetByID(std::string(render_frame_host->GetSiteInstance()

Giovanni Ortuno Urquidi . resolved

Should this be ExtensionId?

Viktoriya Bryhider

I intentionally left string for mojo one to be more explicit - will ExtensionId work for you here?

Giovanni Ortuno Urquidi

I think it's fine as is.

Open in Gerrit

Related details

Attention is currently required from:

Alex Moshchuk
Reilly Grant
Viktoriya Bryhider

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Viktoriya Bryhider (Gerrit)

unread,

Jul 20, 2026, 1:37:29 PM (23 hours ago) Jul 20

to Giovanni Ortuno Urquidi, Chromium IPC Reviews, Reilly Grant, Alex Moshchuk, Chromium LUCI CQ, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, chromium-a...@chromium.org, creis...@chromium.org, navigation...@chromium.org, extension...@chromium.org, alexmo...@chromium.org

Attention needed from Alex Moshchuk and Reilly Grant

Viktoriya Bryhider added 1 comment

File chrome/browser/chrome_content_browser_client_receiver_bindings.cc

Line 334, Patchset 6: .GetByID(std::string(render_frame_host->GetSiteInstance()

Giovanni Ortuno Urquidi . resolved

Should this be ExtensionId?

Viktoriya Bryhider

I intentionally left string for mojo one to be more explicit - will ExtensionId work for you here?

Giovanni Ortuno Urquidi

I think it's fine as is.

Viktoriya Bryhider

I did updated it to extensions. thanks

Open in Gerrit

Related details

Attention is currently required from:

Alex Moshchuk
Reilly Grant

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reilly Grant (Gerrit)

unread,

Jul 20, 2026, 2:47:25 PM (21 hours ago) Jul 20

to Viktoriya Bryhider, Reilly Grant, Giovanni Ortuno Urquidi, Chromium IPC Reviews, Alex Moshchuk, Chromium LUCI CQ, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, chromium-a...@chromium.org, creis...@chromium.org, navigation...@chromium.org, extension...@chromium.org, alexmo...@chromium.org

Attention needed from Alex Moshchuk and Viktoriya Bryhider

Reilly Grant voted and added 2 comments

Votes added by Reilly Grant

Code-Review

+1

2 comments

Patchset-level comments

File-level comment, Patchset 8 (Latest):

Reilly Grant . resolved

LGTM

File chrome/browser/chrome_content_browser_client_receiver_bindings.cc

Line 334, Patchset 6: .GetByID(std::string(render_frame_host->GetSiteInstance()

Giovanni Ortuno Urquidi . resolved

Should this be ExtensionId?

Viktoriya Bryhider

I intentionally left string for mojo one to be more explicit - will ExtensionId work for you here?

Giovanni Ortuno Urquidi

I think it's fine as is.

Viktoriya Bryhider

I did updated it to extensions. thanks

Reilly Grant

We should probably update `GetById` to take `std::string_view` eventually, since constructing an `std::string` just to satisfy the typedef isn't great.

Open in Gerrit

Related details

Attention is currently required from:

Alex Moshchuk
Viktoriya Bryhider

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Viktoriya Bryhider (Gerrit)

unread,

Jul 20, 2026, 3:04:30 PM (21 hours ago) Jul 20

to Reilly Grant, Giovanni Ortuno Urquidi, Chromium IPC Reviews, Alex Moshchuk, Chromium LUCI CQ, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, chromium-a...@chromium.org, creis...@chromium.org, navigation...@chromium.org, extension...@chromium.org, alexmo...@chromium.org

Attention needed from Alex Moshchuk

Viktoriya Bryhider added 1 comment

File chrome/browser/chrome_content_browser_client_receiver_bindings.cc

Line 334, Patchset 6: .GetByID(std::string(render_frame_host->GetSiteInstance()

Giovanni Ortuno Urquidi . resolved

Should this be ExtensionId?

Viktoriya Bryhider

I intentionally left string for mojo one to be more explicit - will ExtensionId work for you here?

Giovanni Ortuno Urquidi

I think it's fine as is.

Viktoriya Bryhider

I did updated it to extensions. thanks

Reilly Grant

We should probably update `GetById` to take `std::string_view` eventually, since constructing an `std::string` just to satisfy the typedef isn't great.

Viktoriya Bryhider

I had it initially, but reverted, because ExtensionId looked more explicit - this is reverted diff: crrev.com/c/7857269/1..2

Open in Gerrit

Related details

Attention is currently required from:

Alex Moshchuk

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Viktoriya Bryhider (Gerrit)

unread,

Jul 20, 2026, 7:02:32 PM (17 hours ago) Jul 20

to Reilly Grant, Giovanni Ortuno Urquidi, Chromium IPC Reviews, Alex Moshchuk, Chromium LUCI CQ, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, chromium-a...@chromium.org, creis...@chromium.org, navigation...@chromium.org, extension...@chromium.org, alexmo...@chromium.org

Attention needed from Alex Moshchuk

Viktoriya Bryhider voted Commit-Queue+2

Commit-Queue

+2

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Jul 20, 2026, 7:27:05 PM (17 hours ago) Jul 20

to Viktoriya Bryhider, Reilly Grant, Giovanni Ortuno Urquidi, Chromium IPC Reviews, Alex Moshchuk, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, chromium-a...@chromium.org, creis...@chromium.org, navigation...@chromium.org, extension...@chromium.org, alexmo...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

Return string_view from SecurityPrincipal::GetHost

Change SecurityPrincipal::GetHost() to return std::string_view instead
of std::string. It eliminates a heap allocation at callers that only
need the host for lookups or comparisons, while callers that need an
owned copy construct one explicitly.

Update SiteInfo::GetHost() to call site_url_.host(), which returns
string_view. Update StoragePartitionConfig::Create and its constructor
to accept std::string_view parameters, since they store the values into
std::string members anyway.

Callers that pass the result to APIs requiring std::string (e.g.,
ExtensionSet::GetByID) now construct std::string from returned view
using the ExtensionId type alias.

Bug: 397481045, 40526490

Change-Id: I969910690cbde9d62e4f139aed0b657db7d8ec17

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7857269

Commit-Queue: Viktoriya Bryhider <vbry...@microsoft.com>

Reviewed-by: Reilly Grant <rei...@chromium.org>

Reviewed-by: Giovanni Ortuno Urquidi <ort...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1665017}

Files:

M chrome/browser/chrome_content_browser_client.cc
M chrome/browser/chrome_content_browser_client_receiver_bindings.cc
M chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc
M content/browser/renderer_host/render_frame_host_manager_browsertest.cc
M content/browser/site_info.cc
M content/browser/site_info.h
M content/public/browser/security_principal.h
M content/public/browser/storage_partition_config.cc
M content/public/browser/storage_partition_config.h
M extensions/browser/extension_navigation_throttle.cc
M extensions/browser/extension_util.cc

Change size: M

Delta: 11 files changed, 39 insertions(+), 34 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Giovanni Ortuno Urquidi, +1 by Reilly Grant

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

Return string_view from SecurityPrincipal::GetHost [chromium/src : main]

Viktoriya Bryhider (Gerrit)

Message from Viktoriya Bryhider

Related details

Viktoriya Bryhider (Gerrit)

Viktoriya Bryhider added 1 comment

Related details

Alex Moshchuk (Gerrit)

Alex Moshchuk voted and added 1 comment

Votes added by Alex Moshchuk

1 comment

Related details

Viktoriya Bryhider (Gerrit)

Viktoriya Bryhider added 1 comment

Related details

gwsq (Gerrit)

Message from gwsq

Related details

Reilly Grant (Gerrit)

Reilly Grant voted and added 1 comment

Votes added by Reilly Grant

1 comment

Related details

Viktoriya Bryhider (Gerrit)

Viktoriya Bryhider added 1 comment

Related details

gwsq (Gerrit)

Message from gwsq

Related details

Giovanni Ortuno Urquidi (Gerrit)

Giovanni Ortuno Urquidi voted Code-Review+1

Related details

Viktoriya Bryhider (Gerrit)

Viktoriya Bryhider voted and added 1 comment

Votes added by Viktoriya Bryhider

1 comment

Related details

Viktoriya Bryhider (Gerrit)

Viktoriya Bryhider added 1 comment

Related details

Giovanni Ortuno Urquidi (Gerrit)

Giovanni Ortuno Urquidi voted and added 2 comments

Votes added by Giovanni Ortuno Urquidi

2 comments

Related details

Viktoriya Bryhider (Gerrit)

Viktoriya Bryhider added 1 comment

Related details

Giovanni Ortuno Urquidi (Gerrit)

Giovanni Ortuno Urquidi added 1 comment

Related details

Viktoriya Bryhider (Gerrit)

Viktoriya Bryhider added 1 comment

Related details

Reilly Grant (Gerrit)

Reilly Grant voted and added 2 comments

Votes added by Reilly Grant

2 comments

Related details

Viktoriya Bryhider (Gerrit)

Viktoriya Bryhider added 1 comment

Related details

Viktoriya Bryhider (Gerrit)

Viktoriya Bryhider voted Commit-Queue+2

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information