[iOS] Add web view resizing type enum [chromium/src : main]
0 views
Skip to first unread message
Gauthier Ambard (Gerrit)
10:57 AM (7 hours ago) 10:57 AM
to Aliona Dangla, Scott Yoder, Chromium LUCI CQ, chromium...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org
Attention needed from Aliona Dangla
Gauthier Ambard voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Aliona Dangla
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Aliona Dangla (Gerrit)
12:05 PM (6 hours ago) 12:05 PM
to Gauthier Ambard, Scott Yoder, Chromium LUCI CQ, chromium...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org
Aliona Dangla voted and added 1 comment![]( "Open in Gerrit")
Votes added by Aliona Dangla
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
12:08 PM (6 hours ago) 12:08 PM
to Aliona Dangla, Gauthier Ambard, Scott Yoder, chromium...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[iOS] Add web view resizing type enum
This change add the `WebViewResizingType` enum to define different
resizing behaviors for the web view. This allows for more precise
control over how the viewport adapts to UI changes, such as the
appearance of toolbars or other elements.
This enum is a necessary component for the "Bling Fullscreen
refactoring" on iOS 26. It provides the infrastructure to handle various
fullscreen scenarios and ensures that content is resized correctly when
parts of the viewport are obscured.
See go/bling-fullscreen-refactoring-part1 for more details
This is part of multiples changes
* https://crrev.com/c/6839620 | [iOS] Implement fullscreen with obscured inset in iOS 26
* ➔ https://crrev.com/c/6853827 | [iOS] Add fullscreen resizing type enum (Current CL)
* https://crrev.com/c/6973698 | [iOS] Add web view resizing enum
* https://crrev.com/c/6827602 | [iOS] Add obscured inset property
Bug: 438144976
Change-Id: I310cc99ec1521bcd8929594a15d1e36187835911
Reviewed-by: Gauthier Ambard <gam...@chromium.org>
Commit-Queue: Aliona Dangla <aliona...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1520655}
Files:
- M ios/web/common/crw_viewport_adjustment.h
- M ios/web/common/crw_web_view_content_view.mm
- M ios/web/content/web_state/crc_web_viewport_container_view.mm
Change size: S
Delta: 3 files changed, 16 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Gauthier Ambard
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mike Dougherty (Gerrit)
12:53 PM (5 hours ago) 12:53 PM
to Chromium LUCI CQ, Aliona Dangla, Gauthier Ambard, Scott Yoder, chromium...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org
Mike Dougherty has created a revert of this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages