Revert "Use non-Signal interfaces to NetworkManager signals" [chromium/src : main]
0 views
Skip to first unread message
Chrome Crash (Prod) (Gerrit)
Nov 5, 2025, 6:03:30 AM (2 days ago) Nov 5
to Danil Chapovalov, Joe Downing, Chromium LUCI CQ, Stefan Zager, Harald Alvestrand, AyeAye, chromotin...@chromium.org, chromium...@chromium.org
Attention needed from Danil Chapovalov, Harald Alvestrand, Joe Downing and Stefan Zager
Chrome Crash (Prod) has uploaded the change for review![]( "Open in Gerrit")
Chrome Crash (Prod) would like Danil Chapovalov, Joe Downing, Chromium LUCI CQ, Stefan Zager and Harald Alvestrand to review this change.
Commit message
Revert "Use non-Signal interfaces to NetworkManager signals"
This reverts commit a9dc308d3c521a37d9f386a33d81d1ce93564988.
Reason for revert:
The Suspect CL https://chromium-review.googlesource.com/q/Ie82f49332a2c8c4238905b711be01f1d58b5c4c0 is highly likely the cause of the crash. Please see the crash report http://crash/5c72c6d8d5490e67.
Rebase the Revert CL on top of main branch with conflicts allowed option to prevent false positive merge conflicts.
If you agree with the revert CL, please approve it and mark as Commit-Queue +2 to submit it.
More details can be found in the go/crash-revert-cls-creation.
Original change's description:
> Use non-Signal interfaces to NetworkManager signals
>
> This aids in the replacement of sigslot in webrtc.
>
> Bug: webrtc:42222066
> Change-Id: Ie82f49332a2c8c4238905b711be01f1d58b5c4c0
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7116598
> Reviewed-by: Stefan Zager <sza...@chromium.org>
> Reviewed-by: Danil Chapovalov <dani...@chromium.org>
> Commit-Queue: Harald Alvestrand <h...@chromium.org>
> Reviewed-by: Joe Downing <joe...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1540281}
>
Bug: webrtc:42222066
Change-Id: I7dfd9461405a1ce00698c9a3064e92c5f66bf3e4
Change diff
Change information
Files:
- M remoting/test/fake_network_manager.cc
- M third_party/blink/renderer/platform/p2p/empty_network_manager.cc
- M third_party/blink/renderer/platform/p2p/filtering_network_manager.cc
- M third_party/blink/renderer/platform/p2p/filtering_network_manager_test.cc
- M third_party/blink/renderer/platform/p2p/ipc_network_manager.cc
Change size: S
Delta: 5 files changed, 13 insertions(+), 11 deletions(-)
Related details
Attention is currently required from:
- Danil Chapovalov
- Harald Alvestrand
- Joe Downing
- Stefan Zager
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chrome Crash (Prod) (Gerrit)
Nov 5, 2025, 6:04:05 AM (2 days ago) Nov 5
to Rubber Stamper, Danil Chapovalov, Joe Downing, Chromium LUCI CQ, Stefan Zager, Harald Alvestrand, AyeAye, chromotin...@chromium.org, chromium...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org
Attention needed from Danil Chapovalov, Harald Alvestrand, Joe Downing and Stefan Zager
Chrome Crash (Prod) voted Commit-Queue+1![]( "Open in Gerrit")
Trigger the CQ Dryrun through the Set Review API to save waiting time.
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Danil Chapovalov
- Harald Alvestrand
- Joe Downing
- Stefan Zager
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rubber Stamper (Gerrit)
Nov 5, 2025, 6:04:23 AM (2 days ago) Nov 5
to Chrome Crash (Prod), Danil Chapovalov, Joe Downing, Chromium LUCI CQ, Stefan Zager, Harald Alvestrand, AyeAye, chromotin...@chromium.org, chromium...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org
Attention needed from Danil Chapovalov, Harald Alvestrand, Joe Downing and Stefan Zager
Rubber Stamper voted Bot-Commit+1![]( "Open in Gerrit")
| Bot-Commit | +1 |
Related details
Attention is currently required from:
- Danil Chapovalov
- Harald Alvestrand
- Joe Downing
- Stefan Zager
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Danil Chapovalov (Gerrit)
Nov 5, 2025, 6:05:10 AM (2 days ago) Nov 5
to Chrome Crash (Prod), Rubber Stamper, Joe Downing, Chromium LUCI CQ, Stefan Zager, Harald Alvestrand, AyeAye, chromotin...@chromium.org, chromium...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org
Attention needed from Harald Alvestrand, Joe Downing and Stefan Zager
Danil Chapovalov voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
Ilya Nikolaevskiy (Gerrit)
Nov 5, 2025, 8:16:33 AM (2 days ago) Nov 5
to Chrome Crash (Prod), Danil Chapovalov, Rubber Stamper, Joe Downing, Chromium LUCI CQ, Stefan Zager, Harald Alvestrand, AyeAye, chromotin...@chromium.org, chromium...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org
Attention needed from Harald Alvestrand, Joe Downing and Stefan Zager
Ilya Nikolaevskiy voted and added 1 comment![]( "Open in Gerrit")
Votes added by Ilya Nikolaevskiy
| Code-Review | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 3 (Latest):
Ilya Nikolaevskiy . resolved
FYI, the original CL triggered ASAN bots on linux: https://issues.webrtc.org/issues/457864117
Related details
Attention is currently required from:
- Harald Alvestrand
- Joe Downing
- Stefan Zager
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tomas Gunnarsson (Gerrit)
Nov 5, 2025, 8:20:36 AM (2 days ago) Nov 5
to Chrome Crash (Prod), Ilya Nikolaevskiy, Danil Chapovalov, Rubber Stamper, Joe Downing, Chromium LUCI CQ, Stefan Zager, Harald Alvestrand, AyeAye, chromotin...@chromium.org, chromium...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org
Attention needed from Harald Alvestrand, Joe Downing and Stefan Zager
Tomas Gunnarsson voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Harald Alvestrand (Gerrit)
Nov 5, 2025, 8:21:21 AM (2 days ago) Nov 5
to Chrome Crash (Prod), Tomas Gunnarsson, Ilya Nikolaevskiy, Danil Chapovalov, Rubber Stamper, Joe Downing, Chromium LUCI CQ, Stefan Zager, AyeAye, chromotin...@chromium.org, chromium...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org
Attention needed from Joe Downing and Stefan Zager
Harald Alvestrand voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Joe Downing
- Stefan Zager
Joe Downing (Gerrit)
Nov 5, 2025, 9:58:55 AM (2 days ago) Nov 5
to Chrome Crash (Prod), Harald Alvestrand, Tomas Gunnarsson, Ilya Nikolaevskiy, Danil Chapovalov, Rubber Stamper, Chromium LUCI CQ, Stefan Zager, AyeAye, chromotin...@chromium.org, chromium...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org
Attention needed from Stefan Zager
Joe Downing voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Stefan Zager
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ilya Nikolaevskiy (Gerrit)
Nov 5, 2025, 10:39:18 AM (2 days ago) Nov 5
to Chrome Crash (Prod), Joe Downing, Harald Alvestrand, Tomas Gunnarsson, Danil Chapovalov, Rubber Stamper, Chromium LUCI CQ, Stefan Zager, AyeAye, chromotin...@chromium.org, chromium...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org
Attention needed from Stefan Zager
Ilya Nikolaevskiy voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Chromium LUCI CQ (Gerrit)
Nov 5, 2025, 10:57:17 AM (2 days ago) Nov 5
to Chrome Crash (Prod), Ilya Nikolaevskiy, Joe Downing, Harald Alvestrand, Tomas Gunnarsson, Danil Chapovalov, Rubber Stamper, Stefan Zager, AyeAye, chromotin...@chromium.org, chromium...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Revert "Use non-Signal interfaces to NetworkManager signals"
This reverts commit a9dc308d3c521a37d9f386a33d81d1ce93564988.
Reason for revert:
The Suspect CL https://chromium-review.googlesource.com/q/Ie82f49332a2c8c4238905b711be01f1d58b5c4c0 is highly likely the cause of the crash. Please see the crash report http://crash/5c72c6d8d5490e67.
Rebase the Revert CL on top of main branch with conflicts allowed option to prevent false positive merge conflicts.
If you agree with the revert CL, please approve it and mark as Commit-Queue +2 to submit it.
More details can be found in the go/crash-revert-cls-creation.
Original change's description:
> Use non-Signal interfaces to NetworkManager signals
>
> This aids in the replacement of sigslot in webrtc.
>
> Bug: webrtc:42222066
> Change-Id: Ie82f49332a2c8c4238905b711be01f1d58b5c4c0
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7116598
> Reviewed-by: Stefan Zager <sza...@chromium.org>
> Reviewed-by: Danil Chapovalov <dani...@chromium.org>
> Commit-Queue: Harald Alvestrand <h...@chromium.org>
> Reviewed-by: Joe Downing <joe...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1540281}
>
Crash Bug: 457981105
Change-Id: I7dfd9461405a1ce00698c9a3064e92c5f66bf3e4
Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Reviewed-by: Joe Downing <joe...@chromium.org>
Reviewed-by: Tomas Gunnarsson <to...@chromium.org>
Commit-Queue: Ilya Nikolaevskiy <il...@chromium.org>
Reviewed-by: Ilya Nikolaevskiy <il...@chromium.org>
Reviewed-by: Danil Chapovalov <dani...@chromium.org>
Reviewed-by: Harald Alvestrand <h...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1540646}
Files:
- M remoting/test/fake_network_manager.cc
- M third_party/blink/renderer/platform/p2p/empty_network_manager.cc
- M third_party/blink/renderer/platform/p2p/filtering_network_manager.cc
- M third_party/blink/renderer/platform/p2p/filtering_network_manager_test.cc
- M third_party/blink/renderer/platform/p2p/ipc_network_manager.cc
Change size: S
Delta: 5 files changed, 13 insertions(+), 11 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Danil Chapovalov, +1 by Joe Downing, +1 by Tomas Gunnarsson, +1 by Harald Alvestrand, +1 by Ilya Nikolaevskiy, Bot-Commit+1 by Rubber Stamper
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Harald Alvestrand (Gerrit)
Nov 5, 2025, 11:57:36 AM (2 days ago) Nov 5
to Chromium LUCI CQ, Chrome Crash (Prod), Ilya Nikolaevskiy, Joe Downing, Tomas Gunnarsson, Danil Chapovalov, Rubber Stamper, Stefan Zager, AyeAye, chromotin...@chromium.org, chromium...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org
Harald Alvestrand has created a revert of this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages