extensions: Fix TabGroupsApiBrowserTest::SupportsTabGroups() [chromium/src : main]

0 views
Skip to first unread message

James Cook (Gerrit)

unread,
8:36 PM (3 hours ago) 8:36 PM
to Zoraiz Naeem, Achuith Bhandarkar, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Zoraiz Naeem

James Cook added 2 comments

Patchset-level comments
File-level comment, Patchset 1 (Latest):
James Cook . resolved

Zoraiz, please take a look.

File chrome/browser/extensions/api/tab_groups/tab_groups_api_browsertest.cc
Line 146, Patchset 1 (Latest): // Used as a utility function to reduce line wrapping.
James Cook . unresolved

I didn't just inline all the calls because I think they will make lines wrap. If you'd prefer me to inline them I can do that.

Open in Gerrit

Related details

Attention is currently required from:
  • Zoraiz Naeem
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib4cf47c4a4548ac583edfb7371292f5efe3173e1
Gerrit-Change-Number: 7467506
Gerrit-PatchSet: 1
Gerrit-Owner: James Cook <jame...@chromium.org>
Gerrit-Reviewer: James Cook <jame...@chromium.org>
Gerrit-Reviewer: Zoraiz Naeem <zorai...@chromium.org>
Gerrit-CC: Achuith Bhandarkar <ach...@chromium.org>
Gerrit-Attention: Zoraiz Naeem <zorai...@chromium.org>
Gerrit-Comment-Date: Wed, 14 Jan 2026 01:36:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages