[Sanitizer] Remove <base> in baseline config. [chromium/src : main]
0 views
Skip to first unread message
Daniel Vogelheim (Gerrit)
5:55 AM (6 hours ago) 5:55 AM
to Daniel Vogelheim, Yifan Luo, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Yifan Luo
Daniel Vogelheim voted and added 1 comment![]( "Open in Gerrit")
Votes added by Daniel Vogelheim
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Yifan Luo
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yifan Luo (Gerrit)
8:28 AM (3 hours ago) 8:28 AM
to Daniel Vogelheim, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Daniel Vogelheim
Yifan Luo voted and added 1 comment![]( "Open in Gerrit")
Attention is currently required from:
- Daniel Vogelheim
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniel Vogelheim (Gerrit)
10:24 AM (1 hour ago) 10:24 AM
to Daniel Vogelheim, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Daniel Vogelheim voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
10:29 AM (1 hour ago) 10:29 AM
to Daniel Vogelheim, Yifan Luo, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[Sanitizer] Remove <base> in baseline config.
This follows a spec update. The reason is that injected base elements
can modify the base URL, which in turn can modify the behaviour of
other elements' resource loads. Spec decision is to just remove this
entirely when "safe" sanitizing.
WPT change: https://github.com/web-platform-tests/wpt/pull/60993
Fixed: 532703005
Change-Id: I745745512ff834edf3668ee4fa43107c4d865845
Commit-Queue: Daniel Vogelheim <voge...@chromium.org>
Reviewed-by: Yifan Luo <l...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1659534}
Files:
- M third_party/blink/renderer/core/sanitizer/builtins_baseline_config.json
- D third_party/blink/web_tests/external/wpt/sanitizer-api/sanitizer-removeUnsafe-expected.txt
- D third_party/blink/web_tests/external/wpt/sanitizer-api/sethtml-safety-expected.txt
Change size: S
Delta: 3 files changed, 4 insertions(+), 10 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Yifan Luo
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages