[PassageEmbeddings] Simplify test ModelInfo setup [chromium/src : main]

0 views
Skip to first unread message

Mike Wittman (Gerrit)

unread,
Jul 21, 2026, 7:54:37 PM (yesterday) Jul 21
to Mike Wittman, Zekun Jiang, Chromium LUCI CQ, chromium...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com
Attention needed from Zekun Jiang

Mike Wittman voted and added 1 comment

Votes added by Mike Wittman

Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Mike Wittman . resolved

PTAL

Open in Gerrit

Related details

Attention is currently required from:
  • Zekun Jiang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I2f45fbb77e4ee417e14790ed3d9c8387de67f380
Gerrit-Change-Number: 8128192
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Wittman <wit...@chromium.org>
Gerrit-Reviewer: Mike Wittman <wit...@chromium.org>
Gerrit-Reviewer: Zekun Jiang <zekun...@google.com>
Gerrit-Attention: Zekun Jiang <zekun...@google.com>
Gerrit-Comment-Date: Tue, 21 Jul 2026 23:54:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Zekun Jiang (Gerrit)

unread,
4:27 PM (5 hours ago) 4:27 PM
to Mike Wittman, Chromium LUCI CQ, chromium...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com
Attention needed from Mike Wittman

Zekun Jiang voted and added 11 comments

Votes added by Zekun Jiang

Code-Review+1

11 comments

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Zekun Jiang . resolved

lgtm with most iwyu stuff

File chrome/browser/ai/ai_manager_unittest.cc
Line 148, Patchset 3 (Latest): optimization_guide::ModelInfo{
Zekun Jiang . unresolved

iwyu: `components/optimization_guide/core/delivery/model_info.h`. also applies to `ai_semantic_embedder_service_launcher_unittest.cc`

Line 149, Patchset 3 (Latest): .model_file_path = base::FilePath(FILE_PATH_LITERAL("embeddings")),
Zekun Jiang . unresolved

iwyu: `base/files/file_path.h`. also applies to `ai_semantic_embedder_service_launcher_unittest.cc`

File components/passage_embeddings/core/passage_embedder_model_observer_unittest.cc
Line 16, Patchset 3 (Latest):#include "components/passage_embeddings/core/passage_embeddings_test_util.h"
Zekun Jiang . unresolved

iwyu: no longer used

Line 132, Patchset 3 (Latest): model_provider->SetModelInfo(optimization_guide::ModelInfo{});
Zekun Jiang . unresolved

iwyu: `components/optimization_guide/core/delivery/model_info.h`

File components/passage_embeddings/core/passage_embeddings_service_controller_unittest.cc
Line 37, Patchset 3 (Latest): base::PathService::CheckedGet(base::DIR_SRC_TEST_DATA_ROOT)
Zekun Jiang . unresolved

iwyu: `base/base_paths.h` and `base/files/file_path.h`

Line 302, Patchset 3 (Latest): .version = 1,
Zekun Jiang . unresolved

nit: remove this

File components/passage_embeddings/core/passage_embeddings_test_util.h
Line 22, Patchset 3 (Latest):////////////////////////////////////////////////////////////////////////////////
Zekun Jiang . unresolved

nit: not sure what this was separating in the first place but maybe remove it since it's removed in the .cc file. also clean up the extra empty lines around here.

Line 14, Patchset 3 (Latest):#include "components/optimization_guide/core/delivery/model_info.h"
Zekun Jiang . unresolved

iwyu: no longer used

File components/passage_embeddings/core/passage_embeddings_test_util.cc
Line 7, Patchset 3 (Latest):#include "base/path_service.h"
Zekun Jiang . unresolved

iwyu: no longer used

Line 9, Patchset 3 (Latest):#include "components/optimization_guide/core/optimization_guide_proto_util.h"
#include "components/optimization_guide/proto/passage_embeddings_model_metadata.pb.h"
Zekun Jiang . unresolved

iwyu: no longer used

Open in Gerrit

Related details

Attention is currently required from:
  • Mike Wittman
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I2f45fbb77e4ee417e14790ed3d9c8387de67f380
    Gerrit-Change-Number: 8128192
    Gerrit-PatchSet: 3
    Gerrit-Owner: Mike Wittman <wit...@chromium.org>
    Gerrit-Reviewer: Mike Wittman <wit...@chromium.org>
    Gerrit-Reviewer: Zekun Jiang <zekun...@google.com>
    Gerrit-Attention: Mike Wittman <wit...@chromium.org>
    Gerrit-Comment-Date: Wed, 22 Jul 2026 20:27:37 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Mike Wittman (Gerrit)

    unread,
    5:54 PM (3 hours ago) 5:54 PM
    to Mike Wittman, Zekun Jiang, Chromium LUCI CQ, chromium...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com
    Attention needed from Zekun Jiang

    Mike Wittman added 10 comments

    File chrome/browser/ai/ai_manager_unittest.cc
    Line 148, Patchset 3: optimization_guide::ModelInfo{
    Zekun Jiang . resolved

    iwyu: `components/optimization_guide/core/delivery/model_info.h`. also applies to `ai_semantic_embedder_service_launcher_unittest.cc`

    Mike Wittman

    Done

    Line 149, Patchset 3: .model_file_path = base::FilePath(FILE_PATH_LITERAL("embeddings")),
    Zekun Jiang . resolved

    iwyu: `base/files/file_path.h`. also applies to `ai_semantic_embedder_service_launcher_unittest.cc`

    Mike Wittman

    Done

    File components/passage_embeddings/core/passage_embedder_model_observer_unittest.cc
    Line 16, Patchset 3:#include "components/passage_embeddings/core/passage_embeddings_test_util.h"
    Zekun Jiang . resolved

    iwyu: no longer used

    Mike Wittman

    Done

    Line 132, Patchset 3: model_provider->SetModelInfo(optimization_guide::ModelInfo{});
    Zekun Jiang . resolved

    iwyu: `components/optimization_guide/core/delivery/model_info.h`

    Mike Wittman

    Done

    File components/passage_embeddings/core/passage_embeddings_service_controller_unittest.cc
    Line 37, Patchset 3: base::PathService::CheckedGet(base::DIR_SRC_TEST_DATA_ROOT)
    Zekun Jiang . resolved

    iwyu: `base/base_paths.h` and `base/files/file_path.h`

    Mike Wittman

    Done

    Line 302, Patchset 3: .version = 1,
    Zekun Jiang . resolved

    nit: remove this

    Mike Wittman

    Done

    File components/passage_embeddings/core/passage_embeddings_test_util.h
    Line 22, Patchset 3:////////////////////////////////////////////////////////////////////////////////
    Zekun Jiang . resolved

    nit: not sure what this was separating in the first place but maybe remove it since it's removed in the .cc file. also clean up the extra empty lines around here.

    Mike Wittman

    Done

    Line 14, Patchset 3:#include "components/optimization_guide/core/delivery/model_info.h"
    Zekun Jiang . resolved

    iwyu: no longer used

    Mike Wittman

    Done

    File components/passage_embeddings/core/passage_embeddings_test_util.cc
    Line 7, Patchset 3:#include "base/path_service.h"
    Zekun Jiang . resolved

    iwyu: no longer used

    Mike Wittman

    Done

    Line 9, Patchset 3:#include "components/optimization_guide/core/optimization_guide_proto_util.h"
    #include "components/optimization_guide/proto/passage_embeddings_model_metadata.pb.h"
    Zekun Jiang . resolved

    iwyu: no longer used

    Mike Wittman

    Done

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Zekun Jiang
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I2f45fbb77e4ee417e14790ed3d9c8387de67f380
      Gerrit-Change-Number: 8128192
      Gerrit-PatchSet: 5
      Gerrit-Owner: Mike Wittman <wit...@chromium.org>
      Gerrit-Reviewer: Mike Wittman <wit...@chromium.org>
      Gerrit-Reviewer: Zekun Jiang <zekun...@google.com>
      Gerrit-Attention: Zekun Jiang <zekun...@google.com>
      Gerrit-Comment-Date: Wed, 22 Jul 2026 21:54:09 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Zekun Jiang <zekun...@google.com>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Mike Wittman (Gerrit)

      unread,
      5:55 PM (3 hours ago) 5:55 PM
      to Mike Wittman, Jingyun Liu, Zekun Jiang, Chromium LUCI CQ, chromium...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com
      Attention needed from Jingyun Liu and Zekun Jiang

      Mike Wittman added 1 comment

      Patchset-level comments
      File-level comment, Patchset 5 (Latest):
      Mike Wittman . resolved

      +jingyun for chrome/browser/ai

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Jingyun Liu
      • Zekun Jiang
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I2f45fbb77e4ee417e14790ed3d9c8387de67f380
      Gerrit-Change-Number: 8128192
      Gerrit-PatchSet: 5
      Gerrit-Owner: Mike Wittman <wit...@chromium.org>
      Gerrit-Reviewer: Jingyun Liu <jin...@google.com>
      Gerrit-Reviewer: Mike Wittman <wit...@chromium.org>
      Gerrit-Reviewer: Zekun Jiang <zekun...@google.com>
      Gerrit-Attention: Zekun Jiang <zekun...@google.com>
      Gerrit-Attention: Jingyun Liu <jin...@google.com>
      Gerrit-Comment-Date: Wed, 22 Jul 2026 21:55:22 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Jingyun Liu (Gerrit)

      unread,
      6:00 PM (3 hours ago) 6:00 PM
      to Mike Wittman, Zekun Jiang, Chromium LUCI CQ, chromium...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com
      Attention needed from Mike Wittman and Zekun Jiang

      Jingyun Liu voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Mike Wittman
      • Zekun Jiang
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I2f45fbb77e4ee417e14790ed3d9c8387de67f380
      Gerrit-Change-Number: 8128192
      Gerrit-PatchSet: 5
      Gerrit-Owner: Mike Wittman <wit...@chromium.org>
      Gerrit-Reviewer: Jingyun Liu <jin...@google.com>
      Gerrit-Reviewer: Mike Wittman <wit...@chromium.org>
      Gerrit-Reviewer: Zekun Jiang <zekun...@google.com>
      Gerrit-Attention: Zekun Jiang <zekun...@google.com>
      Gerrit-Attention: Mike Wittman <wit...@chromium.org>
      Gerrit-Comment-Date: Wed, 22 Jul 2026 22:00:16 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Zekun Jiang (Gerrit)

      unread,
      6:41 PM (2 hours ago) 6:41 PM
      to Mike Wittman, Jingyun Liu, Chromium LUCI CQ, chromium...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com
      Attention needed from Mike Wittman

      Zekun Jiang voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Mike Wittman
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I2f45fbb77e4ee417e14790ed3d9c8387de67f380
      Gerrit-Change-Number: 8128192
      Gerrit-PatchSet: 5
      Gerrit-Owner: Mike Wittman <wit...@chromium.org>
      Gerrit-Reviewer: Jingyun Liu <jin...@google.com>
      Gerrit-Reviewer: Mike Wittman <wit...@chromium.org>
      Gerrit-Reviewer: Zekun Jiang <zekun...@google.com>
      Gerrit-Attention: Mike Wittman <wit...@chromium.org>
      Gerrit-Comment-Date: Wed, 22 Jul 2026 22:41:17 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Mike Wittman (Gerrit)

      unread,
      7:21 PM (2 hours ago) 7:21 PM
      to Mike Wittman, Zekun Jiang, Jingyun Liu, Chromium LUCI CQ, chromium...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com

      Mike Wittman voted Commit-Queue+2

      Commit-Queue+2
      Open in Gerrit

      Related details

      Attention set is empty
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I2f45fbb77e4ee417e14790ed3d9c8387de67f380
      Gerrit-Change-Number: 8128192
      Gerrit-PatchSet: 5
      Gerrit-Owner: Mike Wittman <wit...@chromium.org>
      Gerrit-Reviewer: Jingyun Liu <jin...@google.com>
      Gerrit-Reviewer: Mike Wittman <wit...@chromium.org>
      Gerrit-Reviewer: Zekun Jiang <zekun...@google.com>
      Gerrit-Comment-Date: Wed, 22 Jul 2026 23:21:08 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Chromium LUCI CQ (Gerrit)

      unread,
      7:25 PM (2 hours ago) 7:25 PM
      to Mike Wittman, Zekun Jiang, Jingyun Liu, chromium...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com

      Chromium LUCI CQ submitted the change

      Change information

      Commit message:
      [PassageEmbeddings] Simplify test ModelInfo setup

      Replace passage_embeddings::GetValidModelInfo() with direct
      construction of optimization_guide::ModelInfo across tests.

      Previously, tests used GetValidModelInfo(), which resolved fake model
      files on disk via base::PathService and constructed full metadata protos
      even for tests that only checked model availability or null checks.

      This change replaces GetValidModelInfo() with direct ModelInfo struct
      initialization tailored to each test's requirements, and moves this
      setup close to the tests for improved readability:
      - Observer tests pass an empty ModelInfo{}.
      - Availability tests construct lightweight ModelInfo structs with
        inline PassageEmbeddingsModelMetadata proto parameters and dummy
        file paths.
      - Service controller tests use a single local GetTestModelInfo()
        helper returning real test data file paths for Mojo IPC validation.

      GetValidModelInfo() is removed from passage_embeddings_test_util as
      it has no remaining usages.
      Bug: 522111615
      Test: components_unittests, unit_tests
      Change-Id: I2f45fbb77e4ee417e14790ed3d9c8387de67f380
      Reviewed-by: Jingyun Liu <jin...@google.com>
      Commit-Queue: Mike Wittman <wit...@chromium.org>
      Reviewed-by: Zekun Jiang <zekun...@google.com>
      Cr-Commit-Position: refs/heads/main@{#1666697}
      Files:
      • M chrome/browser/ai/ai_manager_unittest.cc
      • M chrome/browser/ai/ai_semantic_embedder_service_launcher_unittest.cc
      • M components/passage_embeddings/core/BUILD.gn
      • M components/passage_embeddings/core/passage_embedder_model_observer_unittest.cc
      • M components/passage_embeddings/core/passage_embeddings_service_controller_unittest.cc
      • M components/passage_embeddings/core/passage_embeddings_test_util.cc
      • M components/passage_embeddings/core/passage_embeddings_test_util.h
      Change size: M
      Delta: 7 files changed, 66 insertions(+), 68 deletions(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by Zekun Jiang, +1 by Jingyun Liu
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I2f45fbb77e4ee417e14790ed3d9c8387de67f380
      Gerrit-Change-Number: 8128192
      Gerrit-PatchSet: 6
      Gerrit-Owner: Mike Wittman <wit...@chromium.org>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Jingyun Liu <jin...@google.com>
      Gerrit-Reviewer: Mike Wittman <wit...@chromium.org>
      Gerrit-Reviewer: Zekun Jiang <zekun...@google.com>
      open
      diffy
      satisfied_requirement
      Reply all
      Reply to author
      Forward
      0 new messages