[APC] Improve performance by using fewer DOMNodeIDs [chromium/src : main]

0 views

Skip to first unread message

AI Code Reviewer (Gerrit)

unread,

10:19 AM (2 hours ago) 10:19 AM

to Aaron Leventhal, Chromium LUCI CQ, chromium...@chromium.org, aleventh...@chromium.org, blink-...@chromium.org, mfoltz+wa...@chromium.org

AI Code Reviewer added 1 comment

File third_party/blink/renderer/modules/content_extraction/ai_page_content_agent.h

Line 195, Patchset 1 (Latest): HashMap<uintptr_t, int32_t> dom_node_to_z_order_;

AI Code Reviewer . unresolved

Blink Style Guide: Prefer blink:: types over STL and base types. Consider using 'HeapHashMap<Member<Node>, int32_t>' instead of 'HashMap<uintptr_t, int32_t>' to ensure proper handling of GarbageCollected objects and avoid raw pointer casting.

To keep this interaction as brief and non-intrusive as possible, please consider responding with one of following options:
**Done** | **OK But Won't Fix**: reason | **Later**: b/<bug_id> | **Invalid:** reason

_This comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent)._
_AI reviews can sometimes be inaccurate; We appreciate your 🙏 feedback 🙏 to help us improve._
_[File a bug](http://go/blink-c++-code-review-agent-feedback) | [Provide feedback on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4) | [Opt-out](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)_

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages