Ash: Migrate ArcSupportHost off ProfileHelper [chromium/src : main]
0 views
Skip to first unread message
Yury Khmel (Gerrit)
Jul 10, 2026, 10:41:41 AM (11 days ago) Jul 10
to Di Wu, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, arc-review...@google.com, hidehik...@chromium.org, yhanada+...@chromium.org
Attention needed from Di Wu
Yury Khmel voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Di Wu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Di Wu (Gerrit)
1:16 AM (17 hours ago) 1:16 AM
to Yury Khmel, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, arc-review...@google.com, hidehik...@chromium.org, yhanada+...@chromium.org
Di Wu voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
1:52 AM (17 hours ago) 1:52 AM
to Di Wu, Yury Khmel, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, arc-review...@google.com, hidehik...@chromium.org, yhanada+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Ash: Migrate ArcSupportHost off ProfileHelper
This changelist is part of an ongoing series to decouple ChromeOS
code from the main Chrome browser codebase. By migrating away from
ash::ProfileHelper (//chrome/browser/ash) to lower-level Ash APIs such
as ash::BrowserContextHelper (//chromeos/ash/components), it removes
inappropriate upward dependencies from lower-level Ash components to
the higher-level browser application layer. This modernization also
moves code away from heavy, UI-bound Profile objects and toward the
cleaner content::BrowserContext abstraction. Where ProfileHelper wraps
user checks, the migration uses components/user_manager directly.
ArcSupportHost now asks BrowserContextHelper for the user attached to
its profile before checking owner status through user_manager. The
existing ARC target already depends on both lower-level helpers, so this
removes the stale ProfileHelper include and target dependency without
changing the load-time data key.
Bug: b:511961755
Test: CQ
Change-Id: I8897a72121814d68c1173ffbe233119303cbfa56
Commit-Queue: Di Wu <di...@google.com>
Reviewed-by: Yury Khmel <kh...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1665196}
Files:
- M chrome/browser/ash/arc/BUILD.gn
- M chrome/browser/ash/arc/arc_support_host.cc
Change size: XS
Delta: 2 files changed, 4 insertions(+), 4 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Yury Khmel
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages