Set symbol_level=1 on android-arm64-rel trybot [chromium/src : main]

0 views
Skip to first unread message

Andrew Grieve (Gerrit)

unread,
Apr 20, 2026, 8:32:17 PM (10 days ago) Apr 20
to Andrew Grieve, Haiyang Pan, Ben Pastene, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Ben Pastene and Haiyang Pan

Andrew Grieve added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Andrew Grieve . resolved

of the 3 android trybots, this one had the smallest times when looking at their "started builds".

Open in Gerrit

Related details

Attention is currently required from:
  • Ben Pastene
  • Haiyang Pan
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ifa110945731fc639ada7dfb7d3d36eb1966c7a8c
Gerrit-Change-Number: 7780729
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Grieve <agr...@chromium.org>
Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
Gerrit-Reviewer: Ben Pastene <bpas...@chromium.org>
Gerrit-Reviewer: Haiyang Pan <hy...@google.com>
Gerrit-Attention: Ben Pastene <bpas...@chromium.org>
Gerrit-Attention: Haiyang Pan <hy...@google.com>
Gerrit-Comment-Date: Tue, 21 Apr 2026 00:32:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Ben Pastene (Gerrit)

unread,
Apr 20, 2026, 8:35:47 PM (10 days ago) Apr 20
to Andrew Grieve, Haiyang Pan, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Andrew Grieve and Haiyang Pan

Ben Pastene voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Andrew Grieve
  • Haiyang Pan
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ifa110945731fc639ada7dfb7d3d36eb1966c7a8c
Gerrit-Change-Number: 7780729
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Grieve <agr...@chromium.org>
Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
Gerrit-Reviewer: Ben Pastene <bpas...@chromium.org>
Gerrit-Reviewer: Haiyang Pan <hy...@google.com>
Gerrit-Attention: Andrew Grieve <agr...@chromium.org>
Gerrit-Attention: Haiyang Pan <hy...@google.com>
Gerrit-Comment-Date: Tue, 21 Apr 2026 00:35:39 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Andrew Grieve (Gerrit)

unread,
Apr 20, 2026, 9:04:54 PM (10 days ago) Apr 20
to Andrew Grieve, Ben Pastene, Haiyang Pan, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Haiyang Pan

Andrew Grieve voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Haiyang Pan
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ifa110945731fc639ada7dfb7d3d36eb1966c7a8c
Gerrit-Change-Number: 7780729
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Grieve <agr...@chromium.org>
Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
Gerrit-Reviewer: Ben Pastene <bpas...@chromium.org>
Gerrit-Reviewer: Haiyang Pan <hy...@google.com>
Gerrit-Attention: Haiyang Pan <hy...@google.com>
Gerrit-Comment-Date: Tue, 21 Apr 2026 01:04:48 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Andrew Grieve (Gerrit)

unread,
Apr 20, 2026, 9:05:28 PM (10 days ago) Apr 20
to Andrew Grieve, Ben Pastene, Haiyang Pan, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Haiyang Pan

Andrew Grieve removed a vote from this change

Removed Commit-Queue+2 by Andrew Grieve <agr...@chromium.org>
Open in Gerrit

Related details

Attention is currently required from:
  • Haiyang Pan
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: deleteVote
satisfied_requirement
open
diffy

Andrew Grieve (Gerrit)

unread,
Apr 20, 2026, 9:07:19 PM (10 days ago) Apr 20
to Andrew Grieve, Ben Pastene, Haiyang Pan, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Haiyang Pan

Andrew Grieve added 1 comment

Patchset-level comments
Andrew Grieve . resolved

Hmm, the compilator gn args still show strip_debug_info=true...
https://ci.chromium.org/ui/p/chromium/builders/try/android-arm64-rel-compilator/1424004/overview

Should it not be reflected?

Open in Gerrit

Related details

Attention is currently required from:
  • Haiyang Pan
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ifa110945731fc639ada7dfb7d3d36eb1966c7a8c
Gerrit-Change-Number: 7780729
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Grieve <agr...@chromium.org>
Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
Gerrit-Reviewer: Ben Pastene <bpas...@chromium.org>
Gerrit-Reviewer: Haiyang Pan <hy...@google.com>
Gerrit-Attention: Haiyang Pan <hy...@google.com>
Gerrit-Comment-Date: Tue, 21 Apr 2026 01:07:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
open
diffy

Andrew Grieve (Gerrit)

unread,
Apr 20, 2026, 9:08:13 PM (10 days ago) Apr 20
to Andrew Grieve, Ben Pastene, Haiyang Pan, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Haiyang Pan

Andrew Grieve added 2 comments

Patchset-level comments
Andrew Grieve . resolved

Oh

Andrew Grieve . unresolved

Hmm, the compilator gn args still show strip_debug_info=true...
https://ci.chromium.org/ui/p/chromium/builders/try/android-arm64-rel-compilator/1424004/overview

Should it not be reflected?

Andrew Grieve

Oh... I only set symbol_level... not strip_debug_info...

Open in Gerrit

Related details

Attention is currently required from:
  • Haiyang Pan
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ifa110945731fc639ada7dfb7d3d36eb1966c7a8c
    Gerrit-Change-Number: 7780729
    Gerrit-PatchSet: 1
    Gerrit-Owner: Andrew Grieve <agr...@chromium.org>
    Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
    Gerrit-Reviewer: Ben Pastene <bpas...@chromium.org>
    Gerrit-Reviewer: Haiyang Pan <hy...@google.com>
    Gerrit-Attention: Haiyang Pan <hy...@google.com>
    Gerrit-Comment-Date: Tue, 21 Apr 2026 01:08:06 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Andrew Grieve <agr...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Andrew Grieve (Gerrit)

    unread,
    Apr 20, 2026, 9:20:09 PM (10 days ago) Apr 20
    to Andrew Grieve, Ben Pastene, Haiyang Pan, Chromium LUCI CQ, chromium...@chromium.org
    Attention needed from Haiyang Pan

    Andrew Grieve voted and added 1 comment

    Votes added by Andrew Grieve

    Commit-Queue+2

    1 comment

    Patchset-level comments
    Andrew Grieve . resolved

    Hmm, the compilator gn args still show strip_debug_info=true...
    https://ci.chromium.org/ui/p/chromium/builders/try/android-arm64-rel-compilator/1424004/overview

    Should it not be reflected?

    Andrew Grieve

    Oh... I only set symbol_level... not strip_debug_info...

    Andrew Grieve

    Ah, okay, my other CL should remove that: https://chromium-review.git.corp.google.com/c/chromium/src/+/7780134

    This CL will still test compile times. The other CL will be needed to actually fix stacks. (symbol_level applies to compile step, strip_debug_info applies to link step)

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Haiyang Pan
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ifa110945731fc639ada7dfb7d3d36eb1966c7a8c
      Gerrit-Change-Number: 7780729
      Gerrit-PatchSet: 1
      Gerrit-Owner: Andrew Grieve <agr...@chromium.org>
      Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
      Gerrit-Reviewer: Ben Pastene <bpas...@chromium.org>
      Gerrit-Reviewer: Haiyang Pan <hy...@google.com>
      Gerrit-Attention: Haiyang Pan <hy...@google.com>
      Gerrit-Comment-Date: Tue, 21 Apr 2026 01:20:02 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      Comment-In-Reply-To: Andrew Grieve <agr...@chromium.org>
      satisfied_requirement
      open
      diffy

      Andrew Grieve (Gerrit)

      unread,
      Apr 20, 2026, 9:23:22 PM (10 days ago) Apr 20
      to Andrew Grieve, Ben Pastene, Haiyang Pan, Chromium LUCI CQ, chromium...@chromium.org
      Attention needed from Haiyang Pan

      Andrew Grieve removed a vote from this change

      Removed Commit-Queue+2 by Andrew Grieve <agr...@chromium.org>

      Related details

      Attention is currently required from:
      • Haiyang Pan
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: deleteVote
      satisfied_requirement
      open
      diffy

      Junji Watanabe (Gerrit)

      unread,
      Apr 21, 2026, 9:11:48 AM (10 days ago) Apr 21
      to Andrew Grieve, Ben Pastene, Haiyang Pan, Chromium LUCI CQ, chromium...@chromium.org

      Junji Watanabe voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention set is empty
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ifa110945731fc639ada7dfb7d3d36eb1966c7a8c
      Gerrit-Change-Number: 7780729
      Gerrit-PatchSet: 3
      Gerrit-Owner: Andrew Grieve <agr...@chromium.org>
      Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
      Gerrit-Reviewer: Ben Pastene <bpas...@chromium.org>
      Gerrit-Reviewer: Haiyang Pan <hy...@google.com>
      Gerrit-Reviewer: Junji Watanabe <jw...@google.com>
      Gerrit-Comment-Date: Tue, 21 Apr 2026 13:11:11 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Andrew Grieve (Gerrit)

      unread,
      Apr 23, 2026, 10:08:49 AM (7 days ago) Apr 23
      to Andrew Grieve, Junji Watanabe, Ben Pastene, Haiyang Pan, Chromium LUCI CQ, chromium...@chromium.org
      Attention needed from Andrew Grieve, Ben Pastene, Haiyang Pan and Junji Watanabe

      Message from Andrew Grieve

      Set Ready For Review

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Andrew Grieve
      • Ben Pastene
      • Haiyang Pan
      • Junji Watanabe
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ifa110945731fc639ada7dfb7d3d36eb1966c7a8c
      Gerrit-Change-Number: 7780729
      Gerrit-PatchSet: 3
      Gerrit-Owner: Andrew Grieve <agr...@chromium.org>
      Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
      Gerrit-Reviewer: Ben Pastene <bpas...@chromium.org>
      Gerrit-Reviewer: Haiyang Pan <hy...@google.com>
      Gerrit-Reviewer: Junji Watanabe <jw...@google.com>
      Gerrit-Attention: Ben Pastene <bpas...@chromium.org>
      Gerrit-Attention: Andrew Grieve <agr...@chromium.org>
      Gerrit-Attention: Haiyang Pan <hy...@google.com>
      Gerrit-Attention: Junji Watanabe <jw...@google.com>
      Gerrit-Comment-Date: Thu, 23 Apr 2026 14:08:36 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: No
      satisfied_requirement
      open
      diffy

      Andrew Grieve (Gerrit)

      unread,
      Apr 23, 2026, 10:09:08 AM (7 days ago) Apr 23
      to Andrew Grieve, Junji Watanabe, Ben Pastene, Haiyang Pan, Chromium LUCI CQ, chromium...@chromium.org
      Attention needed from Ben Pastene, Haiyang Pan and Junji Watanabe

      Andrew Grieve voted Commit-Queue+2

      Commit-Queue+2
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Ben Pastene
      • Haiyang Pan
      • Junji Watanabe
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ifa110945731fc639ada7dfb7d3d36eb1966c7a8c
      Gerrit-Change-Number: 7780729
      Gerrit-PatchSet: 4
      Gerrit-Owner: Andrew Grieve <agr...@chromium.org>
      Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
      Gerrit-Reviewer: Ben Pastene <bpas...@chromium.org>
      Gerrit-Reviewer: Haiyang Pan <hy...@google.com>
      Gerrit-Reviewer: Junji Watanabe <jw...@google.com>
      Gerrit-Attention: Ben Pastene <bpas...@chromium.org>
      Gerrit-Attention: Haiyang Pan <hy...@google.com>
      Gerrit-Attention: Junji Watanabe <jw...@google.com>
      Gerrit-Comment-Date: Thu, 23 Apr 2026 14:08:58 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Chromium LUCI CQ (Gerrit)

      unread,
      Apr 23, 2026, 11:16:08 AM (7 days ago) Apr 23
      to Andrew Grieve, Junji Watanabe, Ben Pastene, Haiyang Pan, chromium...@chromium.org

      Chromium LUCI CQ submitted the change

      Unreviewed changes

      3 is the latest approved patch-set.
      No files were changed between the latest approved patch-set and the submitted one.

      Change information

      Commit message:
      Set symbol_level=1 on android-arm64-rel trybot

      With it set to 0, we don't get line numbers for stacks.

      Before: https://ci.chromium.org/ui/p/chromium/builders/try/android-x64-rel/892829/overview
      After: https://ci.chromium.org/ui/p/chromium/builders/try/android-x64-rel/893135/overview
      Bug: 503797275
      Change-Id: Ifa110945731fc639ada7dfb7d3d36eb1966c7a8c
      Cq-Include-Trybots: luci.chrome.try:android-internal-dbg,android-internal-binary-size
      Reviewed-by: Junji Watanabe <jw...@google.com>
      Commit-Queue: Andrew Grieve <agr...@chromium.org>
      Reviewed-by: Ben Pastene <bpas...@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#1619531}
      Files:
      • M infra/config/generated/builders/build/android-build-perf-ninja/gn-args.json
      • M infra/config/generated/builders/build/android-build-perf-siso/gn-args.json
      • M infra/config/generated/builders/try/android-arm64-rel/gn-args.json
      • M infra/config/subprojects/chromium/try/tryserver.chromium.android.star
      Change size: XS
      Delta: 4 files changed, 5 insertions(+), 4 deletions(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by Ben Pastene, +1 by Junji Watanabe
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ifa110945731fc639ada7dfb7d3d36eb1966c7a8c
      Gerrit-Change-Number: 7780729
      Gerrit-PatchSet: 5
      Gerrit-Owner: Andrew Grieve <agr...@chromium.org>
      Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
      Gerrit-Reviewer: Ben Pastene <bpas...@chromium.org>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Haiyang Pan <hy...@google.com>
      Gerrit-Reviewer: Junji Watanabe <jw...@google.com>
      open
      diffy
      satisfied_requirement

      Andrew Grieve (Gerrit)

      unread,
      Apr 23, 2026, 5:22:49 PM (7 days ago) Apr 23
      to Andrew Grieve, Chromium LUCI CQ, Junji Watanabe, Ben Pastene, Haiyang Pan, chromium...@chromium.org

      Andrew Grieve has created a revert of this change

      Related details

      Attention set is empty
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: revert
      satisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages