viz: Add MojoLPM fuzzer for CompositorFrameSink::SubmitCompositorFrame [chromium/src : main]

0 views
Skip to first unread message

ᄋᄋ (Gerrit)

unread,
Jun 22, 2026, 4:40:19 AMJun 22
to chromium...@chromium.org, ortuno...@chromium.org, cc-...@chromium.org, titoua...@chromium.org, droger+w...@chromium.org

ᄋᄋ has uploaded the change for review

Commit message

viz: Add MojoLPM fuzzer for CompositorFrameSink::SubmitCompositorFrame

Adds a libFuzzer target that drives the renderer->Viz CompositorFrameSink
interface (SubmitCompositorFrame, declared [UnlimitedSize] in the mojom)
against a real CompositorFrameSinkSupport backed by a FrameSinkManagerImpl,
so the full CompositorFrame StructTraits::Read + MaybeSubmitCompositorFrame
surface-activation / resource-refcount path is exercised from attacker-shaped
input. No existing in-tree fuzzer covers this surface (hit_test_manager_fuzzer
only submits a fixed MakeDefaultCompositorFrame).

Bug: none
Test: built with is_asan=true use_libfuzzer=true enable_mojom_fuzzer=true; the
seed corpus drives the deserialize + activation path and smoke-runs with no
crashes.
Change-Id: I1c93b505c2ee5dda721498733729d92e29eb2b8c

Change diff


Change information

Files:
  • M components/viz/service/BUILD.gn
  • M components/viz/service/frame_sinks/DEPS
  • A components/viz/service/frame_sinks/compositor_frame_sink_mojolpm_fuzzer.cc
  • A components/viz/service/frame_sinks/compositor_frame_sink_mojolpm_fuzzer.proto
  • A components/viz/service/frame_sinks/compositor_frame_sink_mojolpm_fuzzer_seed_corpus/simple.textproto
Change size: L
Delta: 5 files changed, 636 insertions(+), 1 deletion(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I1c93b505c2ee5dda721498733729d92e29eb2b8c
Gerrit-Change-Number: 7976443
Gerrit-PatchSet: 1
Gerrit-Owner: ᄋᄋ <tjdd...@gmail.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

ᄋᄋ (Gerrit)

unread,
Jun 22, 2026, 4:40:42 AMJun 22
to chromium...@chromium.org, ortuno...@chromium.org, feature-me...@chromium.org, chromeos-gfx-...@google.com, media-cro...@chromium.org, titoua...@chromium.org

ᄋᄋ has uploaded the change for review

Commit message

viz: Add MojoLPM fuzzer for CompositorFrameSink::SubmitCompositorFrame

Adds a libFuzzer target that drives the renderer->Viz CompositorFrameSink
interface (SubmitCompositorFrame, declared [UnlimitedSize] in the mojom)
against a real CompositorFrameSinkSupport backed by a FrameSinkManagerImpl,
so the full CompositorFrame StructTraits::Read + MaybeSubmitCompositorFrame
surface-activation / resource-refcount path is exercised from attacker-shaped
input. No existing in-tree fuzzer covers this surface (hit_test_manager_fuzzer
only submits a fixed MakeDefaultCompositorFrame).

Bug: none
Test: built with is_asan=true use_libfuzzer=true enable_mojom_fuzzer=true; the
seed corpus drives the deserialize + activation path and smoke-runs with no
crashes.

Change diff


Change information

Files:
  • M components/viz/service/BUILD.gn
  • M components/viz/service/frame_sinks/DEPS
  • A components/viz/service/frame_sinks/compositor_frame_sink_mojolpm_fuzzer.cc
  • A components/viz/service/frame_sinks/compositor_frame_sink_mojolpm_fuzzer.proto
  • A components/viz/service/frame_sinks/compositor_frame_sink_mojolpm_fuzzer_seed_corpus/simple.textproto
Change size: L
Delta: 5 files changed, 636 insertions(+), 1 deletion(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie1755ebae6ad4aaa2d8f62425b3e5c97d23b6e30
Gerrit-Change-Number: 7977564
satisfied_requirement
unsatisfied_requirement
open
diffy

ᄋᄋ (Gerrit)

unread,
Jun 22, 2026, 4:46:22 AMJun 22
to chromium...@chromium.org, cc-...@chromium.org, droger+w...@chromium.org, ortuno...@chromium.org, titoua...@chromium.org

ᄋᄋ abandoned this change.

View Change

Abandoned Duplicate created by a relation-chain upload mistake (parent commit was amended with a Change-Id after the child branches were cut, so the chained upload re-created ancestor CLs). Superseded by the correctly-chained CL of the same change. Abandoning to de-duplicate.

ᄋᄋ abandoned this change

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: abandon
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I1c93b505c2ee5dda721498733729d92e29eb2b8c
Gerrit-Change-Number: 7976443
satisfied_requirement
unsatisfied_requirement
open
diffy

ᄋᄋ (Gerrit)

unread,
Jun 22, 2026, 5:01:07 AMJun 22
to Vladimir Levin, Saifuddin Hitawala, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, droger+w...@chromium.org, cc-...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org, ortuno...@chromium.org, titoua...@chromium.org
Attention needed from Saifuddin Hitawala and Vladimir Levin

Message from ᄋᄋ

New libFuzzer target driving viz.mojom.CompositorFrameSink::SubmitCompositorFrame (the full CompositorFrame StructTraits::Read + MaybeSubmitCompositorFrame activation path) via a real CompositorFrameSinkSupport. No existing fuzzer exercises an attacker-shaped frame (hit_test_manager_fuzzer only submits a fixed MakeDefaultCompositorFrame). PTAL. Part of a 4-CL fuzzer suite (gpu crrev.com/c/7976442, viz /7977564, media /7976699, network /7976700). First-time external contributor -- happy to adjust to conventions.

Open in Gerrit

Related details

Attention is currently required from:
  • Saifuddin Hitawala
  • Vladimir Levin
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie1755ebae6ad4aaa2d8f62425b3e5c97d23b6e30
Gerrit-Change-Number: 7977564
Gerrit-PatchSet: 1
Gerrit-Owner: ᄋᄋ <tjdd...@gmail.com>
Gerrit-Reviewer: Saifuddin Hitawala <hita...@chromium.org>
Gerrit-Reviewer: Vladimir Levin <vmp...@chromium.org>
Gerrit-Attention: Saifuddin Hitawala <hita...@chromium.org>
Gerrit-Attention: Vladimir Levin <vmp...@chromium.org>
Gerrit-Comment-Date: Mon, 22 Jun 2026 09:00:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Vladimir Levin (Gerrit)

unread,
Jun 22, 2026, 11:42:50 AMJun 22
to ᄋᄋ, Saifuddin Hitawala, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, droger+w...@chromium.org, cc-...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org, ortuno...@chromium.org, titoua...@chromium.org
Attention needed from Saifuddin Hitawala and ᄋᄋ

Vladimir Levin added 7 comments

File components/viz/service/frame_sinks/compositor_frame_sink_mojolpm_fuzzer.cc
Line 128, Patchset 1 (Latest):// compositor_frame_sink_support.cc:772 and reach the deeper service
Vladimir Levin . unresolved

Putting line numbers in comments will get out of date really quickly

Line 148, Patchset 1 (Latest): u->mutable_new_();
Vladimir Levin . unresolved

should this be a return or am I missing some subtlety

Line 186, Patchset 1 (Latest): if (!new_pass->has_m_quad_list()) {
Vladimir Levin . unresolved

Not sure if we also want to clamp (or if we generate) the shared quad state list

Line 226, Patchset 1 (Latest): ack->set_m_sequence_number(1);
Vladimir Levin . unresolved

It seems like we always just want to generate a new compositor frame with a new render pass etc based on the fuzzer input. It's unclear to me what the AsFreshOrNull does or why we need it

Line 243, Patchset 1 (Latest):class FrameSinkFuzzerHarness {
Vladimir Levin . unresolved

Is it possible for this fuzzer to span several files? Not sure of any precedents

Line 330, Patchset 1 (Latest): (void)support->MaybeSubmitCompositorFrame(
Vladimir Levin . unresolved

std::ignore = ...

Line 339, Patchset 1 (Latest): (void)support->DidNotProduceFrame(ack);
Vladimir Levin . unresolved

same

Open in Gerrit

Related details

Attention is currently required from:
  • Saifuddin Hitawala
  • ᄋᄋ
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie1755ebae6ad4aaa2d8f62425b3e5c97d23b6e30
    Gerrit-Change-Number: 7977564
    Gerrit-PatchSet: 1
    Gerrit-Owner: ᄋᄋ <tjdd...@gmail.com>
    Gerrit-Reviewer: Saifuddin Hitawala <hita...@chromium.org>
    Gerrit-Reviewer: Vladimir Levin <vmp...@chromium.org>
    Gerrit-Attention: Saifuddin Hitawala <hita...@chromium.org>
    Gerrit-Attention: ᄋᄋ <tjdd...@gmail.com>
    Gerrit-Comment-Date: Mon, 22 Jun 2026 15:42:30 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    ᄋᄋ (Gerrit)

    unread,
    Jun 22, 2026, 1:25:02 PMJun 22
    to Chromium LUCI CQ, Giovanni Ortuno Urquidi, Vladimir Levin, Saifuddin Hitawala, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, droger+w...@chromium.org, cc-...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org, ortuno...@chromium.org, titoua...@chromium.org
    Attention needed from Saifuddin Hitawala and Vladimir Levin

    ᄋᄋ added 7 comments

    File components/viz/service/frame_sinks/compositor_frame_sink_mojolpm_fuzzer.cc
    Line 128, Patchset 1:// compositor_frame_sink_support.cc:772 and reach the deeper service
    Vladimir Levin . resolved

    Putting line numbers in comments will get out of date really quickly

    ᄋᄋ

    Done -- removed every source-line-number citation from the comments here and in the .proto, now phrased by symbol/concept instead.

    Line 148, Patchset 1: u->mutable_new_();
    Vladimir Levin . resolved

    should this be a return or am I missing some subtlety

    ᄋᄋ

    Made it a direct `return u->mutable_new_();`. No subtlety lost: mutable_new_() switches the union to the kNew arm, so the old code already fell through the next guard and returned the same pointer -- this just makes it explicit.

    Line 186, Patchset 1: if (!new_pass->has_m_quad_list()) {
    Vladimir Levin . resolved

    Not sure if we also want to clamp (or if we generate) the shared quad state list

    ᄋᄋ

    No separate clamp needed; documented inline. The mojom render pass carries only quad_list; each DrawQuad has an optional inline sqs and the traits rebuild the C++ shared_quad_state_list at most one-per-quad, so the quad clamp already bounds the SQS count.

    Line 226, Patchset 1: ack->set_m_sequence_number(1);
    Vladimir Levin . resolved

    It seems like we always just want to generate a new compositor frame with a new render pass etc based on the fuzzer input. It's unclear to me what the AsFreshOrNull does or why we need it

    ᄋᄋ

    Agreed -- dropped the AsFreshOrNull indirection for the top-level frame. ShapeCompositorFrame now unconditionally calls mutable_new_(), so a fresh frame is always built from the input (an 'old' back-reference is cleared; an existing 'new' arm's fields are preserved). Verified the seed still drives a real SubmitCompositorFrame (ft 3330).

    Line 243, Patchset 1:class FrameSinkFuzzerHarness {
    Vladimir Levin . resolved

    Is it possible for this fuzzer to span several files? Not sure of any precedents

    ᄋᄋ

    There is precedent (ad_auction_service_mojolpm_fuzzer compiles a stringifiers .cc/.h in the same target; content/test/fuzzer shares mojolpm support source_sets). This file is ~400 LOC and self-contained, so I kept it single-file for now -- happy to split if you'd prefer.

    Line 330, Patchset 1: (void)support->MaybeSubmitCompositorFrame(
    Vladimir Levin . resolved

    std::ignore = ...

    ᄋᄋ

    Done -- `std::ignore = support->MaybeSubmitCompositorFrame(...)` (added #include <tuple>).

    Line 339, Patchset 1: (void)support->DidNotProduceFrame(ack);
    Vladimir Levin . resolved

    same

    ᄋᄋ

    Done -- `std::ignore = support->DidNotProduceFrame(ack)` as above.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Saifuddin Hitawala
    • Vladimir Levin
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ie1755ebae6ad4aaa2d8f62425b3e5c97d23b6e30
      Gerrit-Change-Number: 7977564
      Gerrit-PatchSet: 1
      Gerrit-Owner: ᄋᄋ <tjdd...@gmail.com>
      Gerrit-Reviewer: Giovanni Ortuno Urquidi <ort...@chromium.org>
      Gerrit-Reviewer: Saifuddin Hitawala <hita...@chromium.org>
      Gerrit-Reviewer: Vladimir Levin <vmp...@chromium.org>
      Gerrit-Attention: Vladimir Levin <vmp...@chromium.org>
      Gerrit-Comment-Date: Mon, 22 Jun 2026 17:24:32 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Vladimir Levin <vmp...@chromium.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      ᄋᄋ (Gerrit)

      unread,
      Jun 22, 2026, 1:25:16 PMJun 22
      to Chromium LUCI CQ, Giovanni Ortuno Urquidi, Vladimir Levin, Saifuddin Hitawala, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, droger+w...@chromium.org, cc-...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org, ortuno...@chromium.org, titoua...@chromium.org
      Attention needed from Saifuddin Hitawala and Vladimir Levin

      Message from ᄋᄋ

      Thanks for the careful review, Vladimir -- all seven addressed in PS2.

      • Removed every file:line citation from the comments (.cc and .proto).
      • L148: now a direct `return u->mutable_new_();` -- mutable_new_() already set the union to kNew, so the prior code returned the same pointer; just made it explicit.
      • L186: documented why no separate shared_quad_state_list clamp is needed (traits rebuild it at most one-per-quad, so the quad clamp bounds it).
      • L226: dropped AsFreshOrNull for the top-level frame -- ShapeCompositorFrame now always builds a fresh frame from the input. Verified the seed still drives a real SubmitCompositorFrame.
      • L243: noted in-tree precedent for multi-file mojolpm fuzzers; kept this one single-file for now (happy to split).
      • L330/L339: std::ignore = ... (added #include <tuple>).

      PTAL.

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Saifuddin Hitawala
      • Vladimir Levin
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ie1755ebae6ad4aaa2d8f62425b3e5c97d23b6e30
      Gerrit-Change-Number: 7977564
      Gerrit-PatchSet: 2
      Gerrit-Owner: ᄋᄋ <tjdd...@gmail.com>
      Gerrit-Reviewer: Giovanni Ortuno Urquidi <ort...@chromium.org>
      Gerrit-Reviewer: Saifuddin Hitawala <hita...@chromium.org>
      Gerrit-Reviewer: Vladimir Levin <vmp...@chromium.org>
      Gerrit-Attention: Saifuddin Hitawala <hita...@chromium.org>
      Gerrit-Attention: Vladimir Levin <vmp...@chromium.org>
      Gerrit-Comment-Date: Mon, 22 Jun 2026 17:24:48 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: No
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Vladimir Levin (Gerrit)

      unread,
      Jun 22, 2026, 4:22:10 PMJun 22
      to ᄋᄋ, Chromium LUCI CQ, Giovanni Ortuno Urquidi, Saifuddin Hitawala, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, droger+w...@chromium.org, cc-...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org, ortuno...@chromium.org, titoua...@chromium.org
      Attention needed from Saifuddin Hitawala and ᄋᄋ

      Vladimir Levin voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Saifuddin Hitawala
      • ᄋᄋ
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ie1755ebae6ad4aaa2d8f62425b3e5c97d23b6e30
      Gerrit-Change-Number: 7977564
      Gerrit-PatchSet: 2
      Gerrit-Owner: ᄋᄋ <tjdd...@gmail.com>
      Gerrit-Reviewer: Giovanni Ortuno Urquidi <ort...@chromium.org>
      Gerrit-Reviewer: Saifuddin Hitawala <hita...@chromium.org>
      Gerrit-Reviewer: Vladimir Levin <vmp...@chromium.org>
      Gerrit-Attention: Saifuddin Hitawala <hita...@chromium.org>
      Gerrit-Attention: ᄋᄋ <tjdd...@gmail.com>
      Gerrit-Comment-Date: Mon, 22 Jun 2026 20:21:41 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      ᄋᄋ (Gerrit)

      unread,
      Jun 23, 2026, 12:22:21 AMJun 23
      to Vladimir Levin, Chromium LUCI CQ, Giovanni Ortuno Urquidi, Saifuddin Hitawala, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, droger+w...@chromium.org, cc-...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org, ortuno...@chromium.org, titoua...@chromium.org
      Attention needed from Saifuddin Hitawala and Vladimir Levin

      Message from ᄋᄋ

      PS3: comment-only cleanup. Removed an accessor-verification banner and a couple of stale section dividers and tightened the wording; no code change. Sorry for bumping the +1, PTAL.

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Saifuddin Hitawala
      • Vladimir Levin
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ie1755ebae6ad4aaa2d8f62425b3e5c97d23b6e30
      Gerrit-Change-Number: 7977564
      Gerrit-PatchSet: 3
      Gerrit-Owner: ᄋᄋ <tjdd...@gmail.com>
      Gerrit-Reviewer: Giovanni Ortuno Urquidi <ort...@chromium.org>
      Gerrit-Reviewer: Saifuddin Hitawala <hita...@chromium.org>
      Gerrit-Reviewer: Vladimir Levin <vmp...@chromium.org>
      Gerrit-Attention: Saifuddin Hitawala <hita...@chromium.org>
      Gerrit-Attention: Vladimir Levin <vmp...@chromium.org>
      Gerrit-Comment-Date: Tue, 23 Jun 2026 04:21:58 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: No
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Vladimir Levin (Gerrit)

      unread,
      Jun 23, 2026, 9:38:38 AMJun 23
      to ᄋᄋ, Chromium LUCI CQ, Giovanni Ortuno Urquidi, Saifuddin Hitawala, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, droger+w...@chromium.org, cc-...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org, ortuno...@chromium.org, titoua...@chromium.org
      Attention needed from Saifuddin Hitawala and ᄋᄋ

      Vladimir Levin voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Saifuddin Hitawala
      • ᄋᄋ
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ie1755ebae6ad4aaa2d8f62425b3e5c97d23b6e30
      Gerrit-Change-Number: 7977564
      Gerrit-PatchSet: 4
      Gerrit-Owner: ᄋᄋ <tjdd...@gmail.com>
      Gerrit-Reviewer: Giovanni Ortuno Urquidi <ort...@chromium.org>
      Gerrit-Reviewer: Saifuddin Hitawala <hita...@chromium.org>
      Gerrit-Reviewer: Vladimir Levin <vmp...@chromium.org>
      Gerrit-Attention: Saifuddin Hitawala <hita...@chromium.org>
      Gerrit-Attention: ᄋᄋ <tjdd...@gmail.com>
      Gerrit-Comment-Date: Tue, 23 Jun 2026 13:38:19 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      ᄋᄋ (Gerrit)

      unread,
      Jun 23, 2026, 2:57:28 PMJun 23
      to Vladimir Levin, Chromium LUCI CQ, Giovanni Ortuno Urquidi, Saifuddin Hitawala, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, droger+w...@chromium.org, cc-...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org, ortuno...@chromium.org, titoua...@chromium.org
      Attention needed from Saifuddin Hitawala

      Message from ᄋᄋ

      Thanks Vladimir. This is approved and sits on top of the gpu CL 7976442 in the chain, so it's ready to land once that one goes in.

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Saifuddin Hitawala
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ie1755ebae6ad4aaa2d8f62425b3e5c97d23b6e30
      Gerrit-Change-Number: 7977564
      Gerrit-PatchSet: 5
      Gerrit-Owner: ᄋᄋ <tjdd...@gmail.com>
      Gerrit-Reviewer: Giovanni Ortuno Urquidi <ort...@chromium.org>
      Gerrit-Reviewer: Saifuddin Hitawala <hita...@chromium.org>
      Gerrit-Reviewer: Vladimir Levin <vmp...@chromium.org>
      Gerrit-Attention: Saifuddin Hitawala <hita...@chromium.org>
      Gerrit-Comment-Date: Tue, 23 Jun 2026 18:56:54 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: No
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      ᄋᄋ (Gerrit)

      unread,
      Jun 24, 2026, 4:04:46 AMJun 24
      to Vladimir Levin, Chromium LUCI CQ, Giovanni Ortuno Urquidi, Saifuddin Hitawala, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, droger+w...@chromium.org, cc-...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org, ortuno...@chromium.org, titoua...@chromium.org
      Attention needed from Saifuddin Hitawala and Vladimir Levin

      Message from ᄋᄋ

      Small cleanup to match the rest of the chain: removed InitGoogleTest and switched the static environment to base::NoDestructor. No functional change, sorry for clearing the +1. PTAL.

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Saifuddin Hitawala
      • Vladimir Levin
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ie1755ebae6ad4aaa2d8f62425b3e5c97d23b6e30
      Gerrit-Change-Number: 7977564
      Gerrit-PatchSet: 6
      Gerrit-Owner: ᄋᄋ <tjdd...@gmail.com>
      Gerrit-Reviewer: Giovanni Ortuno Urquidi <ort...@chromium.org>
      Gerrit-Reviewer: Saifuddin Hitawala <hita...@chromium.org>
      Gerrit-Reviewer: Vladimir Levin <vmp...@chromium.org>
      Gerrit-Attention: Saifuddin Hitawala <hita...@chromium.org>
      Gerrit-Attention: Vladimir Levin <vmp...@chromium.org>
      Gerrit-Comment-Date: Wed, 24 Jun 2026 08:04:18 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: No
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Vladimir Levin (Gerrit)

      unread,
      Jun 24, 2026, 4:42:51 PM (14 days ago) Jun 24
      to ᄋᄋ, Chromium LUCI CQ, Giovanni Ortuno Urquidi, Saifuddin Hitawala, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, droger+w...@chromium.org, cc-...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org, ortuno...@chromium.org, titoua...@chromium.org
      Attention needed from Saifuddin Hitawala and ᄋᄋ

      Vladimir Levin voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Saifuddin Hitawala
      • ᄋᄋ
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ie1755ebae6ad4aaa2d8f62425b3e5c97d23b6e30
      Gerrit-Change-Number: 7977564
      Gerrit-PatchSet: 9
      Gerrit-Owner: ᄋᄋ <tjdd...@gmail.com>
      Gerrit-Reviewer: Giovanni Ortuno Urquidi <ort...@chromium.org>
      Gerrit-Reviewer: Saifuddin Hitawala <hita...@chromium.org>
      Gerrit-Reviewer: Vladimir Levin <vmp...@chromium.org>
      Gerrit-Attention: Saifuddin Hitawala <hita...@chromium.org>
      Gerrit-Attention: ᄋᄋ <tjdd...@gmail.com>
      Gerrit-Comment-Date: Wed, 24 Jun 2026 20:42:31 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Saifuddin Hitawala (Gerrit)

      unread,
      Jun 29, 2026, 10:53:25 AM (9 days ago) Jun 29
      to ᄋᄋ, Vladimir Levin, Chromium LUCI CQ, Giovanni Ortuno Urquidi, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, droger+w...@chromium.org, cc-...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org, ortuno...@chromium.org, titoua...@chromium.org
      Attention needed from ᄋᄋ

      Saifuddin Hitawala voted and added 1 comment

      Votes added by Saifuddin Hitawala

      Code-Review+1

      1 comment

      Patchset-level comments
      File-level comment, Patchset 10 (Latest):
      Saifuddin Hitawala . resolved

      LGTM as well, thanks for working on it!

      Open in Gerrit

      Related details

      Attention is currently required from:
      • ᄋᄋ
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Ie1755ebae6ad4aaa2d8f62425b3e5c97d23b6e30
        Gerrit-Change-Number: 7977564
        Gerrit-PatchSet: 10
        Gerrit-Owner: ᄋᄋ <tjdd...@gmail.com>
        Gerrit-Reviewer: Giovanni Ortuno Urquidi <ort...@chromium.org>
        Gerrit-Reviewer: Saifuddin Hitawala <hita...@chromium.org>
        Gerrit-Reviewer: Vladimir Levin <vmp...@chromium.org>
        Gerrit-Attention: ᄋᄋ <tjdd...@gmail.com>
        Gerrit-Comment-Date: Mon, 29 Jun 2026 14:53:18 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        open
        diffy

        ᄋᄋ (Gerrit)

        unread,
        Jun 30, 2026, 5:58:03 PM (8 days ago) Jun 30
        to Saifuddin Hitawala, Vladimir Levin, Chromium LUCI CQ, Giovanni Ortuno Urquidi, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, droger+w...@chromium.org, cc-...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org, ortuno...@chromium.org, titoua...@chromium.org

        ᄋᄋ voted Commit-Queue+2

        Commit-Queue+2
        Open in Gerrit

        Related details

        Attention set is empty
        Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Ie1755ebae6ad4aaa2d8f62425b3e5c97d23b6e30
        Gerrit-Change-Number: 7977564
        Gerrit-PatchSet: 10
        Gerrit-Owner: ᄋᄋ <tjdd...@gmail.com>
        Gerrit-Reviewer: Giovanni Ortuno Urquidi <ort...@chromium.org>
        Gerrit-Reviewer: Saifuddin Hitawala <hita...@chromium.org>
        Gerrit-Reviewer: Vladimir Levin <vmp...@chromium.org>
        Gerrit-Reviewer: ᄋᄋ <tjdd...@gmail.com>
        Gerrit-Comment-Date: Tue, 30 Jun 2026 21:57:26 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        open
        diffy

        ᄋᄋ (Gerrit)

        unread,
        Jun 30, 2026, 5:58:40 PM (8 days ago) Jun 30
        to Saifuddin Hitawala, Vladimir Levin, Chromium LUCI CQ, Giovanni Ortuno Urquidi, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, droger+w...@chromium.org, cc-...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org, ortuno...@chromium.org, titoua...@chromium.org
        Gerrit-Comment-Date: Tue, 30 Jun 2026 21:58:11 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        open
        diffy

        ᄋᄋ (Gerrit)

        unread,
        Jun 30, 2026, 6:06:10 PM (8 days ago) Jun 30
        to Saifuddin Hitawala, Vladimir Levin, Chromium LUCI CQ, Giovanni Ortuno Urquidi, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, droger+w...@chromium.org, cc-...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org, ortuno...@chromium.org, titoua...@chromium.org
        Gerrit-Comment-Date: Tue, 30 Jun 2026 22:05:40 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        open
        diffy

        ᄋᄋ (Gerrit)

        unread,
        Jul 7, 2026, 10:46:45 PM (12 hours ago) Jul 7
        to Saifuddin Hitawala, Vladimir Levin, Chromium LUCI CQ, Giovanni Ortuno Urquidi, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, droger+w...@chromium.org, cc-...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org, ortuno...@chromium.org, titoua...@chromium.org

        Message from ᄋᄋ

        All threads resolved, Code-Review+1 from Vladimir Levin and Saifuddin Hitawala. This CL is submittable. As a first-time contributor I cannot set Commit-Queue myself — could a committer please trigger CQ? This is the top of a chain: viz → media → network, all three approved.

        Open in Gerrit

        Related details

        Attention set is empty
        Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Ie1755ebae6ad4aaa2d8f62425b3e5c97d23b6e30
        Gerrit-Change-Number: 7977564
        Gerrit-PatchSet: 10
        Gerrit-Owner: ᄋᄋ <tjdd...@gmail.com>
        Gerrit-Reviewer: Giovanni Ortuno Urquidi <ort...@chromium.org>
        Gerrit-Reviewer: Saifuddin Hitawala <hita...@chromium.org>
        Gerrit-Reviewer: Vladimir Levin <vmp...@chromium.org>
        Gerrit-Reviewer: ᄋᄋ <tjdd...@gmail.com>
        Gerrit-Comment-Date: Wed, 08 Jul 2026 02:46:16 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: No
        satisfied_requirement
        open
        diffy

        ᄋᄋ (Gerrit)

        unread,
        Jul 7, 2026, 10:46:47 PM (12 hours ago) Jul 7
        to Saifuddin Hitawala, Vladimir Levin, Chromium LUCI CQ, Giovanni Ortuno Urquidi, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, droger+w...@chromium.org, cc-...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org, ortuno...@chromium.org, titoua...@chromium.org

        ᄋᄋ voted Commit-Queue+2

        Commit-Queue+2
        Open in Gerrit

        Related details

        Attention set is empty
        Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Ie1755ebae6ad4aaa2d8f62425b3e5c97d23b6e30
        Gerrit-Change-Number: 7977564
        Gerrit-PatchSet: 10
        Gerrit-Owner: ᄋᄋ <tjdd...@gmail.com>
        Gerrit-Reviewer: Giovanni Ortuno Urquidi <ort...@chromium.org>
        Gerrit-Reviewer: Saifuddin Hitawala <hita...@chromium.org>
        Gerrit-Reviewer: Vladimir Levin <vmp...@chromium.org>
        Gerrit-Reviewer: ᄋᄋ <tjdd...@gmail.com>
        Gerrit-Comment-Date: Wed, 08 Jul 2026 02:46:23 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        open
        diffy

        Saifuddin Hitawala (Gerrit)

        unread,
        9:40 AM (1 hour ago) 9:40 AM
        to ᄋᄋ, Vladimir Levin, Chromium LUCI CQ, Giovanni Ortuno Urquidi, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, droger+w...@chromium.org, cc-...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org, ortuno...@chromium.org, titoua...@chromium.org
        Attention needed from ᄋᄋ

        Saifuddin Hitawala voted Commit-Queue+2

        Commit-Queue+2
        Open in Gerrit

        Related details

        Attention is currently required from:
        • ᄋᄋ
        Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Ie1755ebae6ad4aaa2d8f62425b3e5c97d23b6e30
        Gerrit-Change-Number: 7977564
        Gerrit-PatchSet: 10
        Gerrit-Owner: ᄋᄋ <tjdd...@gmail.com>
        Gerrit-Reviewer: Giovanni Ortuno Urquidi <ort...@chromium.org>
        Gerrit-Reviewer: Saifuddin Hitawala <hita...@chromium.org>
        Gerrit-Reviewer: Vladimir Levin <vmp...@chromium.org>
        Gerrit-Reviewer: ᄋᄋ <tjdd...@gmail.com>
        Gerrit-Attention: ᄋᄋ <tjdd...@gmail.com>
        Gerrit-Comment-Date: Wed, 08 Jul 2026 13:40:01 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        open
        diffy
        Reply all
        Reply to author
        Forward
        0 new messages