Revive Lock Screen timeout&success metrics [chromium/src : main]
Maksim Ivanov (Gerrit)
Attention is currently required from: Denis Kuznetsov, Zentaro Kavanagh.
Patch set 1:Commit-Queue +1
To view, visit change 3739510. To unsubscribe, or for help writing mail filters, visit settings.
Denis Kuznetsov (Gerrit)
Attention is currently required from: Maksim Ivanov, Zentaro Kavanagh.
Patch set 1:Code-Review +1
Maksim Ivanov (Gerrit)
Attention is currently required from: Zentaro Kavanagh.
1 comment:
Patchset:
zentaro@: Friendly ping. Thanks.
To view, visit change 3739510. To unsubscribe, or for help writing mail filters, visit settings.
Maksim Ivanov (Gerrit)
Attention is currently required from: Tony Yeoman, Zentaro Kavanagh.
1 comment:
Patchset:
Adding tby@ as zentaro@ is OOO. PTAL; thanks!
To view, visit change 3739510. To unsubscribe, or for help writing mail filters, visit settings.
Tony Yeoman (Gerrit)
Attention is currently required from: Maksim Ivanov.
2 comments:
File tools/metrics/histograms/metadata/ash/histograms.xml:
Patch Set #1, Line 4973:
2023-01-01Maybe move these both to 2023-02-01. Best to avoid things expiring over the holiday period :)
Patch Set #1, Line 4977:
How long it took for the screen lock process to complete. This does notSince these histograms have been expired for a while, a disclaimer should be added to their summary mentioning the period they were unavailable for.
'''
If a histogram expired more than a month ago (for histograms with an expiration date) or more than one milestone ago (for histograms with expiration milestones; this means top-of-tree is two or more milestones away from expired milestone), then you may be outside the safety window. In this case, when extending the histogram add to the histogram description a message: “Warning: this histogram was expired from DATE to DATE; data may be missing.” (For milestones, write something similar.)
''''https://chromium.googlesource.com/chromium/src/tools/+/HEAD/metrics/histograms/README.md#extending
To view, visit change 3739510. To unsubscribe, or for help writing mail filters, visit settings.
Maksim Ivanov (Gerrit)
Attention is currently required from: Tony Yeoman.
2 comments:
File tools/metrics/histograms/metadata/ash/histograms.xml:
Patch Set #1, Line 4973:
2023-01-01
Maybe move these both to 2023-02-01. […]
Done, good point!
Patch Set #1, Line 4977:
How long it took for the screen lock process to complete. This does not
Since these histograms have been expired for a while, a disclaimer should be added to their summary […]
Done, thanks for pointing this out.
To view, visit change 3739510. To unsubscribe, or for help writing mail filters, visit settings.
Tony Yeoman (Gerrit)
Attention is currently required from: Maksim Ivanov.
Patch set 3:Code-Review +1
1 comment:
Patchset:
LGTM, thanks Maksim :)
To view, visit change 3739510. To unsubscribe, or for help writing mail filters, visit settings.
Maksim Ivanov (Gerrit)
Attention is currently required from: Maksim Ivanov.
Patch set 3:Commit-Queue +2
Chromium LUCI CQ (Gerrit)
Chromium LUCI CQ submitted this change.
Revive Lock Screen timeout&success metrics
Make the previously expired metrics "Ash.WindowManager.Lock.Success" and
"Ash.WindowManager.Lock.Timeout" active again, as they help
investigating the root cause of a slow/hung lock screen appearance.
Also replace the engineer who's left the team with the responsible team
in the "owner" field.
Bug: b:228873153
Change-Id: I31acc4eabfc11df19f329827cb24dcfc95e87d93
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3739510
Reviewed-by: Denis Kuznetsov <ant...@chromium.org>
Reviewed-by: Tony Yeoman <t...@chromium.org>
Commit-Queue: Maksim Ivanov <em...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1023549}
---
M tools/metrics/histograms/metadata/ash/histograms.xml
1 file changed, 32 insertions(+), 5 deletions(-)
diff --git a/tools/metrics/histograms/metadata/ash/histograms.xml b/tools/metrics/histograms/metadata/ash/histograms.xml
index 94a9f6f..be6b608 100644
--- a/tools/metrics/histograms/metadata/ash/histograms.xml
+++ b/tools/metrics/histograms/metadata/ash/histograms.xml
@@ -4970,18 +4970,23 @@
</summary>
</histogram>
-<histogram name="Ash.WindowManager.Lock.Success" units="ms" expires_after="M77">
- <owner>jduf...@chromium.org</owner>
+<histogram name="Ash.WindowManager.Lock.Success" units="ms"
+ expires_after="2023-02-01">
+ <owner>ant...@chromium.org</owner>
+ <owner>cros...@google.com</owner>
<summary>
How long it took for the screen lock process to complete. This does not
- include timeouts.
+ include timeouts. Warning: this histogram was expired from M78 till M104.
</summary>
</histogram>
-<histogram name="Ash.WindowManager.Lock.Timeout" units="ms" expires_after="M77">
- <owner>jduf...@chromium.org</owner>
+<histogram name="Ash.WindowManager.Lock.Timeout" units="ms"
+ expires_after="2023-02-01">
+ <owner>ant...@chromium.org</owner>
+ <owner>cros...@google.com</owner>
<summary>
How long it took for the screen lock process to complete, for timeouts only.
+ Warning: this histogram was expired from M78 till M104.
</summary>
</histogram>
To view, visit change 3739510. To unsubscribe, or for help writing mail filters, visit settings.