Revive Lock Screen timeout&success metrics [chromium/src : main]

0 views
Skip to first unread message

Maksim Ivanov (Gerrit)

unread,
Jul 2, 2022, 6:17:16 AMJul 2
to asvitkine...@chromium.org, Zentaro Kavanagh, Denis Kuznetsov, Chromium Metrics Reviews, chromium...@chromium.org, Sadrul Chowdhury

Attention is currently required from: Denis Kuznetsov, Zentaro Kavanagh.

Patch set 1:Commit-Queue +1

View Change

    To view, visit change 3739510. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I31acc4eabfc11df19f329827cb24dcfc95e87d93
    Gerrit-Change-Number: 3739510
    Gerrit-PatchSet: 1
    Gerrit-Owner: Maksim Ivanov <em...@chromium.org>
    Gerrit-Reviewer: Denis Kuznetsov <ant...@chromium.org>
    Gerrit-Reviewer: Maksim Ivanov <em...@chromium.org>
    Gerrit-Reviewer: Zentaro Kavanagh <zen...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
    Gerrit-Attention: Denis Kuznetsov <ant...@chromium.org>
    Gerrit-Attention: Zentaro Kavanagh <zen...@chromium.org>
    Gerrit-Comment-Date: Sat, 02 Jul 2022 10:17:05 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    Gerrit-MessageType: comment

    Denis Kuznetsov (Gerrit)

    unread,
    Jul 4, 2022, 10:26:34 AMJul 4
    to Maksim Ivanov, asvitkine...@chromium.org, Chromium LUCI CQ, Zentaro Kavanagh, Chromium Metrics Reviews, chromium...@chromium.org, Sadrul Chowdhury

    Attention is currently required from: Maksim Ivanov, Zentaro Kavanagh.

    Patch set 1:Code-Review +1

    View Change

      To view, visit change 3739510. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I31acc4eabfc11df19f329827cb24dcfc95e87d93
      Gerrit-Change-Number: 3739510
      Gerrit-PatchSet: 1
      Gerrit-Owner: Maksim Ivanov <em...@chromium.org>
      Gerrit-Reviewer: Denis Kuznetsov <ant...@chromium.org>
      Gerrit-Reviewer: Maksim Ivanov <em...@chromium.org>
      Gerrit-Reviewer: Zentaro Kavanagh <zen...@chromium.org>
      Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
      Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
      Gerrit-Attention: Maksim Ivanov <em...@chromium.org>
      Gerrit-Attention: Zentaro Kavanagh <zen...@chromium.org>
      Gerrit-Comment-Date: Mon, 04 Jul 2022 14:26:26 +0000

      Maksim Ivanov (Gerrit)

      unread,
      Jul 6, 2022, 8:43:14 PMJul 6
      to asvitkine...@chromium.org, Denis Kuznetsov, Chromium LUCI CQ, Zentaro Kavanagh, Chromium Metrics Reviews, chromium...@chromium.org, Sadrul Chowdhury

      Attention is currently required from: Zentaro Kavanagh.

      View Change

      1 comment:

      To view, visit change 3739510. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I31acc4eabfc11df19f329827cb24dcfc95e87d93
      Gerrit-Change-Number: 3739510
      Gerrit-PatchSet: 1
      Gerrit-Owner: Maksim Ivanov <em...@chromium.org>
      Gerrit-Reviewer: Denis Kuznetsov <ant...@chromium.org>
      Gerrit-Reviewer: Maksim Ivanov <em...@chromium.org>
      Gerrit-Reviewer: Zentaro Kavanagh <zen...@chromium.org>
      Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
      Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
      Gerrit-Attention: Zentaro Kavanagh <zen...@chromium.org>
      Gerrit-Comment-Date: Thu, 07 Jul 2022 00:43:05 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Gerrit-MessageType: comment

      Maksim Ivanov (Gerrit)

      unread,
      Jul 11, 2022, 10:17:12 AMJul 11
      to asvitkine...@chromium.org, Tony Yeoman, Zentaro Kavanagh, Denis Kuznetsov, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Sadrul Chowdhury

      Attention is currently required from: Tony Yeoman, Zentaro Kavanagh.

      View Change

      1 comment:

      • Patchset:

      To view, visit change 3739510. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I31acc4eabfc11df19f329827cb24dcfc95e87d93
      Gerrit-Change-Number: 3739510
      Gerrit-PatchSet: 1
      Gerrit-Owner: Maksim Ivanov <em...@chromium.org>
      Gerrit-Reviewer: Denis Kuznetsov <ant...@chromium.org>
      Gerrit-Reviewer: Maksim Ivanov <em...@chromium.org>
      Gerrit-Reviewer: Tony Yeoman <t...@chromium.org>
      Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
      Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
      Gerrit-CC: Zentaro Kavanagh <zen...@chromium.org>
      Gerrit-Attention: Tony Yeoman <t...@chromium.org>
      Gerrit-Attention: Zentaro Kavanagh <zen...@chromium.org>
      Gerrit-Comment-Date: Mon, 11 Jul 2022 14:17:00 +0000

      Tony Yeoman (Gerrit)

      unread,
      Jul 12, 2022, 7:10:45 PMJul 12
      to Maksim Ivanov, asvitkine...@chromium.org, Zentaro Kavanagh, Denis Kuznetsov, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Sadrul Chowdhury

      Attention is currently required from: Maksim Ivanov.

      View Change

      2 comments:

      • File tools/metrics/histograms/metadata/ash/histograms.xml:

        • Patch Set #1, Line 4973: 2023-01-01

          Maybe move these both to 2023-02-01. Best to avoid things expiring over the holiday period :)

        • Patch Set #1, Line 4977: How long it took for the screen lock process to complete. This does not

          Since these histograms have been expired for a while, a disclaimer should be added to their summary mentioning the period they were unavailable for.

          '''
          If a histogram expired more than a month ago (for histograms with an expiration date) or more than one milestone ago (for histograms with expiration milestones; this means top-of-tree is two or more milestones away from expired milestone), then you may be outside the safety window. In this case, when extending the histogram add to the histogram description a message: “Warning: this histogram was expired from DATE to DATE; data may be missing.” (For milestones, write something similar.)
          ''''

          https://chromium.googlesource.com/chromium/src/tools/+/HEAD/metrics/histograms/README.md#extending

      To view, visit change 3739510. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I31acc4eabfc11df19f329827cb24dcfc95e87d93
      Gerrit-Change-Number: 3739510
      Gerrit-PatchSet: 1
      Gerrit-Owner: Maksim Ivanov <em...@chromium.org>
      Gerrit-Reviewer: Denis Kuznetsov <ant...@chromium.org>
      Gerrit-Reviewer: Maksim Ivanov <em...@chromium.org>
      Gerrit-Reviewer: Tony Yeoman <t...@chromium.org>
      Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
      Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
      Gerrit-CC: Zentaro Kavanagh <zen...@chromium.org>
      Gerrit-Attention: Maksim Ivanov <em...@chromium.org>
      Gerrit-Comment-Date: Tue, 12 Jul 2022 23:10:30 +0000

      Maksim Ivanov (Gerrit)

      unread,
      Jul 12, 2022, 7:56:51 PMJul 12
      to asvitkine...@chromium.org, Tony Yeoman, Zentaro Kavanagh, Denis Kuznetsov, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Sadrul Chowdhury

      Attention is currently required from: Tony Yeoman.

      View Change

      2 comments:

      • File tools/metrics/histograms/metadata/ash/histograms.xml:

        • Maybe move these both to 2023-02-01. […]

          Done, good point!

        • Since these histograms have been expired for a while, a disclaimer should be added to their summary […]

          Done, thanks for pointing this out.

      To view, visit change 3739510. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I31acc4eabfc11df19f329827cb24dcfc95e87d93
      Gerrit-Change-Number: 3739510
      Gerrit-PatchSet: 3
      Gerrit-Owner: Maksim Ivanov <em...@chromium.org>
      Gerrit-Reviewer: Denis Kuznetsov <ant...@chromium.org>
      Gerrit-Reviewer: Maksim Ivanov <em...@chromium.org>
      Gerrit-Reviewer: Tony Yeoman <t...@chromium.org>
      Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
      Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
      Gerrit-CC: Zentaro Kavanagh <zen...@chromium.org>
      Gerrit-Attention: Tony Yeoman <t...@chromium.org>
      Gerrit-Comment-Date: Tue, 12 Jul 2022 23:56:38 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Tony Yeoman <t...@chromium.org>
      Gerrit-MessageType: comment

      Tony Yeoman (Gerrit)

      unread,
      Jul 12, 2022, 8:01:54 PMJul 12
      to Maksim Ivanov, asvitkine...@chromium.org, Zentaro Kavanagh, Denis Kuznetsov, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Sadrul Chowdhury

      Attention is currently required from: Maksim Ivanov.

      Patch set 3:Code-Review +1

      View Change

      1 comment:

      To view, visit change 3739510. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I31acc4eabfc11df19f329827cb24dcfc95e87d93
      Gerrit-Change-Number: 3739510
      Gerrit-PatchSet: 3
      Gerrit-Owner: Maksim Ivanov <em...@chromium.org>
      Gerrit-Reviewer: Denis Kuznetsov <ant...@chromium.org>
      Gerrit-Reviewer: Maksim Ivanov <em...@chromium.org>
      Gerrit-Reviewer: Tony Yeoman <t...@chromium.org>
      Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
      Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
      Gerrit-CC: Zentaro Kavanagh <zen...@chromium.org>
      Gerrit-Attention: Maksim Ivanov <em...@chromium.org>
      Gerrit-Comment-Date: Wed, 13 Jul 2022 00:01:40 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      Gerrit-MessageType: comment

      Maksim Ivanov (Gerrit)

      unread,
      Jul 12, 2022, 8:02:28 PMJul 12
      to asvitkine...@chromium.org, Tony Yeoman, Zentaro Kavanagh, Denis Kuznetsov, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Sadrul Chowdhury

      Attention is currently required from: Maksim Ivanov.

      Patch set 3:Commit-Queue +2

      View Change

        To view, visit change 3739510. To unsubscribe, or for help writing mail filters, visit settings.

        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I31acc4eabfc11df19f329827cb24dcfc95e87d93
        Gerrit-Change-Number: 3739510
        Gerrit-PatchSet: 3
        Gerrit-Owner: Maksim Ivanov <em...@chromium.org>
        Gerrit-Reviewer: Denis Kuznetsov <ant...@chromium.org>
        Gerrit-Reviewer: Maksim Ivanov <em...@chromium.org>
        Gerrit-Reviewer: Tony Yeoman <t...@chromium.org>
        Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
        Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
        Gerrit-CC: Zentaro Kavanagh <zen...@chromium.org>
        Gerrit-Attention: Maksim Ivanov <em...@chromium.org>
        Gerrit-Comment-Date: Wed, 13 Jul 2022 00:02:19 +0000

        Chromium LUCI CQ (Gerrit)

        unread,
        Jul 12, 2022, 10:27:48 PMJul 12
        to Maksim Ivanov, asvitkine...@chromium.org, Tony Yeoman, Zentaro Kavanagh, Denis Kuznetsov, Chromium Metrics Reviews, chromium...@chromium.org, Sadrul Chowdhury

        Chromium LUCI CQ submitted this change.

        View Change


        Approvals: Maksim Ivanov: Commit Denis Kuznetsov: Looks good to me Tony Yeoman: Looks good to me
        Revive Lock Screen timeout&success metrics

        Make the previously expired metrics "Ash.WindowManager.Lock.Success" and
        "Ash.WindowManager.Lock.Timeout" active again, as they help
        investigating the root cause of a slow/hung lock screen appearance.

        Also replace the engineer who's left the team with the responsible team
        in the "owner" field.

        Bug: b:228873153
        Change-Id: I31acc4eabfc11df19f329827cb24dcfc95e87d93
        Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3739510
        Reviewed-by: Denis Kuznetsov <ant...@chromium.org>
        Reviewed-by: Tony Yeoman <t...@chromium.org>
        Commit-Queue: Maksim Ivanov <em...@chromium.org>
        Cr-Commit-Position: refs/heads/main@{#1023549}
        ---
        M tools/metrics/histograms/metadata/ash/histograms.xml
        1 file changed, 32 insertions(+), 5 deletions(-)

        diff --git a/tools/metrics/histograms/metadata/ash/histograms.xml b/tools/metrics/histograms/metadata/ash/histograms.xml
        index 94a9f6f..be6b608 100644
        --- a/tools/metrics/histograms/metadata/ash/histograms.xml
        +++ b/tools/metrics/histograms/metadata/ash/histograms.xml
        @@ -4970,18 +4970,23 @@
        </summary>
        </histogram>

        -<histogram name="Ash.WindowManager.Lock.Success" units="ms" expires_after="M77">
        - <owner>jduf...@chromium.org</owner>
        +<histogram name="Ash.WindowManager.Lock.Success" units="ms"
        + expires_after="2023-02-01">
        + <owner>ant...@chromium.org</owner>
        + <owner>cros...@google.com</owner>
        <summary>

        How long it took for the screen lock process to complete. This does not
        -    include timeouts.
        + include timeouts. Warning: this histogram was expired from M78 till M104.
        </summary>
        </histogram>

        -<histogram name="Ash.WindowManager.Lock.Timeout" units="ms" expires_after="M77">
        - <owner>jduf...@chromium.org</owner>
        +<histogram name="Ash.WindowManager.Lock.Timeout" units="ms"
        + expires_after="2023-02-01">
        + <owner>ant...@chromium.org</owner>
        + <owner>cros...@google.com</owner>
        <summary>
        How long it took for the screen lock process to complete, for timeouts only.
        + Warning: this histogram was expired from M78 till M104.
        </summary>
        </histogram>


        To view, visit change 3739510. To unsubscribe, or for help writing mail filters, visit settings.

        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I31acc4eabfc11df19f329827cb24dcfc95e87d93
        Gerrit-Change-Number: 3739510
        Gerrit-PatchSet: 4
        Gerrit-Owner: Maksim Ivanov <em...@chromium.org>
        Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
        Gerrit-Reviewer: Denis Kuznetsov <ant...@chromium.org>
        Gerrit-Reviewer: Maksim Ivanov <em...@chromium.org>
        Gerrit-Reviewer: Tony Yeoman <t...@chromium.org>
        Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
        Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
        Gerrit-CC: Zentaro Kavanagh <zen...@chromium.org>
        Gerrit-MessageType: merged
        Reply all
        Reply to author
        Forward
        0 new messages