[ios] Implement execute for kManagePasswords NSUserActivity [chromium/src : main]

0 views
Skip to first unread message

Federica Germinario (Gerrit)

unread,
Apr 10, 2026, 4:48:24 AM (3 days ago) Apr 10
to Sylvain Defresne, Chromium LUCI CQ, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Sylvain Defresne

Federica Germinario voted and added 1 comment

Votes added by Federica Germinario

Auto-Submit+1

1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Federica Germinario . resolved

Hello, can you PTAL?

Open in Gerrit

Related details

Attention is currently required from:
  • Sylvain Defresne
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I8515f20e39aff3bfcc28948831bf02ad315304b6
Gerrit-Change-Number: 7743366
Gerrit-PatchSet: 3
Gerrit-Owner: Federica Germinario <fede...@google.com>
Gerrit-Reviewer: Federica Germinario <fede...@google.com>
Gerrit-Reviewer: Sylvain Defresne <sdef...@chromium.org>
Gerrit-Attention: Sylvain Defresne <sdef...@chromium.org>
Gerrit-Comment-Date: Fri, 10 Apr 2026 08:48:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Sylvain Defresne (Gerrit)

unread,
6:17 AM (2 hours ago) 6:17 AM
to Federica Germinario, Chromium LUCI CQ, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Federica Germinario

Sylvain Defresne voted and added 1 comment

Votes added by Sylvain Defresne

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 4 (Latest):
Sylvain Defresne . resolved

lgtm

Open in Gerrit

Related details

Attention is currently required from:
  • Federica Germinario
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I8515f20e39aff3bfcc28948831bf02ad315304b6
Gerrit-Change-Number: 7743366
Gerrit-PatchSet: 4
Gerrit-Owner: Federica Germinario <fede...@google.com>
Gerrit-Reviewer: Federica Germinario <fede...@google.com>
Gerrit-Reviewer: Sylvain Defresne <sdef...@chromium.org>
Gerrit-Attention: Federica Germinario <fede...@google.com>
Gerrit-Comment-Date: Mon, 13 Apr 2026 10:17:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Federica Germinario (Gerrit)

unread,
6:25 AM (2 hours ago) 6:25 AM
to Sylvain Defresne, Chromium LUCI CQ, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

Federica Germinario voted

Auto-Submit+1
Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I8515f20e39aff3bfcc28948831bf02ad315304b6
Gerrit-Change-Number: 7743366
Gerrit-PatchSet: 4
Gerrit-Owner: Federica Germinario <fede...@google.com>
Gerrit-Reviewer: Federica Germinario <fede...@google.com>
Gerrit-Reviewer: Sylvain Defresne <sdef...@chromium.org>
Gerrit-Comment-Date: Mon, 13 Apr 2026 10:24:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
7:22 AM (1 hour ago) 7:22 AM
to Federica Germinario, Sylvain Defresne, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
[ios] Implement execute for kManagePasswords NSUserActivity

Add implementation to handle opening manage passwords from Siri
Shortcuts in TaskRequestForUserActivity.

Tests will be added in a follow-up CL.
Bug: 492115056
Change-Id: I8515f20e39aff3bfcc28948831bf02ad315304b6
Reviewed-by: Sylvain Defresne <sdef...@chromium.org>
Commit-Queue: Federica Germinario <fede...@google.com>
Auto-Submit: Federica Germinario <fede...@google.com>
Cr-Commit-Position: refs/heads/main@{#1613621}
Files:
Change size: S
Delta: 1 file changed, 13 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Sylvain Defresne
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I8515f20e39aff3bfcc28948831bf02ad315304b6
Gerrit-Change-Number: 7743366
Gerrit-PatchSet: 5
Gerrit-Owner: Federica Germinario <fede...@google.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Federica Germinario <fede...@google.com>
Gerrit-Reviewer: Sylvain Defresne <sdef...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages