webnn: emulate rank-5 prelu's input tensors in TFLite [chromium/src : main]

0 views
Skip to first unread message

Dai, Feng (Gerrit)

unread,
Apr 16, 2026, 7:36:09 AMApr 16
to Reilly Grant, Hu, Ningxin, Dwayne Robinson, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Hu, Ningxin and Reilly Grant

Dai, Feng added 1 comment

Patchset-level comments
Open in Gerrit

Related details

Attention is currently required from:
  • Hu, Ningxin
  • Reilly Grant
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I69fe81b9055f6006e4b258a53d3fcd59d3052cae
Gerrit-Change-Number: 7768249
Gerrit-PatchSet: 3
Gerrit-Owner: Dai, Feng <feng...@intel.com>
Gerrit-Reviewer: Dai, Feng <feng...@intel.com>
Gerrit-Reviewer: Hu, Ningxin <ningx...@intel.com>
Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
Gerrit-CC: Dwayne Robinson <dwa...@microsoft.com>
Gerrit-Attention: Reilly Grant <rei...@chromium.org>
Gerrit-Attention: Hu, Ningxin <ningx...@intel.com>
Gerrit-Comment-Date: Thu, 16 Apr 2026 11:35:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Dwayne Robinson (Gerrit)

unread,
Apr 16, 2026, 1:27:07 PMApr 16
to Dai, Feng, Reilly Grant, Hu, Ningxin, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Dai, Feng, Hu, Ningxin and Reilly Grant

Dwayne Robinson added 3 comments

Patchset-level comments
Dwayne Robinson . resolved

Thanks Bruce.

File services/webnn/tflite/graph_builder_tflite.cc
Line 8112, Patchset 3 (Latest): if (input_tensor_info.dimensions.size() == 5 ||
Dwayne Robinson . unresolved

(minor) Consider `> 4` rather than specifically `== 5`, since that semantically reflects the limit of the underlying API (rank 4) allows code to be more generic (not that rank 6 will be hit anyway, since op support limits prevents it).

File third_party/blink/web_tests/external/wpt/webnn/conformance_tests/prelu.https.any.js
Line 513, Patchset 3 (Latest): },
Dwayne Robinson . unresolved

Since [prelu](https://webmachinelearning.github.io/webnn/#api-mlgraphbuilder-prelu) is bidirectionally broadcastable, consider also a 1D input and 5D slope.

Open in Gerrit

Related details

Attention is currently required from:
  • Dai, Feng
  • Hu, Ningxin
  • Reilly Grant
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I69fe81b9055f6006e4b258a53d3fcd59d3052cae
    Gerrit-Change-Number: 7768249
    Gerrit-PatchSet: 3
    Gerrit-Owner: Dai, Feng <feng...@intel.com>
    Gerrit-Reviewer: Dai, Feng <feng...@intel.com>
    Gerrit-Reviewer: Hu, Ningxin <ningx...@intel.com>
    Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
    Gerrit-CC: Dwayne Robinson <dwa...@microsoft.com>
    Gerrit-Attention: Reilly Grant <rei...@chromium.org>
    Gerrit-Attention: Hu, Ningxin <ningx...@intel.com>
    Gerrit-Attention: Dai, Feng <feng...@intel.com>
    Gerrit-Comment-Date: Thu, 16 Apr 2026 17:27:00 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Dai, Feng (Gerrit)

    unread,
    Apr 16, 2026, 10:40:07 PMApr 16
    to Reilly Grant, Hu, Ningxin, Dwayne Robinson, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
    Attention needed from Dwayne Robinson, Hu, Ningxin and Reilly Grant

    Dai, Feng added 2 comments

    File services/webnn/tflite/graph_builder_tflite.cc
    Line 8112, Patchset 3: if (input_tensor_info.dimensions.size() == 5 ||
    Dwayne Robinson . resolved

    (minor) Consider `> 4` rather than specifically `== 5`, since that semantically reflects the limit of the underlying API (rank 4) allows code to be more generic (not that rank 6 will be hit anyway, since op support limits prevents it).

    Dai, Feng

    👍
    Updated. Please take another look. Thanks!

    File third_party/blink/web_tests/external/wpt/webnn/conformance_tests/prelu.https.any.js
    Line 513, Patchset 3: },
    Dwayne Robinson . resolved

    Since [prelu](https://webmachinelearning.github.io/webnn/#api-mlgraphbuilder-prelu) is bidirectionally broadcastable, consider also a 1D input and 5D slope.

    Dai, Feng

    Thanks @dwa...@microsoft.com!
    I filed a separate issue https://issues.chromium.org/issues/503402055 to track it.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Dwayne Robinson
    • Hu, Ningxin
    • Reilly Grant
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I69fe81b9055f6006e4b258a53d3fcd59d3052cae
      Gerrit-Change-Number: 7768249
      Gerrit-PatchSet: 3
      Gerrit-Owner: Dai, Feng <feng...@intel.com>
      Gerrit-Reviewer: Dai, Feng <feng...@intel.com>
      Gerrit-Reviewer: Hu, Ningxin <ningx...@intel.com>
      Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
      Gerrit-CC: Dwayne Robinson <dwa...@microsoft.com>
      Gerrit-Attention: Reilly Grant <rei...@chromium.org>
      Gerrit-Attention: Hu, Ningxin <ningx...@intel.com>
      Gerrit-Attention: Dwayne Robinson <dwa...@microsoft.com>
      Gerrit-Comment-Date: Fri, 17 Apr 2026 02:39:45 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Dwayne Robinson <dwa...@microsoft.com>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Dwayne Robinson (Gerrit)

      unread,
      Apr 16, 2026, 10:58:29 PMApr 16
      to Dai, Feng, Reilly Grant, Hu, Ningxin, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
      Attention needed from Dai, Feng, Hu, Ningxin and Reilly Grant

      Dwayne Robinson added 1 comment

      Patchset-level comments
      File-level comment, Patchset 4 (Latest):
      Dwayne Robinson . resolved

      👍

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Dai, Feng
      • Hu, Ningxin
      • Reilly Grant
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I69fe81b9055f6006e4b258a53d3fcd59d3052cae
      Gerrit-Change-Number: 7768249
      Gerrit-PatchSet: 4
      Gerrit-Owner: Dai, Feng <feng...@intel.com>
      Gerrit-Reviewer: Dai, Feng <feng...@intel.com>
      Gerrit-Reviewer: Hu, Ningxin <ningx...@intel.com>
      Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
      Gerrit-CC: Dwayne Robinson <dwa...@microsoft.com>
      Gerrit-Attention: Reilly Grant <rei...@chromium.org>
      Gerrit-Attention: Hu, Ningxin <ningx...@intel.com>
      Gerrit-Attention: Dai, Feng <feng...@intel.com>
      Gerrit-Comment-Date: Fri, 17 Apr 2026 02:58:20 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Hu, Ningxin (Gerrit)

      unread,
      Apr 20, 2026, 2:40:41 AMApr 20
      to Dai, Feng, Reilly Grant, Dwayne Robinson, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
      Attention needed from Dai, Feng and Reilly Grant

      Hu, Ningxin added 3 comments

      File services/webnn/tflite/graph_builder_tflite.cc
      Line 917, Patchset 4 (Latest): // TFLite's native PReLU path is used for lower-rank tensors, and
      // SerializePrelu emulates rank-5 cases with element-wise ops to preserve
      // WebNN broadcasting semantics for the 5D conformance coverage.
      // https://source.chromium.org/chromium/chromium/src/+/main:third_party/tflite/src/tensorflow/lite/kernels/internal/reference/prelu.h
      Hu, Ningxin . unresolved

      inconsistent indentation.

      Line 8122, Patchset 4 (Latest): ASSIGN_OR_RETURN(const TensorIndex zero_value_tensor_index,
      SerializeTensorWithBuffer<float>(
      /*buffer=*/std::array<float, 1>{0.0f},
      /*dimensions=*/{}));
      Hu, Ningxin . unresolved

      Worth adding a comment explaining why only create float32 zero tensor, e.g. "Prelu input tensors are already dequantized to float32 by SerializeInputTensorInfo."

      Line 8142, Patchset 4 (Latest): ASSIGN_OR_RETURN(const TensorIndex scaled_negative_tensor_index,
      SerializeTemporaryTensorWithByteSizeCheck(
      input_tensor_info.dimensions,
      input_tensor_info.data_type));
      Hu, Ningxin . unresolved

      The `scaled_negative_tensor_index` temporary is allocated with `input_tensor_info.dimensions`, but after slope * min(x, 0), the result shape may be the broadcast of `slope_tensor_info.dimensions`. If the slope has a dimension larger than 1 where input has 1, the intermediate tensor shape would be wrong. Consider using `output_tensor_info.dimensions` and adding a test case.

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Dai, Feng
      • Reilly Grant
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement is not satisfiedCode-Owners
        • requirement is not satisfiedCode-Review
        • requirement is not satisfiedNo-Unresolved-Comments
        • requirement is not satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I69fe81b9055f6006e4b258a53d3fcd59d3052cae
        Gerrit-Change-Number: 7768249
        Gerrit-PatchSet: 4
        Gerrit-Owner: Dai, Feng <feng...@intel.com>
        Gerrit-Reviewer: Dai, Feng <feng...@intel.com>
        Gerrit-Reviewer: Hu, Ningxin <ningx...@intel.com>
        Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
        Gerrit-CC: Dwayne Robinson <dwa...@microsoft.com>
        Gerrit-Attention: Reilly Grant <rei...@chromium.org>
        Gerrit-Attention: Dai, Feng <feng...@intel.com>
        Gerrit-Comment-Date: Mon, 20 Apr 2026 06:40:33 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: No
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Dai, Feng (Gerrit)

        unread,
        Apr 20, 2026, 9:38:10 PMApr 20
        to Reilly Grant, Hu, Ningxin, Dwayne Robinson, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
        Attention needed from Hu, Ningxin and Reilly Grant

        Dai, Feng added 3 comments

        File services/webnn/tflite/graph_builder_tflite.cc
        Line 917, Patchset 4: // TFLite's native PReLU path is used for lower-rank tensors, and

        // SerializePrelu emulates rank-5 cases with element-wise ops to preserve
        // WebNN broadcasting semantics for the 5D conformance coverage.
        // https://source.chromium.org/chromium/chromium/src/+/main:third_party/tflite/src/tensorflow/lite/kernels/internal/reference/prelu.h
        Hu, Ningxin . resolved

        inconsistent indentation.

        Dai, Feng

        Done.
        Please take another look at the new commit, thanks!

        Line 8122, Patchset 4: ASSIGN_OR_RETURN(const TensorIndex zero_value_tensor_index,

        SerializeTensorWithBuffer<float>(
        /*buffer=*/std::array<float, 1>{0.0f},
        /*dimensions=*/{}));
        Hu, Ningxin . unresolved

        Worth adding a comment explaining why only create float32 zero tensor, e.g. "Prelu input tensors are already dequantized to float32 by SerializeInputTensorInfo."

        Dai, Feng

        Thanks @ningx...@intel.com!
        I added such explanation comment here.
        Please take another look at the new commit, thanks!

        Line 8142, Patchset 4: ASSIGN_OR_RETURN(const TensorIndex scaled_negative_tensor_index,
        SerializeTemporaryTensorWithByteSizeCheck(
        input_tensor_info.dimensions,
        input_tensor_info.data_type));
        Hu, Ningxin . unresolved

        The `scaled_negative_tensor_index` temporary is allocated with `input_tensor_info.dimensions`, but after slope * min(x, 0), the result shape may be the broadcast of `slope_tensor_info.dimensions`. If the slope has a dimension larger than 1 where input has 1, the intermediate tensor shape would be wrong. Consider using `output_tensor_info.dimensions` and adding a test case.

        Dai, Feng

        Good catch! 👍
        Updated in new commit, please take another look, thanks!

        If the slope has a dimension larger than 1 where input has 1, the intermediate tensor shape would be wrong. Consider using `output_tensor_info.dimensions` and adding a test case.

        Added such a test case "prelu float32 broadcast 5D x 5D slope with expanded output shape" using input of `[2, 1, 1, 2, 3]` shape with slope of `[1, 2, 1, 1, 1]` shape, current this test would run `Fail`, since there's this issue https://issues.chromium.org/issues/503402055 -
        Support bidirectionally broadcast the shapes of input and slope for prelu operator, I will fix it in another following CL later.

        Open in Gerrit

        Related details

        Attention is currently required from:
        • Hu, Ningxin
        • Reilly Grant
        Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement is not satisfiedCode-Owners
        • requirement is not satisfiedCode-Review
        • requirement is not satisfiedNo-Unresolved-Comments
        • requirement is not satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I69fe81b9055f6006e4b258a53d3fcd59d3052cae
        Gerrit-Change-Number: 7768249
        Gerrit-PatchSet: 5
        Gerrit-Owner: Dai, Feng <feng...@intel.com>
        Gerrit-Reviewer: Dai, Feng <feng...@intel.com>
        Gerrit-Reviewer: Hu, Ningxin <ningx...@intel.com>
        Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
        Gerrit-CC: Dwayne Robinson <dwa...@microsoft.com>
        Gerrit-Attention: Hu, Ningxin <ningx...@intel.com>
        Gerrit-Attention: Reilly Grant <rei...@chromium.org>
        Gerrit-Comment-Date: Tue, 21 Apr 2026 01:37:56 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: No
        Comment-In-Reply-To: Hu, Ningxin <ningx...@intel.com>
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Hu, Ningxin (Gerrit)

        unread,
        Apr 21, 2026, 12:25:46 AMApr 21
        to Dai, Feng, Reilly Grant, Dwayne Robinson, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
        Attention needed from Dai, Feng and Reilly Grant

        Hu, Ningxin voted and added 4 comments

        Votes added by Hu, Ningxin

        Code-Review+1

        4 comments

        Patchset-level comments
        File-level comment, Patchset 5 (Latest):
        Hu, Ningxin . resolved

        LGTM with a comment

        File services/webnn/tflite/graph_builder_tflite.cc
        Line 8122, Patchset 4: ASSIGN_OR_RETURN(const TensorIndex zero_value_tensor_index,
        SerializeTensorWithBuffer<float>(
        /*buffer=*/std::array<float, 1>{0.0f},
        /*dimensions=*/{}));
        Hu, Ningxin . resolved

        Worth adding a comment explaining why only create float32 zero tensor, e.g. "Prelu input tensors are already dequantized to float32 by SerializeInputTensorInfo."

        Dai, Feng

        Thanks @ningx...@intel.com!
        I added such explanation comment here.
        Please take another look at the new commit, thanks!

        Hu, Ningxin

        Acknowledged

        Line 8142, Patchset 4: ASSIGN_OR_RETURN(const TensorIndex scaled_negative_tensor_index,
        SerializeTemporaryTensorWithByteSizeCheck(
        input_tensor_info.dimensions,
        input_tensor_info.data_type));
        Hu, Ningxin . resolved

        The `scaled_negative_tensor_index` temporary is allocated with `input_tensor_info.dimensions`, but after slope * min(x, 0), the result shape may be the broadcast of `slope_tensor_info.dimensions`. If the slope has a dimension larger than 1 where input has 1, the intermediate tensor shape would be wrong. Consider using `output_tensor_info.dimensions` and adding a test case.

        Dai, Feng

        Good catch! 👍
        Updated in new commit, please take another look, thanks!

        If the slope has a dimension larger than 1 where input has 1, the intermediate tensor shape would be wrong. Consider using `output_tensor_info.dimensions` and adding a test case.

        Added such a test case "prelu float32 broadcast 5D x 5D slope with expanded output shape" using input of `[2, 1, 1, 2, 3]` shape with slope of `[1, 2, 1, 1, 1]` shape, current this test would run `Fail`, since there's this issue https://issues.chromium.org/issues/503402055 -
        Support bidirectionally broadcast the shapes of input and slope for prelu operator, I will fix it in another following CL later.

        Hu, Ningxin

        Acknowledged

        Line 8148, Patchset 5 (Latest): input_tensor_info.data_type));
        Hu, Ningxin . unresolved

        Use `output_tensor_info` as well.

        Open in Gerrit

        Related details

        Attention is currently required from:
        • Dai, Feng
        • Reilly Grant
        Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement is not satisfiedCode-Review
        • requirement is not satisfiedNo-Unresolved-Comments
        • requirement is not satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I69fe81b9055f6006e4b258a53d3fcd59d3052cae
        Gerrit-Change-Number: 7768249
        Gerrit-PatchSet: 5
        Gerrit-Owner: Dai, Feng <feng...@intel.com>
        Gerrit-Reviewer: Dai, Feng <feng...@intel.com>
        Gerrit-Reviewer: Hu, Ningxin <ningx...@intel.com>
        Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
        Gerrit-CC: Dwayne Robinson <dwa...@microsoft.com>
        Gerrit-Attention: Reilly Grant <rei...@chromium.org>
        Gerrit-Attention: Dai, Feng <feng...@intel.com>
        Gerrit-Comment-Date: Tue, 21 Apr 2026 04:25:38 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: Yes
        Comment-In-Reply-To: Hu, Ningxin <ningx...@intel.com>
        Comment-In-Reply-To: Dai, Feng <feng...@intel.com>
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Dai, Feng (Gerrit)

        unread,
        Apr 21, 2026, 1:09:04 AMApr 21
        to Hu, Ningxin, Reilly Grant, Dwayne Robinson, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
        Attention needed from Hu, Ningxin and Reilly Grant

        Dai, Feng added 1 comment

        File services/webnn/tflite/graph_builder_tflite.cc
        Line 8148, Patchset 5: input_tensor_info.data_type));
        Hu, Ningxin . resolved

        Use `output_tensor_info` as well.

        Dai, Feng

        Updated.Thanks @ningx...@intel.com!

        Open in Gerrit

        Related details

        Attention is currently required from:
        • Hu, Ningxin
        • Reilly Grant
        Submit Requirements:
          • requirement satisfiedCode-Coverage
          • requirement satisfiedCode-Owners
          • requirement is not satisfiedCode-Review
          • requirement is not satisfiedReview-Enforcement
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: I69fe81b9055f6006e4b258a53d3fcd59d3052cae
          Gerrit-Change-Number: 7768249
          Gerrit-PatchSet: 6
          Gerrit-Owner: Dai, Feng <feng...@intel.com>
          Gerrit-Reviewer: Dai, Feng <feng...@intel.com>
          Gerrit-Reviewer: Hu, Ningxin <ningx...@intel.com>
          Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
          Gerrit-CC: Dwayne Robinson <dwa...@microsoft.com>
          Gerrit-Attention: Hu, Ningxin <ningx...@intel.com>
          Gerrit-Attention: Reilly Grant <rei...@chromium.org>
          Gerrit-Comment-Date: Tue, 21 Apr 2026 05:08:41 +0000
          satisfied_requirement
          unsatisfied_requirement
          open
          diffy

          Hu, Ningxin (Gerrit)

          unread,
          Apr 21, 2026, 1:23:01 AMApr 21
          to Dai, Feng, Reilly Grant, Dwayne Robinson, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
          Attention needed from Dai, Feng and Reilly Grant

          Hu, Ningxin voted and added 1 comment

          Votes added by Hu, Ningxin

          Code-Review+1

          1 comment

          Patchset-level comments
          Hu, Ningxin . resolved

          LGTM

          Open in Gerrit

          Related details

          Attention is currently required from:
          • Dai, Feng
          • Reilly Grant
          Submit Requirements:
          • requirement satisfiedCode-Coverage
          • requirement satisfiedCode-Owners
          • requirement is not satisfiedCode-Review
          • requirement is not satisfiedReview-Enforcement
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: I69fe81b9055f6006e4b258a53d3fcd59d3052cae
          Gerrit-Change-Number: 7768249
          Gerrit-PatchSet: 6
          Gerrit-Owner: Dai, Feng <feng...@intel.com>
          Gerrit-Reviewer: Dai, Feng <feng...@intel.com>
          Gerrit-Reviewer: Hu, Ningxin <ningx...@intel.com>
          Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
          Gerrit-CC: Dwayne Robinson <dwa...@microsoft.com>
          Gerrit-Attention: Reilly Grant <rei...@chromium.org>
          Gerrit-Attention: Dai, Feng <feng...@intel.com>
          Gerrit-Comment-Date: Tue, 21 Apr 2026 05:22:52 +0000
          Gerrit-HasComments: Yes
          Gerrit-Has-Labels: Yes
          satisfied_requirement
          unsatisfied_requirement
          open
          diffy

          Dai, Feng (Gerrit)

          unread,
          Apr 22, 2026, 9:20:51 AMApr 22
          to Hu, Ningxin, Reilly Grant, Dwayne Robinson, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
          Attention needed from Reilly Grant

          Dai, Feng added 1 comment

          Patchset-level comments
          Dai, Feng . resolved

          Gentle ping @rei...@chromium.org Please take a review when you're available. Thanks!

          Open in Gerrit

          Related details

          Attention is currently required from:
          • Reilly Grant
          Submit Requirements:
          • requirement satisfiedCode-Coverage
          • requirement satisfiedCode-Owners
          • requirement is not satisfiedCode-Review
          • requirement is not satisfiedReview-Enforcement
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: I69fe81b9055f6006e4b258a53d3fcd59d3052cae
          Gerrit-Change-Number: 7768249
          Gerrit-PatchSet: 6
          Gerrit-Owner: Dai, Feng <feng...@intel.com>
          Gerrit-Reviewer: Dai, Feng <feng...@intel.com>
          Gerrit-Reviewer: Hu, Ningxin <ningx...@intel.com>
          Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
          Gerrit-CC: Dwayne Robinson <dwa...@microsoft.com>
          Gerrit-Attention: Reilly Grant <rei...@chromium.org>
          Gerrit-Comment-Date: Wed, 22 Apr 2026 13:20:38 +0000
          Gerrit-HasComments: Yes
          Gerrit-Has-Labels: No
          satisfied_requirement
          unsatisfied_requirement
          open
          diffy

          Reilly Grant (Gerrit)

          unread,
          Apr 27, 2026, 9:00:00 PMApr 27
          to Dai, Feng, Reilly Grant, Hu, Ningxin, Dwayne Robinson, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
          Attention needed from Dai, Feng

          Reilly Grant voted and added 1 comment

          Votes added by Reilly Grant

          Code-Review+1

          1 comment

          Patchset-level comments
          Reilly Grant . resolved

          LGTM

          Open in Gerrit

          Related details

          Attention is currently required from:
          • Dai, Feng
          Submit Requirements:
            • requirement satisfiedCode-Coverage
            • requirement satisfiedCode-Owners
            • requirement satisfiedCode-Review
            • requirement satisfiedReview-Enforcement
            Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
            Gerrit-MessageType: comment
            Gerrit-Project: chromium/src
            Gerrit-Branch: main
            Gerrit-Change-Id: I69fe81b9055f6006e4b258a53d3fcd59d3052cae
            Gerrit-Change-Number: 7768249
            Gerrit-PatchSet: 6
            Gerrit-Owner: Dai, Feng <feng...@intel.com>
            Gerrit-Reviewer: Dai, Feng <feng...@intel.com>
            Gerrit-Reviewer: Hu, Ningxin <ningx...@intel.com>
            Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
            Gerrit-CC: Dwayne Robinson <dwa...@microsoft.com>
            Gerrit-Attention: Dai, Feng <feng...@intel.com>
            Gerrit-Comment-Date: Tue, 28 Apr 2026 00:59:44 +0000
            Gerrit-HasComments: Yes
            Gerrit-Has-Labels: Yes
            satisfied_requirement
            open
            diffy

            Dai, Feng (Gerrit)

            unread,
            Apr 27, 2026, 9:38:17 PMApr 27
            to Reilly Grant, Hu, Ningxin, Dwayne Robinson, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org

            Dai, Feng voted and added 1 comment

            Votes added by Dai, Feng

            Auto-Submit+1
            Commit-Queue+2

            1 comment

            Patchset-level comments
            Dai, Feng . resolved

            Thanks all for your reviewing!
            I'm going to submit this CL.

            Open in Gerrit

            Related details

            Attention set is empty
            Submit Requirements:
            • requirement satisfiedCode-Coverage
            • requirement satisfiedCode-Owners
            • requirement satisfiedCode-Review
            • requirement satisfiedReview-Enforcement
            Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
            Gerrit-MessageType: comment
            Gerrit-Project: chromium/src
            Gerrit-Branch: main
            Gerrit-Change-Id: I69fe81b9055f6006e4b258a53d3fcd59d3052cae
            Gerrit-Change-Number: 7768249
            Gerrit-PatchSet: 6
            Gerrit-Owner: Dai, Feng <feng...@intel.com>
            Gerrit-Reviewer: Dai, Feng <feng...@intel.com>
            Gerrit-Reviewer: Hu, Ningxin <ningx...@intel.com>
            Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
            Gerrit-CC: Dwayne Robinson <dwa...@microsoft.com>
            Gerrit-Comment-Date: Tue, 28 Apr 2026 01:37:51 +0000
            Gerrit-HasComments: Yes
            Gerrit-Has-Labels: Yes
            satisfied_requirement
            open
            diffy

            Dai, Feng (Gerrit)

            unread,
            Apr 29, 2026, 4:31:15 AMApr 29
            to android-bu...@system.gserviceaccount.com, Reilly Grant, Hu, Ningxin, Dwayne Robinson, Chromium LUCI CQ, chromium...@chromium.org, mac-r...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
            Attention needed from Hu, Ningxin and Reilly Grant

            Dai, Feng voted and added 1 comment

            Votes added by Dai, Feng

            Auto-Submit+1

            1 comment

            Patchset-level comments
            File-level comment, Patchset 9 (Latest):
            Dai, Feng . resolved

            Last there're trybot's failures when submitting CL, then I rebasline and rebase code to make all trybots pass. Now the failure results in expected files are due to this issue [#503402055 - Support bidirectionally broadcast the shapes of input and slope for prelu operator](https://issues.chromium.org/issues/503402055) that I'm working on a follow-up CL.
            @ningx...@intel.com @rei...@chromium.org Please take another look, thanks!

            Open in Gerrit

            Related details

            Attention is currently required from:
            • Hu, Ningxin
            • Reilly Grant
            Submit Requirements:
              • requirement satisfiedCode-Coverage
              • requirement satisfiedCode-Owners
              • requirement is not satisfiedCode-Review
              • requirement is not satisfiedReview-Enforcement
              Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
              Gerrit-MessageType: comment
              Gerrit-Project: chromium/src
              Gerrit-Branch: main
              Gerrit-Change-Id: I69fe81b9055f6006e4b258a53d3fcd59d3052cae
              Gerrit-Change-Number: 7768249
              Gerrit-PatchSet: 9
              Gerrit-Owner: Dai, Feng <feng...@intel.com>
              Gerrit-Reviewer: Dai, Feng <feng...@intel.com>
              Gerrit-Reviewer: Hu, Ningxin <ningx...@intel.com>
              Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
              Gerrit-CC: Dwayne Robinson <dwa...@microsoft.com>
              Gerrit-Attention: Hu, Ningxin <ningx...@intel.com>
              Gerrit-Attention: Reilly Grant <rei...@chromium.org>
              Gerrit-Comment-Date: Wed, 29 Apr 2026 08:31:01 +0000
              Gerrit-HasComments: Yes
              Gerrit-Has-Labels: Yes
              satisfied_requirement
              unsatisfied_requirement
              open
              diffy

              Reilly Grant (Gerrit)

              unread,
              Apr 29, 2026, 4:46:13 PMApr 29
              to Dai, Feng, Reilly Grant, android-bu...@system.gserviceaccount.com, Hu, Ningxin, Dwayne Robinson, Chromium LUCI CQ, chromium...@chromium.org, mac-r...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
              Attention needed from Dai, Feng and Hu, Ningxin

              Reilly Grant voted and added 1 comment

              Votes added by Reilly Grant

              Code-Review+1

              1 comment

              Patchset-level comments
              Reilly Grant . resolved

              LGTM

              Open in Gerrit

              Related details

              Attention is currently required from:
              • Dai, Feng
              • Hu, Ningxin
              Submit Requirements:
              • requirement satisfiedCode-Coverage
              • requirement satisfiedCode-Owners
              • requirement is not satisfiedCode-Review
              • requirement is not satisfiedReview-Enforcement
              Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
              Gerrit-MessageType: comment
              Gerrit-Project: chromium/src
              Gerrit-Branch: main
              Gerrit-Change-Id: I69fe81b9055f6006e4b258a53d3fcd59d3052cae
              Gerrit-Change-Number: 7768249
              Gerrit-PatchSet: 9
              Gerrit-Owner: Dai, Feng <feng...@intel.com>
              Gerrit-Reviewer: Dai, Feng <feng...@intel.com>
              Gerrit-Reviewer: Hu, Ningxin <ningx...@intel.com>
              Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
              Gerrit-CC: Dwayne Robinson <dwa...@microsoft.com>
              Gerrit-Attention: Hu, Ningxin <ningx...@intel.com>
              Gerrit-Attention: Dai, Feng <feng...@intel.com>
              Gerrit-Comment-Date: Wed, 29 Apr 2026 20:45:51 +0000
              Gerrit-HasComments: Yes
              Gerrit-Has-Labels: Yes
              satisfied_requirement
              unsatisfied_requirement
              open
              diffy

              Hu, Ningxin (Gerrit)

              unread,
              May 1, 2026, 4:08:14 PMMay 1
              to Dai, Feng, Reilly Grant, android-bu...@system.gserviceaccount.com, Dwayne Robinson, Chromium LUCI CQ, chromium...@chromium.org, mac-r...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
              Attention needed from Dai, Feng

              Hu, Ningxin voted and added 1 comment

              Votes added by Hu, Ningxin

              Code-Review+1
              Commit-Queue+2

              1 comment

              Patchset-level comments
              Hu, Ningxin . resolved

              LGTM

              Open in Gerrit

              Related details

              Attention is currently required from:
              • Dai, Feng
              Submit Requirements:
                • requirement satisfiedCode-Coverage
                • requirement satisfiedCode-Owners
                • requirement satisfiedCode-Review
                • requirement satisfiedReview-Enforcement
                Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
                Gerrit-MessageType: comment
                Gerrit-Project: chromium/src
                Gerrit-Branch: main
                Gerrit-Change-Id: I69fe81b9055f6006e4b258a53d3fcd59d3052cae
                Gerrit-Change-Number: 7768249
                Gerrit-PatchSet: 9
                Gerrit-Owner: Dai, Feng <feng...@intel.com>
                Gerrit-Reviewer: Dai, Feng <feng...@intel.com>
                Gerrit-Reviewer: Hu, Ningxin <ningx...@intel.com>
                Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
                Gerrit-CC: Dwayne Robinson <dwa...@microsoft.com>
                Gerrit-Attention: Dai, Feng <feng...@intel.com>
                Gerrit-Comment-Date: Fri, 01 May 2026 20:08:06 +0000
                Gerrit-HasComments: Yes
                Gerrit-Has-Labels: Yes
                satisfied_requirement
                open
                diffy

                Blink W3C Test Autoroller (Gerrit)

                unread,
                May 1, 2026, 4:30:20 PMMay 1
                to Dai, Feng, Hu, Ningxin, Reilly Grant, android-bu...@system.gserviceaccount.com, Dwayne Robinson, Chromium LUCI CQ, chromium...@chromium.org, mac-r...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
                Attention needed from Dai, Feng

                Message from Blink W3C Test Autoroller

                Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/59612.

                When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.

                WPT Export docs:
                https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process

                Open in Gerrit

                Related details

                Attention is currently required from:
                • Dai, Feng
                Submit Requirements:
                • requirement satisfiedCode-Coverage
                • requirement satisfiedCode-Owners
                • requirement satisfiedCode-Review
                • requirement satisfiedReview-Enforcement
                Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
                Gerrit-MessageType: comment
                Gerrit-Project: chromium/src
                Gerrit-Branch: main
                Gerrit-Change-Id: I69fe81b9055f6006e4b258a53d3fcd59d3052cae
                Gerrit-Change-Number: 7768249
                Gerrit-PatchSet: 9
                Gerrit-Owner: Dai, Feng <feng...@intel.com>
                Gerrit-Reviewer: Dai, Feng <feng...@intel.com>
                Gerrit-Reviewer: Hu, Ningxin <ningx...@intel.com>
                Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
                Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
                Gerrit-Comment-Date: Fri, 01 May 2026 20:30:13 +0000
                Gerrit-HasComments: No
                Gerrit-Has-Labels: No
                satisfied_requirement
                open
                diffy

                Dai, Feng (Gerrit)

                unread,
                May 6, 2026, 5:40:40 AM (13 days ago) May 6
                to Blink W3C Test Autoroller, Hu, Ningxin, Reilly Grant, android-bu...@system.gserviceaccount.com, Dwayne Robinson, Chromium LUCI CQ, chromium...@chromium.org, mac-r...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
                Attention needed from Hu, Ningxin

                Dai, Feng voted Commit-Queue+2

                Commit-Queue+2
                Open in Gerrit

                Related details

                Attention is currently required from:
                • Hu, Ningxin
                Submit Requirements:
                • requirement satisfiedCode-Coverage
                • requirement satisfiedCode-Owners
                • requirement satisfiedCode-Review
                • requirement satisfiedReview-Enforcement
                Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
                Gerrit-MessageType: comment
                Gerrit-Project: chromium/src
                Gerrit-Branch: main
                Gerrit-Change-Id: I69fe81b9055f6006e4b258a53d3fcd59d3052cae
                Gerrit-Change-Number: 7768249
                Gerrit-PatchSet: 9
                Gerrit-Owner: Dai, Feng <feng...@intel.com>
                Gerrit-Reviewer: Dai, Feng <feng...@intel.com>
                Gerrit-Reviewer: Hu, Ningxin <ningx...@intel.com>
                Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
                Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
                Gerrit-CC: Dwayne Robinson <dwa...@microsoft.com>
                Gerrit-Attention: Hu, Ningxin <ningx...@intel.com>
                Gerrit-Comment-Date: Wed, 06 May 2026 09:40:23 +0000
                Gerrit-HasComments: No
                Gerrit-Has-Labels: Yes
                satisfied_requirement
                open
                diffy

                Chromium LUCI CQ (Gerrit)

                unread,
                May 6, 2026, 8:09:19 AM (13 days ago) May 6
                to Dai, Feng, Blink W3C Test Autoroller, Hu, Ningxin, Reilly Grant, android-bu...@system.gserviceaccount.com, Dwayne Robinson, chromium...@chromium.org, mac-r...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org

                Chromium LUCI CQ submitted the change

                Change information

                Commit message:
                webnn: emulate rank-5 prelu's input tensors in TFLite

                This CL updates SerializePrelu() function to emulate rank-5 input
                tensors for TFLite's prelu operator, which supports at most rank-4 input
                tensors. Now, the maximum rank of input tensors for prelu, relu, and elu
                operators has been unified, with support up to rank 5.
                Bug: 478888160
                Change-Id: I69fe81b9055f6006e4b258a53d3fcd59d3052cae
                Cq-Include-Trybots: luci.chromium.try:win11-blink-rel, mac14.arm64-blink-rel, mac14-blink-rel, mac15.arm64-blink-rel, mac15-blink-rel, linux-blink-rel
                Reviewed-by: Hu, Ningxin <ningx...@intel.com>
                Auto-Submit: Dai, Feng <feng...@intel.com>
                Commit-Queue: Dai, Feng <feng...@intel.com>
                Reviewed-by: Reilly Grant <rei...@chromium.org>
                Cr-Commit-Position: refs/heads/main@{#1626058}
                Files:
                • M services/webnn/tflite/graph_builder_tflite.cc
                • M third_party/blink/web_tests/external/wpt/webnn/conformance_tests/prelu.https.any.js
                • M third_party/blink/web_tests/external/wpt/webnn/resources/minimum_datatype_set.json
                • A third_party/blink/web_tests/virtual/webnn-service-on-cpu/external/wpt/webnn/conformance_tests/prelu.https.any_cpu-expected.txt
                • A third_party/blink/web_tests/virtual/webnn-service-on-npu/external/wpt/webnn/conformance_tests/prelu.https.any_npu-expected.txt
                • A third_party/blink/web_tests/virtual/webnn-service-with-gpu/external/wpt/webnn/conformance_tests/prelu.https.any_gpu-expected.txt
                Change size: L
                Delta: 6 files changed, 287 insertions(+), 4 deletions(-)
                Branch: refs/heads/main
                Submit Requirements:
                • requirement satisfiedCode-Review: +1 by Reilly Grant, +1 by Hu, Ningxin
                Open in Gerrit
                Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
                Gerrit-MessageType: merged
                Gerrit-Project: chromium/src
                Gerrit-Branch: main
                Gerrit-Change-Id: I69fe81b9055f6006e4b258a53d3fcd59d3052cae
                Gerrit-Change-Number: 7768249
                Gerrit-PatchSet: 10
                Gerrit-Owner: Dai, Feng <feng...@intel.com>
                Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
                Gerrit-Reviewer: Dai, Feng <feng...@intel.com>
                Gerrit-Reviewer: Hu, Ningxin <ningx...@intel.com>
                Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
                Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
                open
                diffy
                satisfied_requirement

                Blink W3C Test Autoroller (Gerrit)

                unread,
                May 6, 2026, 10:14:20 AM (13 days ago) May 6
                to Chromium LUCI CQ, Dai, Feng, Hu, Ningxin, Reilly Grant, android-bu...@system.gserviceaccount.com, Dwayne Robinson, chromium...@chromium.org, mac-r...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org

                Message from Blink W3C Test Autoroller

                The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/59612

                Open in Gerrit

                Related details

                Attention set is empty
                Submit Requirements:
                • requirement satisfiedCode-Coverage
                • requirement satisfiedCode-Owners
                • requirement satisfiedCode-Review
                • requirement satisfiedReview-Enforcement
                Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
                Gerrit-MessageType: comment
                Gerrit-Project: chromium/src
                Gerrit-Branch: main
                Gerrit-Change-Id: I69fe81b9055f6006e4b258a53d3fcd59d3052cae
                Gerrit-Change-Number: 7768249
                Gerrit-PatchSet: 10
                Gerrit-Owner: Dai, Feng <feng...@intel.com>
                Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
                Gerrit-Reviewer: Dai, Feng <feng...@intel.com>
                Gerrit-Reviewer: Hu, Ningxin <ningx...@intel.com>
                Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
                Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
                Gerrit-CC: Dwayne Robinson <dwa...@microsoft.com>
                Gerrit-Comment-Date: Wed, 06 May 2026 14:14:00 +0000
                Gerrit-HasComments: No
                Gerrit-Has-Labels: No
                satisfied_requirement
                open
                diffy
                Reply all
                Reply to author
                Forward
                0 new messages