Avoid creating context for destroying document [chromium/src : main]
0 views
Skip to first unread message
Yiren Wang (Gerrit)
7:06 PM (4 hours ago) 7:06 PM
to Muyao Xu, Kevin McNee, Frank Liberato, Michael Crouse, Chromium LUCI CQ, chromium...@chromium.org, dewitt...@chromium.org, feature-me...@chromium.org
Attention needed from Muyao Xu
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Muyao Xu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Muyao Xu (Gerrit)
7:07 PM (4 hours ago) 7:07 PM
to Yiren Wang, Kevin McNee, Frank Liberato, Michael Crouse, Chromium LUCI CQ, chromium...@chromium.org, dewitt...@chromium.org, feature-me...@chromium.org
Attention needed from Yiren Wang
Muyao Xu voted and added 1 comment![]( "Open in Gerrit")
Attention is currently required from:
- Yiren Wang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yiren Wang (Gerrit)
7:19 PM (4 hours ago) 7:19 PM
to Muyao Xu, Kevin McNee, Frank Liberato, Michael Crouse, Chromium LUCI CQ, chromium...@chromium.org, dewitt...@chromium.org, feature-me...@chromium.org
Yiren Wang voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
9:05 PM (2 hours ago) 9:05 PM
to Yiren Wang, Muyao Xu, Kevin McNee, Frank Liberato, Michael Crouse, chromium...@chromium.org, dewitt...@chromium.org, feature-me...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Avoid creating context for destroying document
We should not attempt to create any new GlicMediaContext inside
OnPeerConnectionRemoved(), in case the document is being destroyed and
cannot accept any new user data.
Bug: 475303081
Change-Id: I5f87774cada4a888f053cabb5abec10ae0b334e2
Commit-Queue: Yiren Wang <y...@chromium.org>
Reviewed-by: Muyao Xu <muy...@google.com>
Cr-Commit-Position: refs/heads/main@{#1568857}
Files:
- M chrome/browser/glic/media/glic_media_integration.cc
Change size: XS
Delta: 1 file changed, 3 insertions(+), 5 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Muyao Xu
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages