Junji Watanabe (Gerrit)

unread,

Jan 13, 2026, 9:39:27 PM (6 hours ago) Jan 13

to Alex Ovsienko, LUCI CQ, chromium...@chromium.org, chops-source-team...@google.com, chrome-b...@google.com

Attention needed from Alex Ovsienko

Junji Watanabe voted

Auto-Submit	+1
Commit-Queue	+1

Open in Gerrit

Related details

Attention is currently required from:

Alex Ovsienko

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Fumitoshi Ukai (Gerrit)

unread,

Jan 13, 2026, 10:11:11 PM (5 hours ago) Jan 13

to Junji Watanabe, Fumitoshi Ukai, Philipp Wollermann, Alex Ovsienko, LUCI CQ, chromium...@chromium.org, chops-source-team...@google.com, chrome-b...@google.com

Attention needed from Alex Ovsienko, Junji Watanabe and Philipp Wollermann

Fumitoshi Ukai voted and added 1 comment

Votes added by Fumitoshi Ukai

Code-Review

+1

1 comment

File siso.py

Line 468, Patchset 2 (Latest):

Fumitoshi Ukai . unresolved

can't we make should_collect_logs to false if subcmd is not ninja here?

Open in Gerrit

Related details

Attention is currently required from:

Alex Ovsienko
Junji Watanabe
Philipp Wollermann

Submit Requirements:

Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Alex Ovsienko (Gerrit)

unread,

Jan 13, 2026, 10:23:21 PM (5 hours ago) Jan 13

to Junji Watanabe, Fumitoshi Ukai, Philipp Wollermann, LUCI CQ, chromium...@chromium.org, chops-source-team...@google.com, chrome-b...@google.com

Attention needed from Junji Watanabe and Philipp Wollermann

Alex Ovsienko added 1 comment

File siso.py

Line 535, Patchset 2 (Latest):

                if should_collect_logs and subcmd == 'ninja' and {"-h", "--help", "-help"
                                            }.isdisjoint(processed_args):

Alex Ovsienko . unresolved

Please cover this in unit tests.

Open in Gerrit

Related details

Attention is currently required from:

Junji Watanabe
Philipp Wollermann

Submit Requirements:

Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Alex Ovsienko (Gerrit)

unread,

Jan 13, 2026, 10:23:32 PM (5 hours ago) Jan 13

to Junji Watanabe, Fumitoshi Ukai, Philipp Wollermann, LUCI CQ, chromium...@chromium.org, chops-source-team...@google.com, chrome-b...@google.com

Attention needed from Junji Watanabe and Philipp Wollermann

Alex Ovsienko voted Code-Review-1

Code-Review

-1

Open in Gerrit

Related details

Attention is currently required from:

Junji Watanabe
Philipp Wollermann

Submit Requirements:

Code-Owners
Code-Review

No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

blocking_requirement

unsatisfied_requirement

open

diffy

Junji Watanabe (Gerrit)

unread,

Jan 13, 2026, 10:24:30 PM (5 hours ago) Jan 13

to Alex Ovsienko, Fumitoshi Ukai, Philipp Wollermann, LUCI CQ, chromium...@chromium.org, chops-source-team...@google.com, chrome-b...@google.com

Attention needed from Philipp Wollermann

Junji Watanabe voted and added 1 comment

Votes added by Junji Watanabe

Commit-Queue

+2

1 comment

File siso.py

Line 468, Patchset 2 (Latest):

Fumitoshi Ukai . resolved

can't we make should_collect_logs to false if subcmd is not ninja here?

Junji Watanabe

Yeah, considered that, too. Will refactor the code in a follow up CL. Let me submit this to fix the issue for now.

Open in Gerrit

Related details

Attention is currently required from:

Philipp Wollermann

Submit Requirements:

Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

blocking_requirement

unsatisfied_requirement

open

diffy

Junji Watanabe (Gerrit)

unread,

Jan 13, 2026, 11:20:19 PM (4 hours ago) Jan 13

to Alex Ovsienko, Fumitoshi Ukai, Philipp Wollermann, LUCI CQ, chromium...@chromium.org, chops-source-team...@google.com, chrome-b...@google.com

Attention needed from Alex Ovsienko and Philipp Wollermann

Junji Watanabe added 1 comment

File siso.py

Line 535, Patchset 2 (Latest):

                if should_collect_logs and subcmd == 'ninja' and {"-h", "--help", "-help"
                                            }.isdisjoint(processed_args):

Alex Ovsienko . unresolved

Please cover this in unit tests.

Junji Watanabe

Which tests do you think should have caught this bug?

Open in Gerrit

Related details

Attention is currently required from:

Alex Ovsienko
Philipp Wollermann

Submit Requirements:

Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

blocking_requirement

unsatisfied_requirement

open

diffy

Alex Ovsienko (Gerrit)

unread,

Jan 13, 2026, 11:41:49 PM (4 hours ago) Jan 13

to Junji Watanabe, Fumitoshi Ukai, Philipp Wollermann, LUCI CQ, chromium...@chromium.org, chops-source-team...@google.com, chrome-b...@google.com

Attention needed from Junji Watanabe and Philipp Wollermann

Alex Ovsienko added 1 comment

File siso.py

Line 535, Patchset 2 (Latest):

                if should_collect_logs and subcmd == 'ninja' and {"-h", "--help", "-help"
                                            }.isdisjoint(processed_args):

Alex Ovsienko . unresolved

Please cover this in unit tests.

Junji Watanabe

Which tests do you think should have caught this bug?

Alex Ovsienko

None right now, so I propose you create a new function that resolves this logic and test it.

Open in Gerrit

Related details

Attention is currently required from:

Junji Watanabe
Philipp Wollermann

Submit Requirements:

Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

blocking_requirement

unsatisfied_requirement

open

diffy

Alex Ovsienko (Gerrit)

unread,

Jan 13, 2026, 11:42:59 PM (4 hours ago) Jan 13

to Junji Watanabe, Fumitoshi Ukai, Philipp Wollermann, LUCI CQ, chromium...@chromium.org, chops-source-team...@google.com, chrome-b...@google.com

Attention needed from Junji Watanabe and Philipp Wollermann

Alex Ovsienko added 1 comment

File siso.py

Line 535, Patchset 2 (Latest):

                if should_collect_logs and subcmd == 'ninja' and {"-h", "--help", "-help"
                                            }.isdisjoint(processed_args):

Alex Ovsienko . unresolved

Please cover this in unit tests.

Junji Watanabe

Which tests do you think should have caught this bug?

Alex Ovsienko

None right now, so I propose you create a new function that resolves this logic and test it.

Alex Ovsienko

You can also put all this into _handle_collector and join with tests there.

satisfied_requirement

blocking_requirement

unsatisfied_requirement

open

diffy

Junji Watanabe (Gerrit)

unread,

12:30 AM (3 hours ago) 12:30 AM

to Alex Ovsienko, Fumitoshi Ukai, Philipp Wollermann, LUCI CQ, chromium...@chromium.org, chops-source-team...@google.com, chrome-b...@google.com

Attention needed from Alex Ovsienko and Philipp Wollermann

Junji Watanabe added 1 comment

File siso.py

Line 535, Patchset 2 (Latest):

                if should_collect_logs and subcmd == 'ninja' and {"-h", "--help", "-help"
                                            }.isdisjoint(processed_args):

Alex Ovsienko . unresolved

Please cover this in unit tests.

Junji Watanabe

Which tests do you think should have caught this bug?

Alex Ovsienko

None right now, so I propose you create a new function that resolves this logic and test it.

Alex Ovsienko

You can also put all this into _handle_collector and join with tests there.

Junji Watanabe

There are a lot of mocking required to make collector. Can you please tell me how to make healthy collector mock run?

Open in Gerrit

Related details

Attention is currently required from:

Alex Ovsienko
Philipp Wollermann

Submit Requirements:

Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

blocking_requirement

unsatisfied_requirement

open

diffy

Philipp Wollermann (Gerrit)

unread,

12:59 AM (2 hours ago) 12:59 AM

to Junji Watanabe, Alex Ovsienko, Fumitoshi Ukai, LUCI CQ, chromium...@chromium.org, chops-source-team...@google.com, chrome-b...@google.com

Attention needed from Alex Ovsienko and Junji Watanabe

Philipp Wollermann voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Alex Ovsienko
Junji Watanabe

Submit Requirements:

Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

blocking_requirement

unsatisfied_requirement

open

diffy

Alex Ovsienko (Gerrit)

unread,

1:54 AM (1 hour ago) 1:54 AM

to Junji Watanabe, Philipp Wollermann, Fumitoshi Ukai, LUCI CQ, chromium...@chromium.org, chops-source-team...@google.com, chrome-b...@google.com

Attention needed from Junji Watanabe

Alex Ovsienko added 1 comment

File siso.py

Line 535, Patchset 2 (Latest):

                if should_collect_logs and subcmd == 'ninja' and {"-h", "--help", "-help"
                                            }.isdisjoint(processed_args):

Alex Ovsienko . resolved

Please cover this in unit tests.

Junji Watanabe

Which tests do you think should have caught this bug?

Alex Ovsienko

None right now, so I propose you create a new function that resolves this logic and test it.

Alex Ovsienko

You can also put all this into _handle_collector and join with tests there.

Junji Watanabe

There are a lot of mocking required to make collector. Can you please tell me how to make healthy collector mock run?

Alex Ovsienko

OK I'll make my own CL after this.

Open in Gerrit

Related details

Attention is currently required from:

Junji Watanabe

Submit Requirements:

Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

blocking_requirement

open

diffy

Alex Ovsienko (Gerrit)

unread,

1:55 AM (1 hour ago) 1:55 AM

to Junji Watanabe, Philipp Wollermann, Fumitoshi Ukai, LUCI CQ, chromium...@chromium.org, chops-source-team...@google.com, chrome-b...@google.com

Attention needed from Junji Watanabe

Alex Ovsienko voted Code-Review+0

Code-Review

+0

Open in Gerrit

Related details

Attention is currently required from:

Junji Watanabe

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Alex Ovsienko (Gerrit)

unread,

1:59 AM (1 hour ago) 1:59 AM

to Junji Watanabe, Philipp Wollermann, Fumitoshi Ukai, LUCI CQ, chromium...@chromium.org, chops-source-team...@google.com, chrome-b...@google.com

Attention needed from Junji Watanabe

Alex Ovsienko voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention is currently required from:

Junji Watanabe

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

LUCI CQ (Gerrit)

unread,

2:07 AM (1 hour ago) 2:07 AM

to Junji Watanabe, Alex Ovsienko, Philipp Wollermann, Fumitoshi Ukai, chromium...@chromium.org, chops-source-team...@google.com, chrome-b...@google.com

LUCI CQ submitted the change

Change information

Commit message:

siso: Enable collector only for ninja sub command

`siso version` and other sub commands also start siso collector
unnecessarily.

Bug: 455433899

Change-Id: I36e6b4eb8679d2cf21144fc4e265657e704c7235

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7459645

Reviewed-by: Philipp Wollermann <phi...@google.com>

Reviewed-by: Fumitoshi Ukai <uk...@google.com>

Auto-Submit: Junji Watanabe <jw...@google.com>

Commit-Queue: Alex Ovsienko <ovsi...@google.com>

Files:

M siso.py

Change size: XS

Delta: 1 file changed, 1 insertion(+), 1 deletion(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Fumitoshi Ukai, +0 by Alex Ovsienko, +1 by Philipp Wollermann

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

siso: Enable collector only for ninja sub command [chromium/tools/depot_tools : main]

Junji Watanabe (Gerrit)

Junji Watanabe voted

Related details

Fumitoshi Ukai (Gerrit)

Fumitoshi Ukai voted and added 1 comment

Votes added by Fumitoshi Ukai

1 comment

Related details

Alex Ovsienko (Gerrit)

Alex Ovsienko added 1 comment

Related details

Alex Ovsienko (Gerrit)

Alex Ovsienko voted Code-Review-1

Related details

Junji Watanabe (Gerrit)

Junji Watanabe voted and added 1 comment

Votes added by Junji Watanabe

1 comment

Related details

Junji Watanabe (Gerrit)

Junji Watanabe added 1 comment

Related details

Alex Ovsienko (Gerrit)

Alex Ovsienko added 1 comment

Related details

Alex Ovsienko (Gerrit)

Alex Ovsienko added 1 comment

Junji Watanabe (Gerrit)

Junji Watanabe added 1 comment

Related details

Philipp Wollermann (Gerrit)

Philipp Wollermann voted Code-Review+1

Related details

Alex Ovsienko (Gerrit)

Alex Ovsienko added 1 comment

Related details

Alex Ovsienko (Gerrit)

Alex Ovsienko voted Code-Review+0

Related details

Alex Ovsienko (Gerrit)

Alex Ovsienko voted Commit-Queue+2

Related details

LUCI CQ (Gerrit)

LUCI CQ submitted the change

Change information