[ash] net: Drop dead chrome/browser/policy include [chromium/src : main]
0 views
Skip to first unread message
Tiago Vignatti (Gerrit)
Jul 8, 2026, 1:28:20 PM (22 hours ago) Jul 8
to Hidehiko Abe, Thomas Lukaszewicz, Chromium LUCI CQ, chromium...@chromium.org, Nikhil Nayunigari, chadduffin+w...@chromium.org, ejcaruso+wa...@chromium.org, hsuregan+wa...@chromium.org, jackshira+w...@google.com, jiajunz+wa...@google.com, jonmann+wa...@chromium.org, khorimoto+w...@chromium.org, net-r...@chromium.org, stevenjb+wa...@chromium.org
Attention needed from Hidehiko Abe
Tiago Vignatti added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Hidehiko Abe
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hidehiko Abe (Gerrit)
Jul 8, 2026, 9:19:56 PM (14 hours ago) Jul 8
to Tiago Vignatti, Thomas Lukaszewicz, Chromium LUCI CQ, chromium...@chromium.org, Nikhil Nayunigari, chadduffin+w...@chromium.org, ejcaruso+wa...@chromium.org, hsuregan+wa...@chromium.org, jackshira+w...@google.com, jiajunz+wa...@google.com, jonmann+wa...@chromium.org, khorimoto+w...@chromium.org, net-r...@chromium.org, stevenjb+wa...@chromium.org
Attention needed from Tiago Vignatti
Hidehiko Abe voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Tiago Vignatti
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tiago Vignatti (Gerrit)
7:59 AM (4 hours ago) 7:59 AM
to Hidehiko Abe, Thomas Lukaszewicz, Chromium LUCI CQ, chromium...@chromium.org, Nikhil Nayunigari, chadduffin+w...@chromium.org, ejcaruso+wa...@chromium.org, hsuregan+wa...@chromium.org, jackshira+w...@google.com, jiajunz+wa...@google.com, jonmann+wa...@chromium.org, khorimoto+w...@chromium.org, net-r...@chromium.org, stevenjb+wa...@chromium.org
Tiago Vignatti voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
8:16 AM (3 hours ago) 8:16 AM
to Tiago Vignatti, Hidehiko Abe, Thomas Lukaszewicz, chromium...@chromium.org, Nikhil Nayunigari, chadduffin+w...@chromium.org, ejcaruso+wa...@chromium.org, hsuregan+wa...@chromium.org, jackshira+w...@google.com, jiajunz+wa...@google.com, jonmann+wa...@chromium.org, khorimoto+w...@chromium.org, net-r...@chromium.org, stevenjb+wa...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[ash] net: Drop dead chrome/browser/policy include
alwayson_vpn_pre_connect_url_allowlist_service_factory.cc included
chrome/browser/policy/profile_policy_connector.h but never referenced
ProfilePolicyConnector, so the production include was dead. Remove it,
and scope the DEPS exemption to the browsertest that still uses the
connector instead of keeping it in the general include rules.
#ai-assisted
Bug: 353332589
Change-Id: I6218264eeee02a66a13da8a59e7debe974653f8e
Reviewed-by: Hidehiko Abe <hide...@chromium.org>
Commit-Queue: Tiago Vignatti <tvig...@igalia.com>
Cr-Commit-Position: refs/heads/main@{#1659478}
Files:
- M chrome/browser/ash/net/DEPS
- M chrome/browser/ash/net/alwayson_vpn_pre_connect_url_allowlist_service_factory.cc
Change size: XS
Delta: 2 files changed, 1 insertion(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Hidehiko Abe
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages