[chromecast] Fix Potential Integer Underflow and OOB Write in AudioSocket::ParseAudio [chromium/src : main]

1 view
Skip to first unread message

Simeon Anfinrud (Gerrit)

unread,
Apr 27, 2026, 8:42:04 PM (13 days ago) Apr 27
to chromium...@chromium.org, Yuchen Liu, android-bu...@system.gserviceaccount.com, halliwe...@chromium.org, feature-me...@chromium.org, net-r...@chromium.org
Attention needed from Yuchen Liu

Simeon Anfinrud voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Yuchen Liu
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I57d2c71e9276cfee6229483b1e3825baf07ccfd3
Gerrit-Change-Number: 7765504
Gerrit-PatchSet: 5
Gerrit-Owner: Simeon Anfinrud <san...@chromium.org>
Gerrit-Reviewer: Simeon Anfinrud <san...@chromium.org>
Gerrit-Reviewer: Yuchen Liu <yuc...@chromium.org>
Gerrit-Attention: Yuchen Liu <yuc...@chromium.org>
Gerrit-Comment-Date: Tue, 28 Apr 2026 00:41:54 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Simeon Anfinrud (Gerrit)

unread,
Apr 27, 2026, 9:15:06 PM (13 days ago) Apr 27
to Chromium LUCI CQ, chromium...@chromium.org, Yuchen Liu, android-bu...@system.gserviceaccount.com, halliwe...@chromium.org, feature-me...@chromium.org, net-r...@chromium.org
Attention needed from Yuchen Liu

Simeon Anfinrud added 1 comment

Message

Gemini says: Addressed Gerrit review comments.

1 comment

File chromecast/media/audio/net/audio_socket.cc
File-level comment, Patchset 6 (Latest):
Simeon Anfinrud . resolved

Gemini says: Done. Changed to audio buffer size.

Open in Gerrit

Related details

Attention is currently required from:
  • Yuchen Liu
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I57d2c71e9276cfee6229483b1e3825baf07ccfd3
    Gerrit-Change-Number: 7765504
    Gerrit-PatchSet: 6
    Gerrit-Owner: Simeon Anfinrud <san...@chromium.org>
    Gerrit-Reviewer: Simeon Anfinrud <san...@chromium.org>
    Gerrit-Reviewer: Yuchen Liu <yuc...@chromium.org>
    Gerrit-Comment-Date: Tue, 28 Apr 2026 01:14:49 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Simeon Anfinrud (Gerrit)

    unread,
    May 1, 2026, 10:08:02 PM (9 days ago) May 1
    to Chromium LUCI CQ, chromium...@chromium.org, Yuchen Liu, android-bu...@system.gserviceaccount.com, halliwe...@chromium.org, feature-me...@chromium.org, net-r...@chromium.org
    Attention needed from Yuchen Liu

    Simeon Anfinrud added 1 comment

    Message

    Gemini says: Addressed Gerrit review comments.

    1 comment

    File chromecast/media/audio/net/audio_socket.cc
    Simeon Anfinrud . resolved

    Gemini says: Done. Changed to audio buffer size.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Yuchen Liu
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I57d2c71e9276cfee6229483b1e3825baf07ccfd3
    Gerrit-Change-Number: 7765504
    Gerrit-PatchSet: 7
    Gerrit-Owner: Simeon Anfinrud <san...@chromium.org>
    Gerrit-Reviewer: Simeon Anfinrud <san...@chromium.org>
    Gerrit-Reviewer: Yuchen Liu <yuc...@chromium.org>
    Gerrit-Attention: Yuchen Liu <yuc...@chromium.org>
    Gerrit-Comment-Date: Sat, 02 May 2026 02:07:52 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Simeon Anfinrud (Gerrit)

    unread,
    May 9, 2026, 9:02:13 PM (16 hours ago) May 9
    to Yuchen Liu, Code Review Nudger, Chromium LUCI CQ, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, halliwe...@chromium.org, feature-me...@chromium.org, net-r...@chromium.org

    Simeon Anfinrud removed Yuchen Liu from this change

    Deleted Reviewers:
    • Yuchen Liu
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: deleteReviewer
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I57d2c71e9276cfee6229483b1e3825baf07ccfd3
    Gerrit-Change-Number: 7765504
    Gerrit-PatchSet: 8
    Gerrit-Owner: Simeon Anfinrud <san...@chromium.org>
    Gerrit-Reviewer: Simeon Anfinrud <san...@chromium.org>
    Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages