Extensions: CodeHealth: Update spelling of random words in permission* [chromium/src : main]

0 views
Skip to first unread message

Solomon Kinard (Gerrit)

unread,
7:44 PM (4 hours ago) 7:44 PM
to Enterprise Policy Reviews, chromium...@chromium.org, Javier Fernandez, chromium-a...@chromium.org, kinuko+...@chromium.org, extension...@chromium.org

Solomon Kinard has uploaded the change for review

Commit message

Extensions: CodeHealth: Update spelling of random words in permission*
Bug: 415304336
Change-Id: I0c97bec7f883fbd0de73e4a21d0b1c23cbae93af

Change diff

diff --git a/extensions/browser/permissions/permissions_updater.h b/extensions/browser/permissions/permissions_updater.h
index 8d2df82..43aa9d1 100644
--- a/extensions/browser/permissions/permissions_updater.h
+++ b/extensions/browser/permissions/permissions_updater.h
@@ -109,7 +109,7 @@
base::OnceClosure completion_callback);

// Removes the `permissions` from `extension` and makes no effort to determine
- // if doing so is safe in the slightlest. This method shouldn't be used,
+ // if doing so is safe in the slightest. This method shouldn't be used,
// except for removing permissions totally blocklisted by management.
void RemovePermissionsUnsafe(const Extension* extension,
const PermissionSet& permissions);
diff --git a/extensions/common/permissions/permission_set.h b/extensions/common/permissions/permission_set.h
index 57cc3ec..d8154fa4 100644
--- a/extensions/common/permissions/permission_set.h
+++ b/extensions/common/permissions/permission_set.h
@@ -87,7 +87,7 @@
bool HasAPIPermission(const std::string& permission_name) const;

// Returns true if the set allows the given permission with the default
- // permission detal.
+ // permission detail.
bool CheckAPIPermission(mojom::APIPermissionID permission) const;

// Returns true if the set allows the given permission and permission param.

Change information

Files:
  • M extensions/browser/permissions/permissions_updater.h
  • M extensions/common/permissions/permission_set.h
Change size: XS
Delta: 2 files changed, 2 insertions(+), 2 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I0c97bec7f883fbd0de73e4a21d0b1c23cbae93af
Gerrit-Change-Number: 7477301
Gerrit-PatchSet: 1
Gerrit-Owner: Solomon Kinard <solomo...@chromium.org>
Gerrit-Reviewer: Solomon Kinard <solomo...@chromium.org>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: Javier Fernandez <jfern...@igalia.com>
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages