[iOS] Fix fade not present when cobrowse input plate is focused [chromium/src : main]

0 views

Skip to first unread message

Radu Nitescu (Gerrit)

unread,

4:26 AM (3 hours ago) 4:26 AM

to Ameur Hosni, Aliona Dangla, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

Attention needed from Aliona Dangla and Ameur Hosni

Radu Nitescu voted

Auto-Submit	+1
Commit-Queue	+1

Open in Gerrit

Related details

Attention is currently required from:

Aliona Dangla
Ameur Hosni

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Ameur Hosni (Gerrit)

unread,

5:29 AM (2 hours ago) 5:29 AM

to Radu Nitescu, Chromium LUCI CQ, Aliona Dangla, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

Attention needed from Aliona Dangla and Radu Nitescu

Ameur Hosni voted

Code-Review	+1
Commit-Queue	+2

Open in Gerrit

Related details

Attention is currently required from:

Aliona Dangla
Radu Nitescu

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

5:35 AM (2 hours ago) 5:35 AM

to Radu Nitescu, Ameur Hosni, Aliona Dangla, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

[iOS] Fix fade not present when cobrowse input plate is focused

The fade should react to keyboard shown.

Bug: 524589108

Change-Id: If58d7c46ba74a35c5096c45e6d8167282d749952

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8071100

Reviewed-by: Ameur Hosni <ameur...@google.com>

Commit-Queue: Ameur Hosni <ameur...@google.com>

Auto-Submit: Radu Nitescu <radun...@google.com>

Cr-Commit-Position: refs/heads/main@{#1660142}

Files:

M ios/chrome/browser/cobrowse/ui/assistant_aim_view_controller.mm

Change size: XS

Delta: 1 file changed, 1 insertion(+), 1 deletion(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Ameur Hosni

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages