net: Remove the test control flags for Net Task Scheduler [chromium/src : main]
0 views
Skip to first unread message
Hayato Ito (Gerrit)
May 31, 2026, 9:53:32 PM (3 hours ago) May 31
to Kenichi Ishibashi, Takashi Toyoshima, Chromium LUCI CQ, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, bnc+...@chromium.org, net-r...@chromium.org
Attention needed from Kenichi Ishibashi and Takashi Toyoshima
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Kenichi Ishibashi
- Takashi Toyoshima
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kenichi Ishibashi (Gerrit)
May 31, 2026, 10:39:32 PM (2 hours ago) May 31
to Hayato Ito, Takashi Toyoshima, Chromium LUCI CQ, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, bnc+...@chromium.org, net-r...@chromium.org
Attention needed from Hayato Ito and Takashi Toyoshima
Kenichi Ishibashi voted and added 1 comment![]( "Open in Gerrit")
Votes added by Kenichi Ishibashi
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Hayato Ito
- Takashi Toyoshima
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hayato Ito (Gerrit)
May 31, 2026, 10:39:45 PM (2 hours ago) May 31
to Kenichi Ishibashi, Takashi Toyoshima, Chromium LUCI CQ, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, bnc+...@chromium.org, net-r...@chromium.org
Attention needed from Takashi Toyoshima
Hayato Ito voted Commit-Queue+2![]( "Open in Gerrit")
Attention is currently required from:
- Takashi Toyoshima
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Takashi Toyoshima (Gerrit)
May 31, 2026, 10:50:04 PM (2 hours ago) May 31
to Hayato Ito, Kenichi Ishibashi, Chromium LUCI CQ, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, bnc+...@chromium.org, net-r...@chromium.org
Attention needed from Hayato Ito
Takashi Toyoshima voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Hayato Ito
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
May 31, 2026, 11:44:37 PM (1 hour ago) May 31
to Hayato Ito, Takashi Toyoshima, Kenichi Ishibashi, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, bnc+...@chromium.org, net-r...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
net: Remove the test control flags for Net Task Scheduler
This is a follow-up for https://crrev.com/c/7843744.
This CL removes the test control flags `kNetTaskSchedulerInTests` and
`kNetTaskSchedulerForceEnableInTests`, as the tests running under the
scheduler have been stable after landing https://crrev.com/c/7843744.
Following this removal:
- NetTaskEnvironment initializes the NetTaskScheduler using only the
`kNetTaskScheduler` feature flag.
- The force-enable test helper logic is removed, simplifying task
environment construction.
- Removes unit tests for these control flags.
Bug: 463794414
Change-Id: I169020eca8eb4f404a28ca835d228136b76e197e
Commit-Queue: Hayato Ito <hay...@chromium.org>
Reviewed-by: Takashi Toyoshima <toyo...@chromium.org>
Reviewed-by: Kenichi Ishibashi <ba...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1639155}
Files:
- M net/base/features.cc
- M net/base/features.h
- M net/test/net_task_environment_unittest.cc
- M net/test/test_with_task_environment.cc
- M net/test/test_with_task_environment_unittest.cc
Change size: M
Delta: 5 files changed, 2 insertions(+), 91 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Kenichi Ishibashi, +1 by Takashi Toyoshima
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages