[omnibox] Remove metadata for omnibox-tab-switch-suggestions flag [chromium/src : main]

Orin Jaworski (Gerrit)

unread,

Jul 1, 2022, 11:47:50 AM7/1/22

to Orin Jaworski, Gang Wu, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Gang Wu, Orin Jaworski.

View Change

1 comment:

Patchset:
- Patch Set #1:
  Hi Gang, I went to clean this flag up after receiving the email notification about its expiration. It sounded like something we launched a long time ago, but this seems like it might be a different one. Any reason to keep it?

To view, visit change 3740951. To unsubscribe, or for help writing mail filters, visit settings.

Gang Wu (Gerrit)

unread,

Jul 2, 2022, 12:40:04 AM7/2/22

to Orin Jaworski, Chromium LUCI CQ, Orin Jaworski, chromium...@chromium.org

Attention is currently required from: Orin Jaworski, Orin Jaworski.

Patch set 1:Code-Review +1

View Change

To view, visit change 3740951. To unsubscribe, or for help writing mail filters, visit settings.

Gang Wu (Gerrit)

unread,

Jul 2, 2022, 12:40:16 AM7/2/22

to Orin Jaworski, Chromium LUCI CQ, Orin Jaworski, chromium...@chromium.org

Attention is currently required from: Orin Jaworski, Orin Jaworski.

Patch set 1:Commit-Queue +2

View Change

To view, visit change 3740951. To unsubscribe, or for help writing mail filters, visit settings.

Chromium LUCI CQ (Gerrit)

unread,

Jul 2, 2022, 12:43:55 AM7/2/22

to Orin Jaworski, Gang Wu, Orin Jaworski, chromium...@chromium.org

Chromium LUCI CQ submitted this change.

View Change

Approvals:
  Gang Wu: Looks good to me; Commit

[omnibox] Remove metadata for omnibox-tab-switch-suggestions flag

Change-Id: Id8a9be7d4ad457b03df35283d4a9d4c44a931fdc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3740951
Commit-Queue: Gang Wu <gan...@chromium.org>
Reviewed-by: Gang Wu <gan...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1020341}
---
M chrome/browser/flag-metadata.json
1 file changed, 13 insertions(+), 5 deletions(-)

diff --git a/chrome/browser/flag-metadata.json b/chrome/browser/flag-metadata.json
index 0a5336f..0cd8572 100644
--- a/chrome/browser/flag-metadata.json
+++ b/chrome/browser/flag-metadata.json
@@ -4754,11 +4754,6 @@
     "expiry_milestone": 92
   },
   {
-    "name": "omnibox-tab-switch-suggestions",
-    "owners": [ "gangwu", "chrome-om...@google.com" ],
-    "expiry_milestone": 104
-  },
-  {
     "name": "omnibox-trending-zero-prefix-suggestions-on-ntp",
     "owners": [ "ender", "stkhapugin", "mahmadi", "chrome-om...@google.com" ],
     "expiry_milestone": 110

To view, visit change 3740951. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward