[Menu] Avoid potential access after self-deletion [chromium/src : main]

0 views
Skip to first unread message

Dana Fried (Gerrit)

unread,
Jul 20, 2026, 12:58:29 PM (yesterday) Jul 20
to TopChrome team GWSQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, roblia...@chromium.org, sky+...@chromium.org
Attention needed from TopChrome team GWSQ

Dana Fried voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • TopChrome team GWSQ
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iccb7c5dba0519e938934dc9da1bf260ad75184d4
Gerrit-Change-Number: 8124974
Gerrit-PatchSet: 1
Gerrit-Owner: Dana Fried <dfr...@chromium.org>
Gerrit-Reviewer: Dana Fried <dfr...@chromium.org>
Gerrit-Reviewer: TopChrome team GWSQ <top-chr...@google.com>
Gerrit-Attention: TopChrome team GWSQ <top-chr...@google.com>
Gerrit-Comment-Date: Mon, 20 Jul 2026 16:58:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

gwsq (Gerrit)

unread,
Jul 20, 2026, 1:00:52 PM (yesterday) Jul 20
to Dana Fried, TopChrome team GWSQ, Steven Luong, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, roblia...@chromium.org, sky+...@chromium.org
Attention needed from Steven Luong

Message from gwsq

Reviewer source(s):
stl...@chromium.org is from context(googleclient/chrome/chromium_gwsq/team/topchrome/config.gwsq)

Open in Gerrit

Related details

Attention is currently required from:
  • Steven Luong
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iccb7c5dba0519e938934dc9da1bf260ad75184d4
Gerrit-Change-Number: 8124974
Gerrit-PatchSet: 1
Gerrit-Owner: Dana Fried <dfr...@chromium.org>
Gerrit-Reviewer: Dana Fried <dfr...@chromium.org>
Gerrit-Reviewer: Steven Luong <stl...@chromium.org>
Gerrit-CC: TopChrome team GWSQ <top-chr...@google.com>
Gerrit-CC: gwsq
Gerrit-Attention: Steven Luong <stl...@chromium.org>
Gerrit-Comment-Date: Mon, 20 Jul 2026 17:00:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Steven Luong (Gerrit)

unread,
Jul 20, 2026, 1:04:24 PM (yesterday) Jul 20
to Dana Fried, TopChrome team GWSQ, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, roblia...@chromium.org, sky+...@chromium.org
Attention needed from Dana Fried

Steven Luong voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Dana Fried
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iccb7c5dba0519e938934dc9da1bf260ad75184d4
    Gerrit-Change-Number: 8124974
    Gerrit-PatchSet: 1
    Gerrit-Owner: Dana Fried <dfr...@chromium.org>
    Gerrit-Reviewer: Dana Fried <dfr...@chromium.org>
    Gerrit-Reviewer: Steven Luong <stl...@chromium.org>
    Gerrit-CC: TopChrome team GWSQ <top-chr...@google.com>
    Gerrit-CC: gwsq
    Gerrit-Attention: Dana Fried <dfr...@chromium.org>
    Gerrit-Comment-Date: Mon, 20 Jul 2026 17:04:13 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Dana Fried (Gerrit)

    unread,
    Jul 20, 2026, 2:42:30 PM (yesterday) Jul 20
    to Steven Luong, TopChrome team GWSQ, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, roblia...@chromium.org, sky+...@chromium.org
    Attention needed from Steven Luong

    Dana Fried voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Steven Luong
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iccb7c5dba0519e938934dc9da1bf260ad75184d4
    Gerrit-Change-Number: 8124974
    Gerrit-PatchSet: 3
    Gerrit-Owner: Dana Fried <dfr...@chromium.org>
    Gerrit-Reviewer: Dana Fried <dfr...@chromium.org>
    Gerrit-Reviewer: Steven Luong <stl...@chromium.org>
    Gerrit-CC: TopChrome team GWSQ <top-chr...@google.com>
    Gerrit-CC: gwsq
    Gerrit-Attention: Steven Luong <stl...@chromium.org>
    Gerrit-Comment-Date: Mon, 20 Jul 2026 18:42:13 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Jul 20, 2026, 4:15:57 PM (yesterday) Jul 20
    to Dana Fried, Steven Luong, TopChrome team GWSQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, roblia...@chromium.org, sky+...@chromium.org

    Chromium LUCI CQ submitted the change with unreviewed changes

    Unreviewed changes

    1 is the latest approved patch-set.
    The change was submitted with unreviewed changes in the following files:

    ```
    The name of the file: ui/views/controls/menu/menu_item_view.cc
    Insertions: 4, Deletions: 4.

    @@ -791,14 +791,14 @@
     }
     
     void MenuItemView::ChildrenChanged() {
    -  const auto controller = GetMenuController()->AsWeakPtr();
    -  if (controller) {
    +  auto* const controller_ptr = GetMenuController();
    +  if (controller_ptr) {
         UpdateEmptyMenusAndMetrics();
     
    -    controller->MenuChildrenChanged(this);
    -
         // Certain accessibility callbacks could destroy the menu indirectly through
         // activation changes.
    +    const auto controller = controller_ptr->AsWeakPtr();
    +    controller->MenuChildrenChanged(this);
         if (!controller) {
           return;
         }
    ```

    Change information

    Commit message:
    [Menu] Avoid potential access after self-deletion
    Fixed: 501637242
    Change-Id: Iccb7c5dba0519e938934dc9da1bf260ad75184d4
    Auto-Submit: Dana Fried <dfr...@chromium.org>
    Reviewed-by: Steven Luong <stl...@chromium.org>
    Commit-Queue: Dana Fried <dfr...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1664888}
    Files:
    • M ui/views/controls/menu/menu_controller.cc
    • M ui/views/controls/menu/menu_item_view.cc
    Change size: S
    Delta: 2 files changed, 13 insertions(+), 3 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Steven Luong
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iccb7c5dba0519e938934dc9da1bf260ad75184d4
    Gerrit-Change-Number: 8124974
    Gerrit-PatchSet: 4
    Gerrit-Owner: Dana Fried <dfr...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Dana Fried <dfr...@chromium.org>
    Gerrit-Reviewer: Steven Luong <stl...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages