[ThemeSync] Skip recreating if the same upload image is selected. [chromium/src : main]
0 views
Skip to first unread message
Xi Han (Gerrit)
2:33 PM (4 hours ago) 2:33 PM
to Xinyi Ji, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Xinyi Ji
Xi Han voted and added 1 comment![]( "Open in Gerrit")
Votes added by Xi Han
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Xinyi Ji
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Xinyi Ji (Gerrit)
2:45 PM (4 hours ago) 2:45 PM
to Xi Han, Chromium LUCI CQ, chromium...@chromium.org
Attention is currently required from:
- Xi Han
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Xi Han (Gerrit)
2:58 PM (4 hours ago) 2:58 PM
to Xinyi Ji, Chromium LUCI CQ, chromium...@chromium.org
Xi Han voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
3:10 PM (3 hours ago) 3:10 PM
to Xi Han, Xinyi Ji, chromium...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[ThemeSync] Skip recreating if the same upload image is selected.
In this CL, we change the callback that the preview dialog is clicked.
It allows the UploadImagePreviewCoordinator to compare whether the
selected image is the same as the current background NTP theme. We
will skip recreating the activity if the same upload image is
selected. Demo: http://shortn/_ntp9k8VKMv.
Bug: 488439751
Change-Id: I3216c5e132e69df76d2eb360ee395613e3358e16
Reviewed-by: Xinyi Ji <xin...@chromium.org>
Commit-Queue: Xi Han <ha...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1659747}
Files:
- M chrome/browser/ntp_customization/java/src/org/chromium/chrome/browser/ntp_customization/theme/NtpThemeCoordinator.java
- M chrome/browser/ntp_customization/java/src/org/chromium/chrome/browser/ntp_customization/theme/upload_image/UploadImagePreviewCoordinator.java
- M chrome/browser/ntp_customization/junit/src/org/chromium/chrome/browser/ntp_customization/theme/NtpThemeCoordinatorUnitTest.java
- M chrome/browser/ntp_customization/junit/src/org/chromium/chrome/browser/ntp_customization/theme/upload_image/UploadImagePreviewCoordinatorUnitTest.java
Change size: M
Delta: 4 files changed, 112 insertions(+), 31 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Xinyi Ji
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages