[voice_search] Ensure PEPC does not flicker with smaller width windows [chromium/src : main]
Antonio Sartori (Gerrit)
Antonio Sartori added 1 comment![]( "Open in Gerrit")
Looks reasonable to me, but +Thomas for PEPC.
Also, is it possible to test anything here?
Related details
- Elias Klim
- James Leung
- Thomas Nguyen
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Thomas Nguyen (Gerrit)
Thomas Nguyen added 1 comment![]( "Open in Gerrit")
return prompt_bounds;QQ: Do you have any experience running the kNearElement experiment?
I recall that we stopped the kNearElement experiment some time ago and that kWindowMiddle should be the sole option here.
Related details
- Elias Klim
- James Leung
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
James Leung (Gerrit)
James Leung added 2 comments![]( "Open in Gerrit")
Looks reasonable to me, but +Thomas for PEPC.
Also, is it possible to test anything here?
what do you mean by test? are you asking if the ui tests are needed?
return prompt_bounds;QQ: Do you have any experience running the kNearElement experiment?
I recall that we stopped the kNearElement experiment some time ago and that kWindowMiddle should be the sole option here.
nope, i do not; is this something that should not be done? what were the results of the experiment?
Related details
- Antonio Sartori
- Elias Klim
- Thomas Nguyen
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
James Leung (Gerrit)
James Leung added 1 comment![]( "Open in Gerrit")
return prompt_bounds;James LeungQQ: Do you have any experience running the kNearElement experiment?
I recall that we stopped the kNearElement experiment some time ago and that kWindowMiddle should be the sole option here.
nope, i do not; is this something that should not be done? what were the results of the experiment?
tun...@chromium.org are there any thoughts you have on why there might be stutter / re entrancy on smaller windows for PEPC over non-web contents like the omnibox?
if kNearElement is indeed deprecated, should I also delete its code in a CL?
@antonio...@chromium.org any thoughts as well?
Thomas Nguyen (Gerrit)
Thomas Nguyen added 1 comment![]( "Open in Gerrit")
return prompt_bounds;James LeungQQ: Do you have any experience running the kNearElement experiment?
I recall that we stopped the kNearElement experiment some time ago and that kWindowMiddle should be the sole option here.
James Leungnope, i do not; is this something that should not be done? what were the results of the experiment?
tun...@chromium.org are there any thoughts you have on why there might be stutter / re entrancy on smaller windows for PEPC over non-web contents like the omnibox?
if kNearElement is indeed deprecated, should I also delete its code in a CL?
@antonio...@chromium.org any thoughts as well?
I saw another CL to completely disable the kNearElement trial from Antonio. While I think it might be useful to keep that option in case we want to resume it later, I am also open to removing it. I don't have a strong preference, so whichever approach you prefer works for me.
What I meant is, likely the stutter is not caused by this line and changing here is no-op
Related details
- Antonio Sartori
- Elias Klim
- James Leung
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |