Remove obsolete `is_chromeos_ash` build arg [chromium/src : main]
0 views
Skip to first unread message
Georg Neis (Gerrit)
May 26, 2026, 8:16:57 PM (5 days ago) May 26
to Nico Weber, Chromium LUCI CQ, chromium...@chromium.org, Peter Beverloo, dibyapal+wa...@chromium.org, marinacio...@chromium.org, olka+...@chromium.org, oshima...@chromium.org, translat...@chromium.org
Attention needed from Nico Weber
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Nico Weber
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Georg Neis (Gerrit)
May 28, 2026, 11:00:15 PM (3 days ago) May 28
to Mirko Bonadei, Jerome Jiang, android-bu...@system.gserviceaccount.com, Daniel Cheng, Nico Weber, Chromium LUCI CQ, chromium...@chromium.org, Peter Beverloo, feature-me...@chromium.org, chrome-intell...@chromium.org, amraboelk...@chromium.org, mar...@chromium.org, jz...@chromium.org, fgal...@chromium.org, chrome-intelligence-te...@google.com, dibyapal+wa...@chromium.org, marinacio...@chromium.org, olka+...@chromium.org, oshima...@chromium.org, translat...@chromium.org
Attention needed from Daniel Cheng and Nico Weber
Georg Neis added 1 comment![]( "Open in Gerrit")
File third_party/widevine/cdm/widevine.gni
Line 6, Patchset 12 (Latest):
import("//build/config/chromeos/args.gni")Georg Neis . unresolved
For is_chromeos_device
Related details
Attention is currently required from:
- Daniel Cheng
- Nico Weber
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Georg Neis (Gerrit)
May 28, 2026, 11:01:55 PM (3 days ago) May 28
to Henrik Andreasson, Mirko Bonadei, Jerome Jiang, android-bu...@system.gserviceaccount.com, Daniel Cheng, Nico Weber, Chromium LUCI CQ, chromium...@chromium.org, Peter Beverloo, feature-me...@chromium.org, chrome-intell...@chromium.org, amraboelk...@chromium.org, mar...@chromium.org, jz...@chromium.org, fgal...@chromium.org, chrome-intelligence-te...@google.com, dibyapal+wa...@chromium.org, marinacio...@chromium.org, olka+...@chromium.org, oshima...@chromium.org, translat...@chromium.org
Attention needed from Daniel Cheng, Henrik Andreasson and Nico Weber
Georg Neis added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 12 (Latest):
Georg Neis . unresolved
Sorry, something went wrong here when rebasing. Setting to WIP
Related details
Attention is currently required from:
- Daniel Cheng
- Henrik Andreasson
- Nico Weber
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Georg Neis (Gerrit)
May 28, 2026, 11:53:18 PM (3 days ago) May 28
to Mirko Bonadei, Jerome Jiang, android-bu...@system.gserviceaccount.com, Daniel Cheng, Nico Weber, Chromium LUCI CQ, chromium...@chromium.org, Peter Beverloo, feature-me...@chromium.org, chrome-intell...@chromium.org, amraboelk...@chromium.org, mar...@chromium.org, jz...@chromium.org, fgal...@chromium.org, chrome-intelligence-te...@google.com, dibyapal+wa...@chromium.org, marinacio...@chromium.org, olka+...@chromium.org, oshima...@chromium.org, translat...@chromium.org
Attention needed from Daniel Cheng and Nico Weber
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Daniel Cheng
- Nico Weber
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Georg Neis (Gerrit)
May 28, 2026, 11:53:28 PM (3 days ago) May 28
to Mirko Bonadei, Jerome Jiang, android-bu...@system.gserviceaccount.com, Daniel Cheng, Nico Weber, Chromium LUCI CQ, chromium...@chromium.org, Peter Beverloo, feature-me...@chromium.org, chrome-intell...@chromium.org, amraboelk...@chromium.org, mar...@chromium.org, jz...@chromium.org, fgal...@chromium.org, chrome-intelligence-te...@google.com, dibyapal+wa...@chromium.org, marinacio...@chromium.org, olka+...@chromium.org, oshima...@chromium.org, translat...@chromium.org
Attention needed from Daniel Cheng and Nico Weber
Georg Neis added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Sorry, something went wrong here when rebasing. Setting to WIP
Georg Neis
Done
Georg Neis (Gerrit)
May 29, 2026, 12:02:58 AM (3 days ago) May 29
to Mirko Bonadei, Jerome Jiang, android-bu...@system.gserviceaccount.com, Daniel Cheng, Nico Weber, Chromium LUCI CQ, chromium...@chromium.org, Peter Beverloo, feature-me...@chromium.org, chrome-intell...@chromium.org, amraboelk...@chromium.org, mar...@chromium.org, jz...@chromium.org, fgal...@chromium.org, chrome-intelligence-te...@google.com, dibyapal+wa...@chromium.org, marinacio...@chromium.org, olka+...@chromium.org, oshima...@chromium.org, translat...@chromium.org
Attention needed from Daniel Cheng and Nico Weber
Georg Neis voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Daniel Cheng (Gerrit)
May 29, 2026, 2:18:19 AM (3 days ago) May 29
to Georg Neis, Daniel Cheng, Mirko Bonadei, Jerome Jiang, android-bu...@system.gserviceaccount.com, Nico Weber, Chromium LUCI CQ, chromium...@chromium.org, Peter Beverloo, feature-me...@chromium.org, chrome-intell...@chromium.org, amraboelk...@chromium.org, mar...@chromium.org, jz...@chromium.org, fgal...@chromium.org, chrome-intelligence-te...@google.com, dibyapal+wa...@chromium.org, marinacio...@chromium.org, olka+...@chromium.org, oshima...@chromium.org, translat...@chromium.org
Attention needed from Georg Neis and Nico Weber
Daniel Cheng voted and added 2 comments![]( "Open in Gerrit")
Votes added by Daniel Cheng
| Code-Review | +1 |
| Owners-Override | +1 |
2 comments
Patchset-level comments
File third_party/widevine/cdm/widevine.gni
Line 6, Patchset 12:
import("//build/config/chromeos/args.gni")Georg Neis . resolved
Daniel ChengFor is_chromeos_device
Acknowledged
Related details
Attention is currently required from:
- Georg Neis
- Nico Weber
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniel Cheng (Gerrit)
May 29, 2026, 2:18:34 AM (3 days ago) May 29
to Georg Neis, Daniel Cheng, Mirko Bonadei, Jerome Jiang, android-bu...@system.gserviceaccount.com, Nico Weber, Chromium LUCI CQ, chromium...@chromium.org, Peter Beverloo, feature-me...@chromium.org, chrome-intell...@chromium.org, amraboelk...@chromium.org, mar...@chromium.org, jz...@chromium.org, fgal...@chromium.org, chrome-intelligence-te...@google.com, dibyapal+wa...@chromium.org, marinacio...@chromium.org, olka+...@chromium.org, oshima...@chromium.org, translat...@chromium.org
Attention needed from Georg Neis and Nico Weber
Daniel Cheng voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Georg Neis (Gerrit)
May 29, 2026, 2:20:00 AM (3 days ago) May 29
to Daniel Cheng, Mirko Bonadei, Jerome Jiang, android-bu...@system.gserviceaccount.com, Nico Weber, Chromium LUCI CQ, chromium...@chromium.org, Peter Beverloo, feature-me...@chromium.org, chrome-intell...@chromium.org, amraboelk...@chromium.org, mar...@chromium.org, jz...@chromium.org, fgal...@chromium.org, chrome-intelligence-te...@google.com, dibyapal+wa...@chromium.org, marinacio...@chromium.org, olka+...@chromium.org, oshima...@chromium.org, translat...@chromium.org
Attention needed from Nico Weber
Georg Neis voted and added 1 comment![]( "Open in Gerrit")
Votes added by Georg Neis
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Attention is currently required from:
- Nico Weber
Nico Weber (Gerrit)
May 29, 2026, 9:38:43 AM (3 days ago) May 29
to Georg Neis, Nico Weber, Daniel Cheng, Mirko Bonadei, Jerome Jiang, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Peter Beverloo, feature-me...@chromium.org, chrome-intell...@chromium.org, amraboelk...@chromium.org, mar...@chromium.org, jz...@chromium.org, fgal...@chromium.org, chrome-intelligence-te...@google.com, dibyapal+wa...@chromium.org, marinacio...@chromium.org, olka+...@chromium.org, oshima...@chromium.org, translat...@chromium.org
Attention needed from Georg Neis
Nico Weber voted and added 3 comments![]( "Open in Gerrit")
Votes added by Nico Weber
| Code-Review | +1 |
3 comments
Patchset-level comments
File PRESUBMIT.py
Line 7644, Patchset 15 (Parent):
For a transition period, assert(is_chromeos_ash) is also accepted.Nico Weber . resolved
(if you remove this change from this cl, it's more likely to stick)
File third_party/polymer/v3_0/BUILD.gn
Line 217, Patchset 15 (Parent):
# launches.Nico Weber . unresolved
Should we keep the " Remove once CrOS Print Preview launches." comment?
Related details
Attention is currently required from:
- Georg Neis
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Georg Neis (Gerrit)
May 31, 2026, 9:53:00 PM (3 hours ago) May 31
to Nico Weber, Daniel Cheng, Mirko Bonadei, Jerome Jiang, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Peter Beverloo, feature-me...@chromium.org, chrome-intell...@chromium.org, amraboelk...@chromium.org, mar...@chromium.org, jz...@chromium.org, fgal...@chromium.org, chrome-intelligence-te...@google.com, dibyapal+wa...@chromium.org, marinacio...@chromium.org, olka+...@chromium.org, oshima...@chromium.org, translat...@chromium.org
Georg Neis voted and added 1 comment![]( "Open in Gerrit")
Votes added by Georg Neis
| Auto-Submit | +1 |
| Commit-Queue | +2 |
1 comment
File third_party/polymer/v3_0/BUILD.gn
Line 217, Patchset 15 (Parent):
# launches.Nico Weber . resolved
Should we keep the " Remove once CrOS Print Preview launches." comment?
Georg Neis
I think that's dead too. (https://b.corp.google.com/issues/323421684)
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Georg Neis (Gerrit)
May 31, 2026, 10:06:39 PM (3 hours ago) May 31
to Nico Weber, Daniel Cheng, Mirko Bonadei, Jerome Jiang, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Peter Beverloo, feature-me...@chromium.org, chrome-intell...@chromium.org, amraboelk...@chromium.org, mar...@chromium.org, jz...@chromium.org, fgal...@chromium.org, chrome-intelligence-te...@google.com, dibyapal+wa...@chromium.org, marinacio...@chromium.org, olka+...@chromium.org, oshima...@chromium.org, translat...@chromium.org
Georg Neis voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Georg Neis (Gerrit)
May 31, 2026, 10:52:38 PM (2 hours ago) May 31
to Nico Weber, Daniel Cheng, Mirko Bonadei, Jerome Jiang, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Peter Beverloo, feature-me...@chromium.org, chrome-intell...@chromium.org, amraboelk...@chromium.org, mar...@chromium.org, jz...@chromium.org, fgal...@chromium.org, chrome-intelligence-te...@google.com, dibyapal+wa...@chromium.org, marinacio...@chromium.org, olka+...@chromium.org, oshima...@chromium.org, translat...@chromium.org
Reply all
Reply to author
Forward
0 new messages