[WebMIDI] Sync ChildProcessSecurityPolicy with DevTools overrides [chromium/src : main]
0 views
Skip to first unread message
Hongchan Choi (Gerrit)
May 27, 2026, 8:29:36 PM (4 days ago) May 27
to Takashi Toyoshima, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, toyosh...@chromium.org
Attention needed from Takashi Toyoshima
Hongchan Choi added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Hongchan Choi . resolved
toyoshim@ Could you take a look at the general direction of this patch?
(I am not super familiar with this code base, so this work is assisted by AI)
Related details
Attention is currently required from:
- Takashi Toyoshima
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Takashi Toyoshima (Gerrit)
May 27, 2026, 10:27:43 PM (4 days ago) May 27
to Hongchan Choi, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, toyosh...@chromium.org
Attention needed from Hongchan Choi
Takashi Toyoshima voted and added 1 comment![]( "Open in Gerrit")
Votes added by Takashi Toyoshima
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Hongchan Choi
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hongchan Choi (Gerrit)
May 28, 2026, 9:50:26 AM (4 days ago) May 28
to Takashi Toyoshima, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, toyosh...@chromium.org
Hongchan Choi voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
May 28, 2026, 9:54:07 AM (4 days ago) May 28
to Hongchan Choi, Takashi Toyoshima, chromium...@chromium.org, feature-me...@chromium.org, toyosh...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[WebMIDI] Sync ChildProcessSecurityPolicy with DevTools overrides
DevTools permission overrides only update PermissionController but
fail to update ChildProcessSecurityPolicy for the renderer process.
This creates a capability mismatch when Headless/Automation tests
grant MIDI permissions via CDP, but subsequent SysEx actions are
rejected by MidiHost checks on the IO thread.
This patch resolves the issue by:
- Introducing a `BindMidiSessionProvider` helper on the UI thread.
- Intercepting MidiSessionProvider Mojo bindings to check the frame's
overridden permission status via PermissionController.
- Dynamically calling GrantSendMidiMessage and/or
GrantSendMidiSysExMessage on ChildProcessSecurityPolicyImpl to
authorize the process.
- Post-forwarding the Mojo binding to MidiHost on the IO thread.
Bug: 40793528
Test: MidiBrowserTestWithPermissionOverride.RequestMIDIAccessWithSysexOverride
Change-Id: I6c90787e9218923d12742fbb6106f1aae7cb9a91
Commit-Queue: Hongchan Choi <hong...@chromium.org>
Reviewed-by: Takashi Toyoshima <toyo...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1637676}
Files:
- M content/browser/browser_interface_binders.cc
- M content/browser/media/midi_browsertest.cc
- M content/test/content_test_bundle_data.filelist
- A content/test/data/midi/request_midi_sysex_access.html
Change size: M
Delta: 4 files changed, 128 insertions(+), 4 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Takashi Toyoshima
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tommy Nyquist (Gerrit)
May 28, 2026, 7:27:26 PM (3 days ago) May 28
to Chromium LUCI CQ, Hongchan Choi, Takashi Toyoshima, chromium...@chromium.org, feature-me...@chromium.org, toyosh...@chromium.org
Tommy Nyquist has created a revert of this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hongchan Choi (Gerrit)
May 29, 2026, 3:03:58 PM (2 days ago) May 29
to Takashi Toyoshima, chromium...@chromium.org, feature-me...@chromium.org, toyosh...@chromium.org
Attention needed from Takashi Toyoshima
Hongchan Choi voted and added 2 comments![]( "Open in Gerrit")
Votes added by Hongchan Choi
| Commit-Queue | +1 |
2 comments
Patchset-level comments
Hongchan Choi . resolved
PTAL
Re-uploading the patch to address the Android Automotive CI failure on the previous CL (https://crrev.com/c/7879619).
Since system MIDI is not available on Android test emulators, I've updated the browser test to use GTEST_SKIP() on devices/emulators without MIDI support, matching standard WebMIDI test behavior.
File content/browser/media/midi_browsertest.cc
Line 175, Patchset 1 (Latest):
#if BUILDFLAG(IS_ANDROID)
if (!midi::HasSystemFeatureMidiForTesting()) {
GTEST_SKIP() << "MIDI service is not available on this device.";
}
#endif // BUILDFLAG(IS_ANDROID)Hongchan Choi . resolved
This is what we missed.
Related details
Attention is currently required from:
- Takashi Toyoshima
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Takashi Toyoshima (Gerrit)
May 31, 2026, 10:54:07 PM (2 hours ago) May 31
to Hongchan Choi, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, toyosh...@chromium.org
Attention needed from Hongchan Choi
Takashi Toyoshima voted and added 2 comments![]( "Open in Gerrit")
Votes added by Takashi Toyoshima
| Code-Review | +1 |
2 comments
File content/browser/browser_interface_binders.cc
Line 30, Patchset 1 (Latest):
#include "content/browser/child_process_security_policy_impl.h"Takashi Toyoshima . unresolved
include order is slightly broken here, maybe after the line 33.
File content/browser/media/midi_browsertest.cc
Line 16, Patchset 1 (Latest):
#include "content/browser/child_process_security_policy_impl.h"
#include "content/browser/permissions/permission_controller_impl.h"
#include "third_party/blink/public/common/permissions/permission_utils.h"
#include "url/origin.h"Takashi Toyoshima . unresolved
include order seems broken. `cl format`?
Related details
Attention is currently required from:
- Hongchan Choi
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages