Fix missing authentication and transport info in proto converter [chromium/src : main]

0 views

Skip to first unread message

Joe Downing (Gerrit)

unread,

Aug 1, 2026, 2:24:57 PM (17 hours ago) Aug 1

to Yuwei Huang, April Zhou, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org

Attention needed from Yuwei Huang

Joe Downing voted and added 1 comment

Votes added by Joe Downing

Auto-Submit	+1
Commit-Queue	+1

1 comment

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Joe Downing . resolved

PTAL!

Open in Gerrit

Related details

Attention is currently required from:

Yuwei Huang

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Yuwei Huang (Gerrit)

unread,

Aug 1, 2026, 11:51:19 PM (8 hours ago) Aug 1

to Joe Downing, April Zhou, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org

Attention needed from Joe Downing

Yuwei Huang voted and added 2 comments

Votes added by Yuwei Huang

Code-Review

2 comments

File remoting/signaling/jingle_message_proto_converter.cc

Line 173, Patchset 5 (Latest): return false;

Yuwei Huang . unresolved

Failing the entire `JingleMessage` parsing because of a single malformed ICE candidate might be too strict. If a peer sends one bad candidate among several good ones, returning `false` here drops the whole message. Consider logging the error and using `continue;` to skip the invalid candidate instead.

Line 187, Patchset 5 (Latest): return false;

Yuwei Huang . unresolved

Similar to above, if candidate parsing fails, consider skipping this candidate with `continue;` rather than returning `false`. This makes the signaling more resilient to malformed candidate strings and matches how WebRTC typically handles ICE candidates.