Support closest-corner/farthest-corner in clip-path circle()/ellipse() [chromium/src : main]

0 views

Skip to first unread message

Hyowon Kim (Gerrit)

unread,

2:27 AM (9 hours ago) 2:27 AM

to Daniil Sakhapov, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, Menard, Alexis, android-bu...@system.gserviceaccount.com, apavlo...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org

Attention needed from Daniil Sakhapov

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:

Daniil Sakhapov

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Daniil Sakhapov (Gerrit)

unread,

4:51 AM (7 hours ago) 4:51 AM

to Hyowon Kim, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, Menard, Alexis, android-bu...@system.gserviceaccount.com, apavlo...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org

Attention needed from Hyowon Kim

Daniil Sakhapov added 2 comments

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Daniil Sakhapov . unresolved

I think we need a feature flag for this one

File third_party/blink/renderer/core/style/basic_shapes.cc

Line 109, Patchset 4 (Latest):

float CornerDistance(const gfx::PointF& center,
                     const gfx::SizeF& box_size,
                     bool closest) {
  const gfx::RectF rect(box_size);
  const std::array<gfx::PointF, 4> corners = {
      rect.origin(), rect.top_right(), rect.bottom_right(), rect.bottom_left()};

  float distance = (center - corners[0]).Length();
  for (unsigned i = 1; i < std::size(corners); ++i) {
    float new_distance = (center - corners[i]).Length();
    if (closest ? new_distance < distance : new_distance > distance) {
      distance = new_distance;
    }
  }
  return distance;
}

Daniil Sakhapov . unresolved

looking at - https://drafts.csswg.org/css-images-3/#valdef-radial-extent-closest-corner - it seems to be wrong for the circle()/ellipse() case?