Blink WPT: stabilize text-combine-upright reftests [chromium/src : main]
Yoav Weiss (@Shopify) (Gerrit)
Yoav Weiss (@Shopify) added 1 comment![]( "Open in Gerrit")
<html class="reftest-wait">Where are the .reftest-wait styles defined?
Related details
- Helmut Januschka
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Helmut Januschka (Gerrit)
Helmut Januschka added 1 comment![]( "Open in Gerrit")
Where are the .reftest-wait styles defined?
`.reftest-wait` was wrong used here, now added `/common/reftest-wait.js` and call `takeScreenshot()`. Also switched the readiness logic to `Promise.all([xxx])`, then force a layout flush before snapshotting, to make the timing explicit and deterministic, tested on 10k runs with 0% errors 🤗,i'd expect this to solve the flake
Related details
- Yoav Weiss (@Shopify)
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yoav Weiss (@Shopify) (Gerrit)
Yoav Weiss (@Shopify) added 1 comment![]( "Open in Gerrit")
<html class="reftest-wait">Helmut JanuschkaWhere are the .reftest-wait styles defined?
`.reftest-wait` was wrong used here, now added `/common/reftest-wait.js` and call `takeScreenshot()`. Also switched the readiness logic to `Promise.all([xxx])`, then force a layout flush before snapshotting, to make the timing explicit and deterministic, tested on 10k runs with 0% errors 🤗,i'd expect this to solve the flake
It's still unclear to me what makes the `reftest-wait` class (and its removal) meaningful. Is it supposed to be set to `display: none` or something similar?
Related details
- Helmut Januschka
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Helmut Januschka (Gerrit)
Helmut Januschka added 1 comment![]( "Open in Gerrit")
<html class="reftest-wait">Helmut JanuschkaWhere are the .reftest-wait styles defined?
Yoav Weiss (@Shopify)`.reftest-wait` was wrong used here, now added `/common/reftest-wait.js` and call `takeScreenshot()`. Also switched the readiness logic to `Promise.all([xxx])`, then force a layout flush before snapshotting, to make the timing explicit and deterministic, tested on 10k runs with 0% errors 🤗,i'd expect this to solve the flake
It's still unclear to me what makes the `reftest-wait` class (and its removal) meaningful. Is it supposed to be set to `display: none` or something similar?
The runner delays screenshot while `<html class="reftest-wait">` is present, and takes it when script removes the class (via `takeScreenshot()`).
So no `.reftest-wait { ... }` style is expected.
follows the same existing pattern used in other reference files, e.g. `third_party/dawn/webgpu-cts/webtests/web_platform/reftests/ref/canvas_image_rendering-ref.html`, which is a `-ref.html` with `class="reftest-wait"` and helper-triggered screenshot, without any `.reftest-wait` CSS style.
the current tests (in PS4) dont do any remove anymore
Related details
- Yoav Weiss (@Shopify)
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yoav Weiss (@Shopify) (Gerrit)
Yoav Weiss (@Shopify) added 2 comments![]( "Open in Gerrit")
crbug.com/407751287 http/tests/devtools/a11y-axe-core/performance/performance-pane-a11y-test.js [ Failure Pass ]Why these expected failures?
<html class="reftest-wait">Can you add a comment pointing to https://web-platform-tests.org/writing-tests/reftests.html#controlling-when-comparison-occurs ? It was really unclear to me that this is magically causing reftests to wait (rather than something that has CSS applied to it that did the same)
Related details
- Helmut Januschka
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Helmut Januschka (Gerrit)
Helmut Januschka added 2 comments![]( "Open in Gerrit")
crbug.com/407751287 http/tests/devtools/a11y-axe-core/performance/performance-pane-a11y-test.js [ Failure Pass ]Helmut JanuschkaWhy these expected failures?
slipped in with rebase, reverted, sorry.
Can you add a comment pointing to https://web-platform-tests.org/writing-tests/reftests.html#controlling-when-comparison-occurs ? It was really unclear to me that this is magically causing reftests to wait (rather than something that has CSS applied to it that did the same)
- Yoav Weiss (@Shopify)
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yoav Weiss (@Shopify) (Gerrit)
Yoav Weiss (@Shopify) voted and added 6 comments![]( "Open in Gerrit")
Votes added by Yoav Weiss (@Shopify)
| Code-Review | +1 |
LGTM % missing comments
<html class="reftest-wait">Add a comment here as well?
<html class="reftest-wait">Add a comment here as well?
<html class="reftest-wait">Add a comment here as well?
<html class="reftest-wait">Add a comment here as well?
<html class="reftest-wait">Add a comment here as well?
Related details
- Helmut Januschka
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Helmut Januschka (Gerrit)
Helmut Januschka voted and added 5 comments![]( "Open in Gerrit")
Votes added by Helmut Januschka
| Auto-Submit | +1 |
5 comments
Add a comment here as well?
Done
Add a comment here as well?
Done
Add a comment here as well?
Done
Add a comment here as well?
Done
Add a comment here as well?
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Helmut Januschka (Gerrit)
Helmut Januschka voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/59139.
When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.
WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process
Related details
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
6 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: third_party/blink/web_tests/external/wpt/css/css-ruby/ruby-text-combine-upright-001b.html
Insertions: 2, Deletions: 0.
@@ -1,4 +1,6 @@
<!DOCTYPE html>
+<!-- `reftest-wait` is a reftest harness signal that delays comparison until ready.
+ See https://web-platform-tests.org/writing-tests/reftests.html#controlling-when-comparison-occurs -->
<html class="reftest-wait">
<head>
<meta charset="UTF-8">
```
```
The name of the file: third_party/blink/web_tests/external/wpt/css/css-writing-modes/text-combine-upright-decorations-001.html
Insertions: 2, Deletions: 0.
@@ -1,4 +1,6 @@
<!DOCTYPE html>
+<!-- `reftest-wait` is a reftest harness signal that delays comparison until ready.
+ See https://web-platform-tests.org/writing-tests/reftests.html#controlling-when-comparison-occurs -->
<html class="reftest-wait">
<title>CSS Writing Modes Test: The resulting composition is treated as a signel glyph for decorations</title>
<link rel="help" href="https://drafts.csswg.org/css-writing-modes-3/#text-combine-layout" title="9.1.2. Layout Rules">
```
```
The name of the file: third_party/blink/web_tests/external/wpt/css/css-ruby/ruby-text-combine-upright-002b.html
Insertions: 2, Deletions: 0.
@@ -1,4 +1,6 @@
<!DOCTYPE html>
+<!-- `reftest-wait` is a reftest harness signal that delays comparison until ready.
+ See https://web-platform-tests.org/writing-tests/reftests.html#controlling-when-comparison-occurs -->
<html class="reftest-wait">
<head>
<meta charset="UTF-8">
```
```
The name of the file: third_party/blink/web_tests/external/wpt/css/css-writing-modes/reference/text-combine-upright-decorations-001.html
Insertions: 2, Deletions: 0.
@@ -1,4 +1,6 @@
<!DOCTYPE html>
+<!-- `reftest-wait` is a reftest harness signal that delays comparison until ready.
+ See https://web-platform-tests.org/writing-tests/reftests.html#controlling-when-comparison-occurs -->
<html class="reftest-wait">
<title>CSS Writing Modes Test: The resulting composition is treated as a signel glyph for decorations</title>
<meta name="flags" content="ahem">
```
```
The name of the file: third_party/blink/web_tests/external/wpt/css/css-ruby/ruby-text-combine-upright-002a.html
Insertions: 2, Deletions: 0.
@@ -1,4 +1,6 @@
<!DOCTYPE html>
+<!-- `reftest-wait` is a reftest harness signal that delays comparison until ready.
+ See https://web-platform-tests.org/writing-tests/reftests.html#controlling-when-comparison-occurs -->
<html class="reftest-wait">
<head>
<meta charset="UTF-8">
```
Change information
Blink WPT: stabilize text-combine-upright reftests
Wait for Ahem before taking reftest snapshots in css-ruby and
css-writing-modes text-combine-upright tests. This avoids fallback-font
first layout differences and makes snapshots deterministic.
Remove temporary Linux Failure Pass expectations now that these tests
are stable again.
- M third_party/blink/web_tests/external/wpt/css/css-ruby/ruby-text-combine-upright-001-ref.html
- M third_party/blink/web_tests/external/wpt/css/css-ruby/ruby-text-combine-upright-001a.html
- M third_party/blink/web_tests/external/wpt/css/css-ruby/ruby-text-combine-upright-001b.html
- M third_party/blink/web_tests/external/wpt/css/css-ruby/ruby-text-combine-upright-002-ref.html
- M third_party/blink/web_tests/external/wpt/css/css-ruby/ruby-text-combine-upright-002a.html
- M third_party/blink/web_tests/external/wpt/css/css-ruby/ruby-text-combine-upright-002b.html
- M third_party/blink/web_tests/external/wpt/css/css-writing-modes/reference/text-combine-upright-decorations-001.html
- M third_party/blink/web_tests/external/wpt/css/css-writing-modes/text-combine-upright-decorations-001.html
Code-Review: +1 by Yoav Weiss (@Shopify)
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |