Update GlicButton tooltip when glic panel opens and closes [chromium/src : main]

0 views

Skip to first unread message

Ian Wells (Gerrit)

unread,

12:03 AM (13 hours ago) 12:03 AM

to Chromium LUCI CQ, chromium...@chromium.org, dewitt...@chromium.org

Ian Wells voted and added 2 comments

Votes added by Ian Wells

Commit-Queue

2 comments

File chrome/browser/ui/views/tabs/glic/glic_button.cc

Line 315, Patchset 5 (Parent):

  // Subscribe to changes in state of glic FRE dialog and glic window.
  glic::GlicKeyedService* const service = glic::GlicKeyedService::Get(profile_);
  glic_window_activation_subscription_ =
      service->window_controller().AddWindowActivationChangedCallback(
          base::BindRepeating(&GlicButton::PanelStateChanged,
                              base::Unretained(this)));

Ian Wells . resolved

This is taken care of by GlicButtonController's AddGlobalShowHideCallback subscription

Line 322, Patchset 5 (Parent):

  fre_subscription_ = service->fre_controller().AddWebUiStateChangedCallback(
      base::BindRepeating(&GlicButton::OnFreWebUiStateChanged,
                          base::Unretained(this)));

Ian Wells . resolved

Moved to GlicButtonController

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages