Jianlin Qiu (Gerrit)

unread,

Aug 5, 2025, 1:42:47 AMAug 5

to Yingying Ma, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org, media-wi...@chromium.org

Attention needed from Yingying Ma

Jianlin Qiu added 3 comments

File media/gpu/av1_builder.h

Line 167, Patchset 1 (Latest): int interpolation_filter = 0;

Jianlin Qiu . unresolved

```suggestion
  libgav1::InterpoltionFilter interpolation_filter = 0;
```

File media/gpu/windows/d3d12_video_encode_av1_delegate.cc

Line 476, Patchset 1 (Latest): constexpr std::array kInterpolationFilters = {

Jianlin Qiu . unresolved

static constexpr ...

Line 488, Patchset 1 (Latest):

  if (interpolation_filter_it == kInterpolationFilters.end()) {
    return {EncoderStatus::Codes::kEncoderInitializationError,
            "No interpolation filters available."};
  }

Jianlin Qiu . unresolved

Besides this, a driver claiming supporting SWITCHABLE must support either of the three eight-tap filters(regular/smooth/sharp). You may check that here.

Open in Gerrit

Related details

Attention is currently required from:

Yingying Ma

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Yingying Ma (Gerrit)

unread,

Aug 5, 2025, 10:50:32 PMAug 5

to Jianlin Qiu, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org, media-wi...@chromium.org

Yingying Ma added 3 comments

File media/gpu/av1_builder.h

Line 167, Patchset 1: int interpolation_filter = 0;

Jianlin Qiu . resolved

```suggestion
  libgav1::InterpoltionFilter interpolation_filter = 0;
```

Yingying Ma

Done

File media/gpu/windows/d3d12_video_encode_av1_delegate.cc

Line 476, Patchset 1: constexpr std::array kInterpolationFilters = {

Jianlin Qiu . resolved

static constexpr ...

Yingying Ma

Done

Line 488, Patchset 1: if (interpolation_filter_it == kInterpolationFilters.end()) {


    return {EncoderStatus::Codes::kEncoderInitializationError,
            "No interpolation filters available."};
  }

Jianlin Qiu . resolved

Besides this, a driver claiming supporting SWITCHABLE must support either of the three eight-tap filters(regular/smooth/sharp). You may check that here.

Yingying Ma

Done

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Jianlin Qiu (Gerrit)

unread,

Aug 6, 2025, 5:20:35 AMAug 6

to Yingying Ma, Eugene Zemtsov, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org, media-wi...@chromium.org

Attention needed from Eugene Zemtsov and Yingying Ma

Jianlin Qiu added 1 comment

File media/gpu/windows/d3d12_video_encode_av1_delegate.cc

Line 539, Patchset 3 (Latest):

  auto interpolation_filter_it =
      std::ranges::find_if(kInterpolationFilters, [this](int filter) {
        return config_support_limit_.SupportedInterpolationFilters &
               (1u << filter);
      });

Jianlin Qiu . unresolved

include <algorithm> following IWYU rule.

Open in Gerrit

Related details

Attention is currently required from:

Eugene Zemtsov
Yingying Ma

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Yingying Ma (Gerrit)

unread,

Aug 7, 2025, 5:00:43 AMAug 7

to Eugene Zemtsov, Jianlin Qiu, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org, media-wi...@chromium.org

Attention needed from Eugene Zemtsov

Yingying Ma added 1 comment

File media/gpu/windows/d3d12_video_encode_av1_delegate.cc

Line 539, Patchset 3: auto interpolation_filter_it =


      std::ranges::find_if(kInterpolationFilters, [this](int filter) {
        return config_support_limit_.SupportedInterpolationFilters &
               (1u << filter);
      });

Jianlin Qiu . resolved

include <algorithm> following IWYU rule.

Yingying Ma

Done

Open in Gerrit

Related details

Attention is currently required from:

Eugene Zemtsov

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Eugene Zemtsov (Gerrit)

unread,

Aug 12, 2025, 8:48:39 PMAug 12

to Yingying Ma, Eugene Zemtsov, Jianlin Qiu, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org, media-wi...@chromium.org

Attention needed from Yingying Ma

Eugene Zemtsov added 1 comment

File media/gpu/windows/d3d12_video_encode_av1_delegate.cc

Line 717, Patchset 4 (Latest):

  for (int i = D3D12_VIDEO_ENCODER_AV1_INTERPOLATION_FILTERS_EIGHTTAP;
       i <= D3D12_VIDEO_ENCODER_AV1_INTERPOLATION_FILTERS_SWITCHABLE; i++) {
    if (config_support_limit_.SupportedInterpolationFilters & (1u << i)) {
      picture_params_.InterpolationFilter =
          static_cast<D3D12_VIDEO_ENCODER_AV1_INTERPOLATION_FILTERS>(i);
      break;
    }
  }

Eugene Zemtsov . unresolved

do we need to do this for every frame? maybe we can do it once and save the result

Open in Gerrit

Related details

Attention is currently required from:

Yingying Ma

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Yingying Ma (Gerrit)

unread,

Aug 14, 2025, 10:53:01 PMAug 14

to Eugene Zemtsov, Jianlin Qiu, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org, media-wi...@chromium.org

Attention needed from Eugene Zemtsov

Yingying Ma voted and added 1 comment

Votes added by Yingying Ma

Commit-Queue

+1

1 comment

File media/gpu/windows/d3d12_video_encode_av1_delegate.cc

Line 717, Patchset 4: for (int i = D3D12_VIDEO_ENCODER_AV1_INTERPOLATION_FILTERS_EIGHTTAP;


       i <= D3D12_VIDEO_ENCODER_AV1_INTERPOLATION_FILTERS_SWITCHABLE; i++) {
    if (config_support_limit_.SupportedInterpolationFilters & (1u << i)) {
      picture_params_.InterpolationFilter =
          static_cast<D3D12_VIDEO_ENCODER_AV1_INTERPOLATION_FILTERS>(i);
      break;
    }
  }

Eugene Zemtsov . resolved

do we need to do this for every frame? maybe we can do it once and save the result

Yingying Ma

Done

Open in Gerrit

Related details

Attention is currently required from:

Eugene Zemtsov

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Eugene Zemtsov (Gerrit)

unread,

Aug 22, 2025, 3:47:56 AMAug 22

to Yingying Ma, Eugene Zemtsov, Jianlin Qiu, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org, media-wi...@chromium.org

Attention needed from Yingying Ma

Eugene Zemtsov added 1 comment

File media/gpu/windows/d3d12_video_encode_av1_delegate.cc

Line 446, Patchset 8 (Latest):

        [](base::span<const D3D12_VIDEO_ENCODER_AV1_RESTORATION_SUPPORT_FLAGS>
               supported_per_type) {

Eugene Zemtsov . unresolved

this lambda doesn't capture anything. can it be a separate helper function?

Open in Gerrit

Related details

Attention is currently required from:

Yingying Ma

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Przemek Dalidowicz (Gerrit)

unread,

Aug 25, 2025, 11:08:05 PM (12 days ago) Aug 25

to Yingying Ma, Eugene Zemtsov, Jianlin Qiu, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org, media-wi...@chromium.org

Attention needed from Yingying Ma

Przemek Dalidowicz added 1 comment

Patchset-level comments

File-level comment, Patchset 9 (Latest):

Przemek Dalidowicz . resolved

Fr

Open in Gerrit

Related details

Attention is currently required from:

Yingying Ma

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Yingying Ma (Gerrit)

unread,

Aug 25, 2025, 11:09:16 PM (12 days ago) Aug 25

to Przemek Dalidowicz, Eugene Zemtsov, Jianlin Qiu, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org, media-wi...@chromium.org

Attention needed from Eugene Zemtsov

Yingying Ma added 1 comment

File media/gpu/windows/d3d12_video_encode_av1_delegate.cc

Line 446, Patchset 8:

        [](base::span<const D3D12_VIDEO_ENCODER_AV1_RESTORATION_SUPPORT_FLAGS>
               supported_per_type) {

Eugene Zemtsov . resolved

this lambda doesn't capture anything. can it be a separate helper function?

Yingying Ma

Done

Open in Gerrit

Related details

Attention is currently required from:

Eugene Zemtsov

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Eugene Zemtsov (Gerrit)

unread,

Sep 4, 2025, 8:58:18 PM (2 days ago) Sep 4

to Yingying Ma, Eugene Zemtsov, Przemek Dalidowicz, Jianlin Qiu, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org, media-wi...@chromium.org

Attention needed from Yingying Ma

Eugene Zemtsov voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Yingying Ma

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Yingying Ma (Gerrit)

unread,

Sep 4, 2025, 10:24:11 PM (2 days ago) Sep 4

to Eugene Zemtsov, Przemek Dalidowicz, Jianlin Qiu, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org, media-wi...@chromium.org

Yingying Ma voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Sep 4, 2025, 11:16:38 PM (2 days ago) Sep 4

to Yingying Ma, Eugene Zemtsov, Przemek Dalidowicz, Jianlin Qiu, AyeAye, chromium...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org, media-wi...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

[D3D12, AV1]Set interpolation filter as indicated by driver

1. Select an appropriate interpolation filter according to the
capabilities reported by d3d12 driver.

2. This CL also calculates these params such as interpolation filter,
loop restoration and tx_mode once during initialization and will not
update during encoding.

Bug: 40275246

Change-Id: I6f756e72bb71de03236ec99c5e8cbad6581c3894

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6816829

Commit-Queue: Yingying Ma <yingy...@intel.com>

Reviewed-by: Eugene Zemtsov <eug...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1511292}

Files:

M media/gpu/av1_builder.cc
M media/gpu/av1_builder.h
M media/gpu/windows/d3d12_video_encode_av1_delegate.cc
M media/gpu/windows/d3d12_video_encode_av1_delegate.h
M media/gpu/windows/d3d12_video_encode_av1_delegate_unittest.cc

Change size: L

Delta: 5 files changed, 161 insertions(+), 96 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Eugene Zemtsov

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

[D3D12, AV1]Set interpolation filter as indicated by driver [chromium/src : main]

Jianlin Qiu (Gerrit)

Jianlin Qiu added 3 comments

Related details

Yingying Ma (Gerrit)

Yingying Ma added 3 comments

Related details

Jianlin Qiu (Gerrit)

Jianlin Qiu added 1 comment

Related details

Yingying Ma (Gerrit)

Yingying Ma added 1 comment

Related details

Eugene Zemtsov (Gerrit)

Eugene Zemtsov added 1 comment

Related details

Yingying Ma (Gerrit)

Yingying Ma voted and added 1 comment

Votes added by Yingying Ma

1 comment

Related details

Eugene Zemtsov (Gerrit)

Eugene Zemtsov added 1 comment

Related details

Przemek Dalidowicz (Gerrit)

Przemek Dalidowicz added 1 comment

Related details

Yingying Ma (Gerrit)

Yingying Ma added 1 comment

Related details

Eugene Zemtsov (Gerrit)

Eugene Zemtsov voted Code-Review+1

Related details

Yingying Ma (Gerrit)

Yingying Ma voted Commit-Queue+2

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information