[layout] Partial revert of crrev.com/7268420 [chromium/src : main]
0 views
Skip to first unread message
Ian Kilpatrick (Gerrit)
Jan 9, 2026, 6:21:12 PM (5 days ago) Jan 9
to David Grogan, chromium...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Attention needed from David Grogan
Ian Kilpatrick voted![]( "Open in Gerrit")
| Auto-Submit | +1 |
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- David Grogan
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Grogan (Gerrit)
Jan 9, 2026, 6:24:33 PM (5 days ago) Jan 9
to Ian Kilpatrick, David Grogan, Chromium LUCI CQ, chromium...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Attention needed from Ian Kilpatrick
David Grogan voted![]( "Open in Gerrit")
Attention is currently required from:
- Ian Kilpatrick
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jan 9, 2026, 8:18:31 PM (5 days ago) Jan 9
to Ian Kilpatrick, David Grogan, chromium...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[layout] Partial revert of crrev.com/7268420
There is the slightest potential for a UBSan Failure - so add the
nullptr check back in so that we don't reach it in:
RemoveOnlyThisLayerAfterStyleChange
This will be re-added in the subsequent patch.
Bug: 469120960
Change-Id: I8d698dd0ba53d1b0c17f8a03bafdad3794219ec9
Auto-Submit: Ian Kilpatrick <ikilp...@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilp...@chromium.org>
Commit-Queue: David Grogan <dgr...@chromium.org>
Reviewed-by: David Grogan <dgr...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1567309}
Files:
- M third_party/blink/renderer/core/layout/layout_box_model_object.cc
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by David Grogan
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Morten Stenshorne (Gerrit)
Jan 12, 2026, 4:08:18 AM (3 days ago) Jan 12
to Chromium LUCI CQ, Ian Kilpatrick, David Grogan, chromium...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Morten Stenshorne added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 3 (Latest):
Morten Stenshorne . resolved
The link in the title is 404.
Here's one that works: https://crrev.com/c/7268420
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ian Kilpatrick (Gerrit)
7:43 PM (4 hours ago) 7:43 PM
to Chromium LUCI CQ, Morten Stenshorne, David Grogan, chromium...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Ian Kilpatrick added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Morten Stenshorne . resolved
The link in the title is 404.
Here's one that works: https://crrev.com/c/7268420
Ian Kilpatrick
sorry 😞
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages