[layout] Partial revert of crrev.com/7268420 [chromium/src : main]

0 views
Skip to first unread message

Ian Kilpatrick (Gerrit)

unread,
Jan 9, 2026, 6:21:12 PM (5 days ago) Jan 9
to David Grogan, chromium...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Attention needed from David Grogan

Ian Kilpatrick voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • David Grogan
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I8d698dd0ba53d1b0c17f8a03bafdad3794219ec9
Gerrit-Change-Number: 7424367
Gerrit-PatchSet: 2
Gerrit-Owner: Ian Kilpatrick <ikilp...@chromium.org>
Gerrit-Reviewer: David Grogan <dgr...@chromium.org>
Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
Gerrit-Attention: David Grogan <dgr...@chromium.org>
Gerrit-Comment-Date: Fri, 09 Jan 2026 23:21:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

David Grogan (Gerrit)

unread,
Jan 9, 2026, 6:24:33 PM (5 days ago) Jan 9
to Ian Kilpatrick, David Grogan, Chromium LUCI CQ, chromium...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Attention needed from Ian Kilpatrick

David Grogan voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Ian Kilpatrick
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I8d698dd0ba53d1b0c17f8a03bafdad3794219ec9
    Gerrit-Change-Number: 7424367
    Gerrit-PatchSet: 2
    Gerrit-Owner: Ian Kilpatrick <ikilp...@chromium.org>
    Gerrit-Reviewer: David Grogan <dgr...@chromium.org>
    Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
    Gerrit-Attention: Ian Kilpatrick <ikilp...@chromium.org>
    Gerrit-Comment-Date: Fri, 09 Jan 2026 23:24:21 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Jan 9, 2026, 8:18:31 PM (5 days ago) Jan 9
    to Ian Kilpatrick, David Grogan, chromium...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, zol...@webkit.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    [layout] Partial revert of crrev.com/7268420

    There is the slightest potential for a UBSan Failure - so add the
    nullptr check back in so that we don't reach it in:
    RemoveOnlyThisLayerAfterStyleChange

    This will be re-added in the subsequent patch.
    Bug: 469120960
    Change-Id: I8d698dd0ba53d1b0c17f8a03bafdad3794219ec9
    Auto-Submit: Ian Kilpatrick <ikilp...@chromium.org>
    Commit-Queue: Ian Kilpatrick <ikilp...@chromium.org>
    Commit-Queue: David Grogan <dgr...@chromium.org>
    Reviewed-by: David Grogan <dgr...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1567309}
    Files:
    • M third_party/blink/renderer/core/layout/layout_box_model_object.cc
    Change size: XS
    Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by David Grogan
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I8d698dd0ba53d1b0c17f8a03bafdad3794219ec9
    Gerrit-Change-Number: 7424367
    Gerrit-PatchSet: 3
    Gerrit-Owner: Ian Kilpatrick <ikilp...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: David Grogan <dgr...@chromium.org>
    Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
    open
    diffy
    satisfied_requirement

    Morten Stenshorne (Gerrit)

    unread,
    Jan 12, 2026, 4:08:18 AM (3 days ago) Jan 12
    to Chromium LUCI CQ, Ian Kilpatrick, David Grogan, chromium...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, zol...@webkit.org

    Morten Stenshorne added 1 comment

    Patchset-level comments
    File-level comment, Patchset 3 (Latest):
    Morten Stenshorne . resolved

    The link in the title is 404.

    Here's one that works: https://crrev.com/c/7268420

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I8d698dd0ba53d1b0c17f8a03bafdad3794219ec9
    Gerrit-Change-Number: 7424367
    Gerrit-PatchSet: 3
    Gerrit-Owner: Ian Kilpatrick <ikilp...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: David Grogan <dgr...@chromium.org>
    Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
    Gerrit-CC: Morten Stenshorne <mste...@chromium.org>
    Gerrit-Comment-Date: Mon, 12 Jan 2026 09:08:06 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    open
    diffy

    Ian Kilpatrick (Gerrit)

    unread,
    7:43 PM (4 hours ago) 7:43 PM
    to Chromium LUCI CQ, Morten Stenshorne, David Grogan, chromium...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, zol...@webkit.org

    Ian Kilpatrick added 1 comment

    Patchset-level comments
    Morten Stenshorne . resolved

    The link in the title is 404.

    Here's one that works: https://crrev.com/c/7268420

    Ian Kilpatrick

    sorry 😞

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I8d698dd0ba53d1b0c17f8a03bafdad3794219ec9
    Gerrit-Change-Number: 7424367
    Gerrit-PatchSet: 3
    Gerrit-Owner: Ian Kilpatrick <ikilp...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: David Grogan <dgr...@chromium.org>
    Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
    Gerrit-CC: Morten Stenshorne <mste...@chromium.org>
    Gerrit-Comment-Date: Thu, 15 Jan 2026 00:43:41 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Morten Stenshorne <mste...@chromium.org>
    satisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages