Reland "[next] Launch Omnibox and NTP Next features" [chromium/src : main]

0 views
Skip to first unread message

Riley Tatum (Gerrit)

unread,
Jun 30, 2026, 4:16:00 PM (10 days ago) Jun 30
to Justin Donnelly, Aviv Kiss, Jiacheng Guo, Duncan Mercer, Chromium LUCI CQ, rubber-...@appspot.gserviceaccount.com, android-bu...@system.gserviceaccount.com, Code Review Nudger, manuk hovanesian, chromium...@chromium.org, Chromium Metrics Reviews
Attention needed from Aviv Kiss, Duncan Mercer, Jiacheng Guo, Justin Donnelly and Moe Ahmadi

Riley Tatum has uploaded the change for review

Riley Tatum would like Justin Donnelly, Moe Ahmadi, Aviv Kiss, Jiacheng Guo, Duncan Mercer, Chromium LUCI CQ and rubber-...@appspot.gserviceaccount.com to review this change.

Commit message

Reland "[next] Launch Omnibox and NTP Next features"

This reverts commit 76cca6bde4e5374b0e1d2b5d52aa7f9ff0afb84c.

Reason for revert: Fixing tests

Original change's description:
> Revert "[next] Launch Omnibox and NTP Next features"
>
> This reverts commit 2e92ae12ce9bc226bb996030a4f03e77ad62bb9b.
>
> Reason for revert: Causing multiple CI failures
>
> Failure Link: https://ci.chromium.org/ui/p/chrome/builders/ci/linux64-rel-ready/69253/overview
> https://ci.chromium.org/ui/p/chrome/builders/ci/mac64/296405/overview
> https://ci.chromium.org/ui/p/chromium/builders/ci/Win10%20Tests%20x64/110547/overview
>
> Original change's description:
> > [next] Launch Omnibox and NTP Next features
> >
> > Fixed: 505856800
> > Change-Id: Icaf8358228ba09e0fec80b2dfbec54206d8ceb5c
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7791453
> > Commit-Queue: Riley Tatum <rta...@google.com>
> > Reviewed-by: Justin Donnelly <jdon...@chromium.org>
> > Reviewed-by: Moe Ahmadi <mah...@chromium.org>
> > Reviewed-by: Aviv Kiss <aviv...@google.com>
> > Cr-Commit-Position: refs/heads/main@{#1654470}
>
> Bug: 505856800
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Change-Id: Ie15b93b7e00748e0967b444029e14bfaee7922fe
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8017587
> Auto-Submit: Jiacheng Guo <g...@google.com>
> Owners-Override: Jiacheng Guo <g...@google.com>
> Commit-Queue: Jiacheng Guo <g...@google.com>
> Bot-Commit: rubber-...@appspot.gserviceaccount.com <rubber-...@appspot.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/main@{#1654553}
Bug: 505856800
Change-Id: I18e6ead9350ac3eb7a1ed8eb34693d9cc6059dfd

Change diff


Change information

Files:
  • M chrome/browser/ui/omnibox/omnibox_next_features.cc
  • M chrome/browser/ui/webui/new_tab_page/composebox/variations/composebox_fieldtrial.cc
  • M chrome/browser/ui/webui/new_tab_page/composebox/variations/composebox_fieldtrial_unittest.cc
  • M components/search/ntp_features.cc
  • M testing/variations/fieldtrial_testing_config.json
Change size: M
Delta: 5 files changed, 40 insertions(+), 60 deletions(-)
Open in Gerrit

Related details

Attention is currently required from:
  • Aviv Kiss
  • Duncan Mercer
  • Jiacheng Guo
  • Justin Donnelly
  • Moe Ahmadi
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I18e6ead9350ac3eb7a1ed8eb34693d9cc6059dfd
Gerrit-Change-Number: 8027107
Gerrit-PatchSet: 1
Gerrit-Owner: Riley Tatum <rta...@google.com>
Gerrit-Reviewer: Aviv Kiss <aviv...@google.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Duncan Mercer <mer...@google.com>
Gerrit-Reviewer: Jiacheng Guo <g...@google.com>
Gerrit-Reviewer: Justin Donnelly <jdon...@chromium.org>
Gerrit-Reviewer: Moe Ahmadi <mah...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
Gerrit-CC: manuk hovanesian <man...@chromium.org>
Gerrit-Attention: Justin Donnelly <jdon...@chromium.org>
Gerrit-Attention: Moe Ahmadi <mah...@chromium.org>
Gerrit-Attention: Aviv Kiss <aviv...@google.com>
Gerrit-Attention: Jiacheng Guo <g...@google.com>
Gerrit-Attention: Duncan Mercer <mer...@google.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

rubber-stamper@appspot.gserviceaccount.com (Gerrit)

unread,
Jun 30, 2026, 4:16:23 PM (10 days ago) Jun 30
to Riley Tatum, Justin Donnelly, Aviv Kiss, Jiacheng Guo, Duncan Mercer, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, Code Review Nudger, manuk hovanesian, chromium...@chromium.org, Chromium Metrics Reviews, jdonnel...@chromium.org, omnibox-...@chromium.org, asvitkine...@chromium.org
Attention needed from Aviv Kiss, Duncan Mercer, Jiacheng Guo, Justin Donnelly and Moe Ahmadi

Related details

Attention is currently required from:
  • Aviv Kiss
  • Duncan Mercer
  • Jiacheng Guo
  • Justin Donnelly
  • Moe Ahmadi
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I18e6ead9350ac3eb7a1ed8eb34693d9cc6059dfd
    Gerrit-Change-Number: 8027107
    Gerrit-PatchSet: 1
    Gerrit-Owner: Riley Tatum <rta...@google.com>
    Gerrit-Reviewer: Aviv Kiss <aviv...@google.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Duncan Mercer <mer...@google.com>
    Gerrit-Reviewer: Jiacheng Guo <g...@google.com>
    Gerrit-Reviewer: Justin Donnelly <jdon...@chromium.org>
    Gerrit-Reviewer: Moe Ahmadi <mah...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
    Gerrit-CC: manuk hovanesian <man...@chromium.org>
    Gerrit-Attention: Justin Donnelly <jdon...@chromium.org>
    Gerrit-Attention: Moe Ahmadi <mah...@chromium.org>
    Gerrit-Attention: Aviv Kiss <aviv...@google.com>
    Gerrit-Attention: Jiacheng Guo <g...@google.com>
    Gerrit-Attention: Duncan Mercer <mer...@google.com>
    Gerrit-Comment-Date: Tue, 30 Jun 2026 20:16:09 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Aviv Kiss (Gerrit)

    unread,
    Jun 30, 2026, 4:17:55 PM (10 days ago) Jun 30
    to Riley Tatum, rubber-...@appspot.gserviceaccount.com, Justin Donnelly, Jiacheng Guo, Duncan Mercer, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, Code Review Nudger, manuk hovanesian, chromium...@chromium.org, Chromium Metrics Reviews, jdonnel...@chromium.org, omnibox-...@chromium.org, asvitkine...@chromium.org
    Attention needed from Duncan Mercer, Jiacheng Guo, Justin Donnelly, Moe Ahmadi and Riley Tatum

    Aviv Kiss voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Duncan Mercer
    • Jiacheng Guo
    • Justin Donnelly
    • Moe Ahmadi
    • Riley Tatum
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    Gerrit-Attention: Jiacheng Guo <g...@google.com>
    Gerrit-Attention: Duncan Mercer <mer...@google.com>
    Gerrit-Attention: Riley Tatum <rta...@google.com>
    Gerrit-Comment-Date: Tue, 30 Jun 2026 20:17:40 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Aviv Kiss (Gerrit)

    unread,
    Jun 30, 2026, 5:41:47 PM (10 days ago) Jun 30
    to Riley Tatum, rubber-...@appspot.gserviceaccount.com, Justin Donnelly, Jiacheng Guo, Duncan Mercer, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, Code Review Nudger, manuk hovanesian, chromium...@chromium.org, Chromium Metrics Reviews, jdonnel...@chromium.org, omnibox-...@chromium.org, asvitkine...@chromium.org
    Attention needed from Duncan Mercer, Jiacheng Guo, Justin Donnelly, Moe Ahmadi and Riley Tatum

    Aviv Kiss voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Duncan Mercer
    • Jiacheng Guo
    • Justin Donnelly
    • Moe Ahmadi
    • Riley Tatum
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I18e6ead9350ac3eb7a1ed8eb34693d9cc6059dfd
    Gerrit-Change-Number: 8027107
    Gerrit-PatchSet: 2
    satisfied_requirement
    open
    diffy

    rubber-stamper@appspot.gserviceaccount.com (Gerrit)

    unread,
    Jun 30, 2026, 5:42:25 PM (10 days ago) Jun 30
    to Riley Tatum, Aviv Kiss, Justin Donnelly, Jiacheng Guo, Duncan Mercer, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, Code Review Nudger, manuk hovanesian, chromium...@chromium.org, Chromium Metrics Reviews, jdonnel...@chromium.org, omnibox-...@chromium.org, asvitkine...@chromium.org
    Attention needed from Duncan Mercer, Jiacheng Guo, Justin Donnelly, Moe Ahmadi and Riley Tatum

    Message from rubber-...@appspot.gserviceaccount.com

    Gerrit GetPureRevert API does not mark this CL as a pure revert. Learn more: go/rubber-stamper-user-guide.

    Gerrit-Comment-Date: Tue, 30 Jun 2026 21:42:11 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: No
    satisfied_requirement
    open
    diffy

    Justin Donnelly (Gerrit)

    unread,
    Jun 30, 2026, 6:24:54 PM (10 days ago) Jun 30
    to Riley Tatum, Justin Donnelly, Aviv Kiss, Jiacheng Guo, Duncan Mercer, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, Code Review Nudger, manuk hovanesian, chromium...@chromium.org, Chromium Metrics Reviews, jdonnel...@chromium.org, omnibox-...@chromium.org, asvitkine...@chromium.org
    Attention needed from Duncan Mercer, Jiacheng Guo, Moe Ahmadi and Riley Tatum

    Justin Donnelly voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Duncan Mercer
    • Jiacheng Guo
    • Moe Ahmadi
    • Riley Tatum
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I18e6ead9350ac3eb7a1ed8eb34693d9cc6059dfd
    Gerrit-Change-Number: 8027107
    Gerrit-PatchSet: 2
    Gerrit-Owner: Riley Tatum <rta...@google.com>
    Gerrit-Reviewer: Aviv Kiss <aviv...@google.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Duncan Mercer <mer...@google.com>
    Gerrit-Reviewer: Jiacheng Guo <g...@google.com>
    Gerrit-Reviewer: Justin Donnelly <jdon...@chromium.org>
    Gerrit-Reviewer: Moe Ahmadi <mah...@chromium.org>
    Gerrit-Reviewer: Riley Tatum <rta...@google.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
    Gerrit-CC: manuk hovanesian <man...@chromium.org>
    Gerrit-Attention: Moe Ahmadi <mah...@chromium.org>
    Gerrit-Attention: Jiacheng Guo <g...@google.com>
    Gerrit-Attention: Duncan Mercer <mer...@google.com>
    Gerrit-Attention: Riley Tatum <rta...@google.com>
    Gerrit-Comment-Date: Tue, 30 Jun 2026 22:24:39 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Duncan Mercer (Gerrit)

    unread,
    Jul 7, 2026, 12:35:25 PM (3 days ago) Jul 7
    to Riley Tatum, Justin Donnelly, Aviv Kiss, Jiacheng Guo, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, Code Review Nudger, manuk hovanesian, chromium...@chromium.org, Chromium Metrics Reviews, extension...@chromium.org, chromium-a...@chromium.org, jdonnel...@chromium.org, omnibox-...@chromium.org, asvitkine...@chromium.org
    Attention needed from Aviv Kiss, Jiacheng Guo, Justin Donnelly, Moe Ahmadi and Riley Tatum

    Duncan Mercer added 1 comment

    Patchset-level comments
    File-level comment, Patchset 3 (Latest):
    Duncan Mercer . resolved

    Removing myself from the reviewers since I'm not an owner of these files anymore.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Aviv Kiss
    • Jiacheng Guo
    • Justin Donnelly
    • Moe Ahmadi
    • Riley Tatum
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I18e6ead9350ac3eb7a1ed8eb34693d9cc6059dfd
    Gerrit-Change-Number: 8027107
    Gerrit-PatchSet: 3
    Gerrit-Owner: Riley Tatum <rta...@google.com>
    Gerrit-Reviewer: Aviv Kiss <aviv...@google.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Jiacheng Guo <g...@google.com>
    Gerrit-Reviewer: Justin Donnelly <jdon...@chromium.org>
    Gerrit-Reviewer: Moe Ahmadi <mah...@chromium.org>
    Gerrit-Reviewer: Riley Tatum <rta...@google.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
    Gerrit-CC: manuk hovanesian <man...@chromium.org>
    Gerrit-Attention: Justin Donnelly <jdon...@chromium.org>
    Gerrit-Attention: Aviv Kiss <aviv...@google.com>
    Gerrit-Attention: Moe Ahmadi <mah...@chromium.org>
    Gerrit-Attention: Jiacheng Guo <g...@google.com>
    Gerrit-Attention: Riley Tatum <rta...@google.com>
    Gerrit-Comment-Date: Tue, 07 Jul 2026 16:35:11 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Justin Donnelly (Gerrit)

    unread,
    Jul 7, 2026, 12:51:49 PM (3 days ago) Jul 7
    to Riley Tatum, Justin Donnelly, Aviv Kiss, Jiacheng Guo, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, Code Review Nudger, manuk hovanesian, chromium...@chromium.org, Chromium Metrics Reviews, extension...@chromium.org, chromium-a...@chromium.org, jdonnel...@chromium.org, omnibox-...@chromium.org, asvitkine...@chromium.org
    Attention needed from Aviv Kiss, Jiacheng Guo, Moe Ahmadi and Riley Tatum

    Justin Donnelly voted and added 1 comment

    Votes added by Justin Donnelly

    Code-Review+1

    1 comment

    Patchset-level comments
    Justin Donnelly . resolved

    Patchset 3 still lgtm

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Aviv Kiss
    • Jiacheng Guo
    • Moe Ahmadi
    • Riley Tatum
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I18e6ead9350ac3eb7a1ed8eb34693d9cc6059dfd
      Gerrit-Change-Number: 8027107
      Gerrit-PatchSet: 3
      Gerrit-Owner: Riley Tatum <rta...@google.com>
      Gerrit-Reviewer: Aviv Kiss <aviv...@google.com>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Jiacheng Guo <g...@google.com>
      Gerrit-Reviewer: Justin Donnelly <jdon...@chromium.org>
      Gerrit-Reviewer: Moe Ahmadi <mah...@chromium.org>
      Gerrit-Reviewer: Riley Tatum <rta...@google.com>
      Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
      Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
      Gerrit-CC: manuk hovanesian <man...@chromium.org>
      Gerrit-Attention: Aviv Kiss <aviv...@google.com>
      Gerrit-Attention: Moe Ahmadi <mah...@chromium.org>
      Gerrit-Attention: Jiacheng Guo <g...@google.com>
      Gerrit-Attention: Riley Tatum <rta...@google.com>
      Gerrit-Comment-Date: Tue, 07 Jul 2026 16:51:32 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Moe Ahmadi (Gerrit)

      unread,
      Jul 7, 2026, 1:21:12 PM (3 days ago) Jul 7
      to Riley Tatum, Justin Donnelly, Aviv Kiss, Jiacheng Guo, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, Code Review Nudger, manuk hovanesian, chromium...@chromium.org, Chromium Metrics Reviews, extension...@chromium.org, chromium-a...@chromium.org, jdonnel...@chromium.org, omnibox-...@chromium.org, asvitkine...@chromium.org
      Attention needed from Aviv Kiss, Jiacheng Guo and Riley Tatum

      Moe Ahmadi voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Aviv Kiss
      • Jiacheng Guo
      • Riley Tatum
      Gerrit-Attention: Jiacheng Guo <g...@google.com>
      Gerrit-Attention: Riley Tatum <rta...@google.com>
      Gerrit-Comment-Date: Tue, 07 Jul 2026 17:20:58 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Moe Ahmadi (Gerrit)

      unread,
      Jul 7, 2026, 9:16:18 PM (2 days ago) Jul 7
      to Riley Tatum, Justin Donnelly, Aviv Kiss, Jiacheng Guo, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, Code Review Nudger, manuk hovanesian, chromium...@chromium.org, Chromium Metrics Reviews, extension...@chromium.org, chromium-a...@chromium.org, jdonnel...@chromium.org, omnibox-...@chromium.org, asvitkine...@chromium.org
      Attention needed from Aviv Kiss, Jiacheng Guo, Justin Donnelly and Riley Tatum

      Moe Ahmadi voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Aviv Kiss
      • Jiacheng Guo
      • Justin Donnelly
      • Riley Tatum
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I18e6ead9350ac3eb7a1ed8eb34693d9cc6059dfd
      Gerrit-Change-Number: 8027107
      Gerrit-PatchSet: 4
      Gerrit-Owner: Riley Tatum <rta...@google.com>
      Gerrit-Reviewer: Aviv Kiss <aviv...@google.com>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Jiacheng Guo <g...@google.com>
      Gerrit-Reviewer: Justin Donnelly <jdon...@chromium.org>
      Gerrit-Reviewer: Moe Ahmadi <mah...@chromium.org>
      Gerrit-Reviewer: Riley Tatum <rta...@google.com>
      Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
      Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
      Gerrit-CC: manuk hovanesian <man...@chromium.org>
      Gerrit-Attention: Justin Donnelly <jdon...@chromium.org>
      Gerrit-Attention: Aviv Kiss <aviv...@google.com>
      Gerrit-Attention: Jiacheng Guo <g...@google.com>
      Gerrit-Attention: Riley Tatum <rta...@google.com>
      Gerrit-Comment-Date: Wed, 08 Jul 2026 01:16:09 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Justin Donnelly (Gerrit)

      unread,
      Jul 8, 2026, 12:37:35 PM (2 days ago) Jul 8
      to Riley Tatum, Justin Donnelly, Aviv Kiss, Jiacheng Guo, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, Code Review Nudger, manuk hovanesian, chromium...@chromium.org, Chromium Metrics Reviews, extension...@chromium.org, chromium-a...@chromium.org, jdonnel...@chromium.org, omnibox-...@chromium.org, asvitkine...@chromium.org
      Attention needed from Aviv Kiss, Jiacheng Guo and Riley Tatum

      Justin Donnelly voted and added 1 comment

      Votes added by Justin Donnelly

      Code-Review+1

      1 comment

      Patchset-level comments
      File-level comment, Patchset 4 (Latest):
      Justin Donnelly . resolved

      Still lgtm

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Aviv Kiss
      • Jiacheng Guo
      • Riley Tatum
      Gerrit-Attention: Aviv Kiss <aviv...@google.com>
      Gerrit-Attention: Jiacheng Guo <g...@google.com>
      Gerrit-Attention: Riley Tatum <rta...@google.com>
      Gerrit-Comment-Date: Wed, 08 Jul 2026 16:37:22 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Sophie Chang (Gerrit)

      unread,
      Jul 8, 2026, 8:40:48 PM (2 days ago) Jul 8
      to Riley Tatum, Justin Donnelly, Aviv Kiss, Jiacheng Guo, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, Code Review Nudger, manuk hovanesian, chromium...@chromium.org, Chromium Metrics Reviews, extension...@chromium.org, chromium-a...@chromium.org, jdonnel...@chromium.org, omnibox-...@chromium.org, asvitkine...@chromium.org
      Attention needed from Aviv Kiss, Jiacheng Guo and Riley Tatum

      Sophie Chang voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Aviv Kiss
      • Jiacheng Guo
      • Riley Tatum
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I18e6ead9350ac3eb7a1ed8eb34693d9cc6059dfd
      Gerrit-Change-Number: 8027107
      Gerrit-PatchSet: 4
      Gerrit-Owner: Riley Tatum <rta...@google.com>
      Gerrit-Reviewer: Aviv Kiss <aviv...@google.com>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Jiacheng Guo <g...@google.com>
      Gerrit-Reviewer: Justin Donnelly <jdon...@chromium.org>
      Gerrit-Reviewer: Moe Ahmadi <mah...@chromium.org>
      Gerrit-Reviewer: Riley Tatum <rta...@google.com>
      Gerrit-Reviewer: Sophie Chang <sophi...@chromium.org>
      Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
      Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
      Gerrit-CC: manuk hovanesian <man...@chromium.org>
      Gerrit-Attention: Aviv Kiss <aviv...@google.com>
      Gerrit-Attention: Jiacheng Guo <g...@google.com>
      Gerrit-Attention: Riley Tatum <rta...@google.com>
      Gerrit-Comment-Date: Thu, 09 Jul 2026 00:40:28 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Riley Tatum (Gerrit)

      unread,
      Jul 9, 2026, 12:31:17 PM (19 hours ago) Jul 9
      to Sophie Chang, Justin Donnelly, Aviv Kiss, Jiacheng Guo, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, Code Review Nudger, manuk hovanesian, chromium...@chromium.org, Chromium Metrics Reviews, extension...@chromium.org, chromium-a...@chromium.org, jdonnel...@chromium.org, omnibox-...@chromium.org, asvitkine...@chromium.org
      Attention needed from Aviv Kiss and Jiacheng Guo

      Riley Tatum voted Commit-Queue+2

      Commit-Queue+2
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Aviv Kiss
      • Jiacheng Guo
      Gerrit-Comment-Date: Thu, 09 Jul 2026 16:30:39 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Chromium LUCI CQ (Gerrit)

      unread,
      Jul 9, 2026, 1:59:41 PM (17 hours ago) Jul 9
      to Riley Tatum, Sophie Chang, Justin Donnelly, Aviv Kiss, Jiacheng Guo, android-bu...@system.gserviceaccount.com, Code Review Nudger, manuk hovanesian, chromium...@chromium.org, Chromium Metrics Reviews, extension...@chromium.org, chromium-a...@chromium.org, jdonnel...@chromium.org, omnibox-...@chromium.org, asvitkine...@chromium.org

      Chromium LUCI CQ submitted the change

      Change information

      Commit-Queue: Riley Tatum <rta...@google.com>
      Reviewed-by: Sophie Chang <sophi...@chromium.org>
      Reviewed-by: Moe Ahmadi <mah...@chromium.org>
      Reviewed-by: Justin Donnelly <jdon...@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#1659695}
      Files:
      • M chrome/browser/extensions/api/omnibox/omnibox_api_interactive_uitest.cc
      • M chrome/browser/ui/omnibox/omnibox_next_features.cc
      • M chrome/browser/ui/views/omnibox/omnibox_view_views_interactive_uitest.cc
      • M chrome/browser/ui/webui/new_tab_page/composebox/variations/composebox_fieldtrial.cc
      • M chrome/browser/ui/webui/new_tab_page/composebox/variations/composebox_fieldtrial_unittest.cc
      • M components/search/ntp_features.cc
      • M testing/variations/fieldtrial_testing_config.json
        Change size: M
        Delta: 7 files changed, 49 insertions(+), 86 deletions(-)
        Branch: refs/heads/main
        Submit Requirements:
        • requirement satisfiedCode-Review: +1 by Moe Ahmadi, +1 by Sophie Chang, +1 by Justin Donnelly
        Open in Gerrit
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: merged
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I18e6ead9350ac3eb7a1ed8eb34693d9cc6059dfd
        Gerrit-Change-Number: 8027107
        Gerrit-PatchSet: 5
        open
        diffy
        satisfied_requirement

        luci-bisection@appspot.gserviceaccount.com (Gerrit)

        unread,
        5:50 AM (1 hour ago) 5:50 AM
        to Chromium LUCI CQ, Riley Tatum, Sophie Chang, Justin Donnelly, Aviv Kiss, Jiacheng Guo, android-bu...@system.gserviceaccount.com, Code Review Nudger, manuk hovanesian, chromium...@chromium.org, Chromium Metrics Reviews, extension...@chromium.org, chromium-a...@chromium.org, jdonnel...@chromium.org, omnibox-...@chromium.org, asvitkine...@chromium.org

        Message from luci-bi...@appspot.gserviceaccount.com

        LUCI Bisection has identified this change as the cause of a test failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/test-analysis/b/5475346477481984

        Sample build with failed test: https://ci.chromium.org/b/8676714509093895633
        Affected test(s):
        [://chrome/test\:browser_tests!gtest::DevToolsProtocolTest#CreateInDefaultContextById](https://ci.chromium.org/ui/test/chromium/:%2F%2Fchrome%2Ftest%5C:browser_tests%21gtest::DevToolsProtocolTest%23CreateInDefaultContextById?q=VHash%3Abd478c65e18258a9)
        [://chrome/test\:browser_tests!gtest::DevToolsProtocolTest#HiddenTargetCanBeClosed](https://ci.chromium.org/ui/test/chromium/:%2F%2Fchrome%2Ftest%5C:browser_tests%21gtest::DevToolsProtocolTest%23HiddenTargetCanBeClosed?q=VHash%3Abd478c65e18258a9)
        [://chrome/test\:browser_tests!gtest::DevToolsProtocolTest#HiddenTargetIsNotVisibleInTabStrip](https://ci.chromium.org/ui/test/chromium/:%2F%2Fchrome%2Ftest%5C:browser_tests%21gtest::DevToolsProtocolTest%23HiddenTargetIsNotVisibleInTabStrip?q=VHash%3Abd478c65e18258a9)
        [://chrome/test\:browser_tests!gtest::DevToolsProtocolTest#HiddenTargetIsTheLastOne](https://ci.chromium.org/ui/test/chromium/:%2F%2Fchrome%2Ftest%5C:browser_tests%21gtest::DevToolsProtocolTest%23HiddenTargetIsTheLastOne?q=VHash%3Abd478c65e18258a9)
        [://chrome/test\:browser_tests!gtest::DevToolsProtocolTest#OpensDevTools_OpensForTabTarget](https://ci.chromium.org/ui/test/chromium/:%2F%2Fchrome%2Ftest%5C:browser_tests%21gtest::DevToolsProtocolTest%23OpensDevTools_OpensForTabTarget?q=VHash%3Abd478c65e18258a9)
        and 34 more ...
        A revert for this change was not created because the builder that this CL broke is not watched by gardeners, therefore less important. You can consider revert this CL, fix forward or let builder owners resolve it themselves.

        If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Ftest-analysis%2Fb%2F5475346477481984&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F8027107&type=BUG

        Open in Gerrit

        Related details

        Attention set is empty
        Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I18e6ead9350ac3eb7a1ed8eb34693d9cc6059dfd
        Gerrit-Change-Number: 8027107
        Gerrit-PatchSet: 5
        Gerrit-Owner: Riley Tatum <rta...@google.com>
        Gerrit-Reviewer: Aviv Kiss <aviv...@google.com>
        Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
        Gerrit-Reviewer: Jiacheng Guo <g...@google.com>
        Gerrit-Reviewer: Justin Donnelly <jdon...@chromium.org>
        Gerrit-Reviewer: Moe Ahmadi <mah...@chromium.org>
        Gerrit-Reviewer: Riley Tatum <rta...@google.com>
        Gerrit-Reviewer: Sophie Chang <sophi...@chromium.org>
        Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
        Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
        Gerrit-CC: manuk hovanesian <man...@chromium.org>
        Gerrit-Comment-Date: Fri, 10 Jul 2026 09:49:54 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: No
        satisfied_requirement
        open
        diffy
        Reply all
        Reply to author
        Forward
        0 new messages