nested app menu: Add UMA metrics [chromium/src : main]

0 views
Skip to first unread message

Masa Fujita (Gerrit)

unread,
Jul 20, 2026, 1:01:43 PM (yesterday) Jul 20
to Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org

Masa Fujita voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I087e01f2d73971a058be55b850e00e95be729b1c
Gerrit-Change-Number: 8123440
Gerrit-PatchSet: 3
Gerrit-Owner: Masa Fujita <mas...@google.com>
Gerrit-Reviewer: Masa Fujita <mas...@google.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-Comment-Date: Mon, 20 Jul 2026 17:01:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Masa Fujita (Gerrit)

unread,
Jul 20, 2026, 1:09:02 PM (yesterday) Jul 20
to Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org

Masa Fujita voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I087e01f2d73971a058be55b850e00e95be729b1c
Gerrit-Change-Number: 8123440
Gerrit-PatchSet: 4
Gerrit-Owner: Masa Fujita <mas...@google.com>
Gerrit-Reviewer: Masa Fujita <mas...@google.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-Comment-Date: Mon, 20 Jul 2026 17:08:37 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Masa Fujita (Gerrit)

unread,
Jul 20, 2026, 1:09:48 PM (yesterday) Jul 20
to Calder Kitagawa, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org
Attention needed from Calder Kitagawa

Masa Fujita voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Calder Kitagawa
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I087e01f2d73971a058be55b850e00e95be729b1c
Gerrit-Change-Number: 8123440
Gerrit-PatchSet: 4
Gerrit-Owner: Masa Fujita <mas...@google.com>
Gerrit-Reviewer: Calder Kitagawa <ckit...@chromium.org>
Gerrit-Reviewer: Masa Fujita <mas...@google.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-Attention: Calder Kitagawa <ckit...@chromium.org>
Gerrit-Comment-Date: Mon, 20 Jul 2026 17:09:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Calder Kitagawa (Gerrit)

unread,
Jul 20, 2026, 2:36:14 PM (yesterday) Jul 20
to Masa Fujita, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org
Attention needed from Masa Fujita

Calder Kitagawa voted and added 1 comment

Votes added by Calder Kitagawa

Code-Review+1
Commit-Queue+2

1 comment

Patchset-level comments
File-level comment, Patchset 4 (Latest):
Calder Kitagawa . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:
  • Masa Fujita
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I087e01f2d73971a058be55b850e00e95be729b1c
Gerrit-Change-Number: 8123440
Gerrit-PatchSet: 4
Gerrit-Owner: Masa Fujita <mas...@google.com>
Gerrit-Reviewer: Calder Kitagawa <ckit...@chromium.org>
Gerrit-Reviewer: Masa Fujita <mas...@google.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-Attention: Masa Fujita <mas...@google.com>
Gerrit-Comment-Date: Mon, 20 Jul 2026 18:36:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Jul 20, 2026, 2:45:07 PM (yesterday) Jul 20
to Masa Fujita, Calder Kitagawa, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
nested app menu: Add UMA metrics

We add missing UMA metrics:
- MobileMenuSelectTabFromGroup
- MobileMenuAboutChrome
- MobileMenuAddToExistingGroup
- MobileMenuOpenBookmark
- MobileMenuPaintPreview
Bug: 404074424
Change-Id: I087e01f2d73971a058be55b850e00e95be729b1c
Reviewed-by: Calder Kitagawa <ckit...@chromium.org>
Commit-Queue: Masa Fujita <mas...@google.com>
Commit-Queue: Calder Kitagawa <ckit...@chromium.org>
Auto-Submit: Masa Fujita <mas...@google.com>
Cr-Commit-Position: refs/heads/main@{#1664823}
Files:
  • M chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
  • M chrome/android/java/src/org/chromium/chrome/browser/app/ChromeActivity.java
  • M chrome/android/java/src/org/chromium/chrome/browser/ui/RootUiCoordinator.java
  • M tools/metrics/actions/actions.xml
Change size: S
Delta: 4 files changed, 39 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Calder Kitagawa
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I087e01f2d73971a058be55b850e00e95be729b1c
Gerrit-Change-Number: 8123440
Gerrit-PatchSet: 5
Gerrit-Owner: Masa Fujita <mas...@google.com>
Gerrit-Reviewer: Calder Kitagawa <ckit...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Masa Fujita <mas...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages