Revert "Fix drag and drop bookmark reordering" [chromium/src : main]

0 views
Skip to first unread message

Chrome Crash (Prod) (Gerrit)

unread,
Jan 13, 2026, 2:03:52 PMJan 13
to Yuheng Huang, Dominic Austria, Chromium LUCI CQ, David Pennington, chromium...@chromium.org
Attention needed from David Pennington, Dominic Austria and Yuheng Huang

Chrome Crash (Prod) has uploaded the change for review

Chrome Crash (Prod) would like Yuheng Huang, Dominic Austria, Chromium LUCI CQ and David Pennington to review this change.

Commit message

Revert "Fix drag and drop bookmark reordering"

This reverts commit 3ca8b3b0d68b6efdceebfcb380482d55a155a024.

Reason for revert: 
The Suspect CL https://chromium-review.googlesource.com/q/Ia924e003c1eaebe0dd162ca1b14276b086c89748 is highly likely the cause of the crash. Please see the crash report http://crash/2c9ea4919c4e5bdb.
Rebase the Revert CL on top of main branch with conflicts allowed option to prevent false positive merge conflicts.

If you agree with the revert CL, please approve it and mark as Commit-Queue +2 to submit it.

More details can be found in the go/crash-revert-cls-creation.

Original change's description:
> Fix drag and drop bookmark reordering
> 
> Correct the indices in BookmarkMenuDelegate when moving bookmark items
> in folders when TabGroupMenuImprovements is enabled. The indices need to
> be offset by a certain amount because of the 'open all' command menu
> items added to some of the bookmark folders.
> 
> Bug: 471847836
> Change-Id: Ia924e003c1eaebe0dd162ca1b14276b086c89748
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7411413
> Commit-Queue: Dominic Austria <dominic...@google.com>
> Reviewed-by: David Pennington <dpen...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1568090}
>
Bug: 471847836
Change-Id: I87bf0ce24beb4edfb1acd5e7a9aa1b505cd5cee1

Change diff


Change information

Files:
  • M chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc
  • M chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.h
  • M chrome/browser/ui/views/bookmarks/bookmark_menu_delegate_browsertest.cc
Change size: M
Delta: 3 files changed, 37 insertions(+), 111 deletions(-)
Open in Gerrit

Related details

Attention is currently required from:
  • David Pennington
  • Dominic Austria
  • Yuheng Huang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I87bf0ce24beb4edfb1acd5e7a9aa1b505cd5cee1
Gerrit-Change-Number: 7455120
Gerrit-PatchSet: 1
Gerrit-Owner: Chrome Crash (Prod) <cr...@system.gserviceaccount.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: David Pennington <dpen...@chromium.org>
Gerrit-Reviewer: Dominic Austria <dominic...@google.com>
Gerrit-Reviewer: Yuheng Huang <yuh...@chromium.org>
Gerrit-Attention: Yuheng Huang <yuh...@chromium.org>
Gerrit-Attention: Dominic Austria <dominic...@google.com>
Gerrit-Attention: David Pennington <dpen...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Chrome Crash (Prod) (Gerrit)

unread,
Jan 13, 2026, 2:04:23 PMJan 13
to Rubber Stamper, Yuheng Huang, Dominic Austria, Chromium LUCI CQ, David Pennington, chromium...@chromium.org
Attention needed from David Pennington, Dominic Austria and Yuheng Huang

Chrome Crash (Prod) voted Commit-Queue+1

Trigger the CQ Dryrun through the Set Review API to save waiting time.

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • David Pennington
  • Dominic Austria
  • Yuheng Huang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I87bf0ce24beb4edfb1acd5e7a9aa1b505cd5cee1
Gerrit-Change-Number: 7455120
Gerrit-PatchSet: 2
Gerrit-Owner: Chrome Crash (Prod) <cr...@system.gserviceaccount.com>
Gerrit-Reviewer: Chrome Crash (Prod) <cr...@system.gserviceaccount.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: David Pennington <dpen...@chromium.org>
Gerrit-Reviewer: Dominic Austria <dominic...@google.com>
Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Gerrit-Reviewer: Yuheng Huang <yuh...@chromium.org>
Gerrit-Attention: Yuheng Huang <yuh...@chromium.org>
Gerrit-Attention: Dominic Austria <dominic...@google.com>
Gerrit-Attention: David Pennington <dpen...@chromium.org>
Gerrit-Comment-Date: Tue, 13 Jan 2026 19:04:15 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Rubber Stamper (Gerrit)

unread,
Jan 13, 2026, 2:05:17 PMJan 13
to Chrome Crash (Prod), Yuheng Huang, Dominic Austria, Chromium LUCI CQ, David Pennington, chromium...@chromium.org
Attention needed from David Pennington, Dominic Austria and Yuheng Huang

Rubber Stamper voted Bot-Commit+1

Bot-Commit+1
Open in Gerrit

Related details

Attention is currently required from:
  • David Pennington
  • Dominic Austria
  • Yuheng Huang
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I87bf0ce24beb4edfb1acd5e7a9aa1b505cd5cee1
    Gerrit-Change-Number: 7455120
    Gerrit-PatchSet: 3
    Gerrit-Owner: Chrome Crash (Prod) <cr...@system.gserviceaccount.com>
    Gerrit-Reviewer: Chrome Crash (Prod) <cr...@system.gserviceaccount.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: David Pennington <dpen...@chromium.org>
    Gerrit-Reviewer: Dominic Austria <dominic...@google.com>
    Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
    Gerrit-Reviewer: Yuheng Huang <yuh...@chromium.org>
    Gerrit-Attention: Yuheng Huang <yuh...@chromium.org>
    Gerrit-Attention: Dominic Austria <dominic...@google.com>
    Gerrit-Attention: David Pennington <dpen...@chromium.org>
    Gerrit-Comment-Date: Tue, 13 Jan 2026 19:05:07 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    David Pennington (Gerrit)

    unread,
    Jan 13, 2026, 2:42:35 PMJan 13
    to Chrome Crash (Prod), Rubber Stamper, Yuheng Huang, Dominic Austria, Chromium LUCI CQ, chromium...@chromium.org
    Attention needed from Dominic Austria and Yuheng Huang

    David Pennington voted and added 1 comment

    Votes added by David Pennington

    Code-Review-1

    1 comment

    Patchset-level comments
    File-level comment, Patchset 3 (Latest):
    David Pennington . resolved

    we are going to fix this forward.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Dominic Austria
    • Yuheng Huang
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is blockingCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I87bf0ce24beb4edfb1acd5e7a9aa1b505cd5cee1
      Gerrit-Change-Number: 7455120
      Gerrit-PatchSet: 3
      Gerrit-Owner: Chrome Crash (Prod) <cr...@system.gserviceaccount.com>
      Gerrit-Reviewer: Chrome Crash (Prod) <cr...@system.gserviceaccount.com>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: David Pennington <dpen...@chromium.org>
      Gerrit-Reviewer: Dominic Austria <dominic...@google.com>
      Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
      Gerrit-Reviewer: Yuheng Huang <yuh...@chromium.org>
      Gerrit-Attention: Yuheng Huang <yuh...@chromium.org>
      Gerrit-Attention: Dominic Austria <dominic...@google.com>
      Gerrit-Comment-Date: Tue, 13 Jan 2026 19:42:23 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      blocking_requirement
      open
      diffy

      Dominic Austria (Gerrit)

      unread,
      Jan 15, 2026, 5:58:03 PMJan 15
      to Chrome Crash (Prod), David Pennington, Rubber Stamper, Yuheng Huang, Chromium LUCI CQ, chromium...@chromium.org

      Dominic Austria voted Code-Review-1

      Code-Review-1
      Open in Gerrit

      Related details

      Attention set is empty
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is blockingCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I87bf0ce24beb4edfb1acd5e7a9aa1b505cd5cee1
      Gerrit-Change-Number: 7455120
      Gerrit-PatchSet: 3
      Gerrit-Owner: Chrome Crash (Prod) <cr...@system.gserviceaccount.com>
      Gerrit-Reviewer: Chrome Crash (Prod) <cr...@system.gserviceaccount.com>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: David Pennington <dpen...@chromium.org>
      Gerrit-Reviewer: Dominic Austria <dominic...@google.com>
      Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
      Gerrit-Reviewer: Yuheng Huang <yuh...@chromium.org>
      Gerrit-Comment-Date: Thu, 15 Jan 2026 22:57:53 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      blocking_requirement
      open
      diffy

      Yuheng Huang (Gerrit)

      unread,
      Jan 22, 2026, 5:06:48 PMJan 22
      to Chrome Crash (Prod), Dominic Austria, David Pennington, Rubber Stamper, Chromium LUCI CQ, chromium...@chromium.org

      Yuheng Huang abandoned this change

      Related details

      Attention set is empty
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is blockingCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: abandon
      satisfied_requirement
      blocking_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages