Re: Domain Reliability: Add more Gmail domains (issue 1733463005 by ttuttle@chromium.org)

[ttu...@chromium.org]

Reviewers: davidben
CL: https://codereview.chromium.org/1733463005/

Message:
PTAL, davidben.

Description:
Domain Reliability: Add more Gmail domains

BUG=

Base URL: https://chromium.googlesource.com/chromium/src.git@master

Affected files (+9, -22 lines):
M components/domain_reliability.gypi
M components/domain_reliability/BUILD.gn
M components/domain_reliability/baked_in_configs.gypi
D components/domain_reliability/baked_in_configs/mail_google_com.json
M components/domain_reliability/google_configs.cc


Index: components/domain_reliability/baked_in_configs/mail_google_com.json
diff --git a/components/domain_reliability/baked_in_configs/mail_google_com.json b/components/domain_reliability/baked_in_configs/mail_google_com.json
deleted file mode 100644
index 5a7026d2d45516a68236dc311de4f1af1c752282..0000000000000000000000000000000000000000
--- a/components/domain_reliability/baked_in_configs/mail_google_com.json
+++ /dev/null
@@ -1,20 +0,0 @@
-{
- "origin": "https://mail.google.com/",
- "has_same_origin_collector": true,
- "success_sample_rate": 0.05,
- "collectors": [
- "https://beacons.gvt2.com/domainreliability/upload",
- "https://beacons2.gvt2.com/domainreliability/upload",
- "https://beacons3.gvt2.com/domainreliability/upload",
- "https://beacons4.gvt2.com/domainreliability/upload",
- "https://beacons5.gvt2.com/domainreliability/upload",
- "https://beacons5.gvt3.com/domainreliability/upload",
- "https://clients2.google.com/domainreliability/upload"
- ],
- "failure_sample_rate": 1.0,
- "include_subdomains": false,
- "path_prefixes": [
- "/*/channel/bind",
- ""
- ]
-}
Index: components/domain_reliability.gypi
diff --git a/components/domain_reliability.gypi b/components/domain_reliability.gypi
index 6b53ab2e7dc1f739344ebb11fc76fe2160864947..fbd131477be69d1fe3fda912601a6a8fbdaec1e2 100644
--- a/components/domain_reliability.gypi
+++ b/components/domain_reliability.gypi
@@ -70,6 +70,7 @@
'inputs': [
'<(bake_in_configs_script)',
'<@(baked_in_configs)',
+ 'domain_reliability/baked_in_configs.gypi',
],
'outputs': [
'<(baked_in_configs_cc)'
Index: components/domain_reliability/BUILD.gn
diff --git a/components/domain_reliability/BUILD.gn b/components/domain_reliability/BUILD.gn
index a0fb15f9b8b7438dc8f460ac6d1fda80ce76e492..e057ad2ccd85e3f51828e15115dc2b35c4cbf43b 100644
--- a/components/domain_reliability/BUILD.gn
+++ b/components/domain_reliability/BUILD.gn
@@ -23,7 +23,7 @@ action("bake_in_configs") {
visibility = [ ":*" ]
script = "bake_in_configs.py"

- inputs = baked_in_configs
+ inputs = baked_in_configs + [ "baked_in_configs.gypi" ]
output_file = "$target_gen_dir/baked_in_configs.cc"
outputs = [
output_file,
Index: components/domain_reliability/baked_in_configs.gypi
diff --git a/components/domain_reliability/baked_in_configs.gypi b/components/domain_reliability/baked_in_configs.gypi
index eebb3acac63a6a8eee46072fb1139cfe2590af03..a872ef8792e90113666748b1d934ba3b35fdcc80 100644
--- a/components/domain_reliability/baked_in_configs.gypi
+++ b/components/domain_reliability/baked_in_configs.gypi
@@ -20,7 +20,6 @@
'domain_reliability/baked_in_configs/googlevideo_com.json',
'domain_reliability/baked_in_configs/gvt1_com.json',
'domain_reliability/baked_in_configs/gvt2_com.json',
- 'domain_reliability/baked_in_configs/mail_google_com.json',
'domain_reliability/baked_in_configs/ssl_gstatic_com.json',
'domain_reliability/baked_in_configs/www_google_com.json',
],
Index: components/domain_reliability/google_configs.cc
diff --git a/components/domain_reliability/google_configs.cc b/components/domain_reliability/google_configs.cc
index 5063b56c35240b8f876ca50eb2628f90d444ae05..0e0647cdd5b61c99c5dfede2eaa69e95dc208e38 100644
--- a/components/domain_reliability/google_configs.cc
+++ b/components/domain_reliability/google_configs.cc
@@ -479,7 +479,14 @@ const GoogleConfigParams kGoogleConfigs[] = {
// Origins without subdomains and with same-origin collectors.
{ "accounts.google.com", false, true, false },
{ "apis.google.com", false, true, false },
+ { "b.mail.google.com", false, true, false },
+ { "chatenabled.mail.google.com", false, true, false },
{ "ddm.google.com", false, true, false },
+ { "gmail.com", false, true, false },
+ { "gmail.google.com", false, true, false },
+ { "mail.google.com", false, true, false },
+ { "mail-attachment.googleusercontent.com", false, true, false },
+ { "www.gmail.com", false, true, false },

// Origins without subdomains or same-origin collectors.
{ "ad.doubleclick.net", false, false, false },

[davi...@chromium.org]

(Try bots seem to be exploding for some reason.)

https://codereview.chromium.org/1733463005/

[ttu...@chromium.org]

PTAL, davidben.

https://codereview.chromium.org/1733463005/

[davi...@chromium.org]

lgtm




https://codereview.chromium.org/1733463005/diff/40001/components/domain_reliability/baked_in_configs/mail_google_com.json
File components/domain_reliability/baked_in_configs/mail_google_com.json
(left):

https://codereview.chromium.org/1733463005/diff/40001/components/domain_reliability/baked_in_configs/mail_google_com.json#oldcode17
components/domain_reliability/baked_in_configs/mail_google_com.json:17:
"/*/channel/bind",
I am assuming it is okay that this will get lost.

https://codereview.chromium.org/1733463005/

[ttu...@chromium.org]

Yup; it'll be reporting with full URLs now (at least if the same-origin
collector is working).

https://codereview.chromium.org/1733463005/

[commit-bot@chromium.org via codereview.chromium.org]

CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1733463005/40001
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1733463005/40001


https://codereview.chromium.org/1733463005/

[commit-bot@chromium.org via codereview.chromium.org]

Committed patchset #3 (id:40001)

https://codereview.chromium.org/1733463005/

[commit-bot@chromium.org via codereview.chromium.org]

Patchset 3 (id:??) landed as
https://crrev.com/6fb41398844159d23b37ab41382d950c75cb5ac6
Cr-Commit-Position: refs/heads/master@{#378033}

https://codereview.chromium.org/1733463005/

[jennc...@gmail.com]

This is my accounts being attacked still. There is no permission granted.
Jenn cook