Fix unsafe buffer usage in seccomp_broker_process_unittest.cc [chromium/src : main]
0 views
Skip to first unread message
Joshua Peraza (Gerrit)
Jul 7, 2026, 4:57:18 PM (2 days ago) Jul 7
to Arthur Sonzogni, Matthew Denton, Chromium LUCI CQ, chromium...@chromium.org, mpdento...@chromium.org, rsesek...@chromium.org
Attention needed from Matthew Denton
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Matthew Denton
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Matthew Denton (Gerrit)
3:46 AM (8 hours ago) 3:46 AM
to Joshua Peraza, Arthur Sonzogni, Chromium LUCI CQ, chromium...@chromium.org, mpdento...@chromium.org, rsesek...@chromium.org
Attention needed from Arthur Sonzogni and Joshua Peraza
Matthew Denton voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Arthur Sonzogni
- Joshua Peraza
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Arthur Sonzogni (Gerrit)
8:12 AM (3 hours ago) 8:12 AM
to Joshua Peraza, Matthew Denton, Chromium LUCI CQ, chromium...@chromium.org, mpdento...@chromium.org, rsesek...@chromium.org
Attention needed from Joshua Peraza
Arthur Sonzogni voted Commit-Queue+2![]( "Open in Gerrit")
Attention is currently required from:
- Joshua Peraza
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
8:21 AM (3 hours ago) 8:21 AM
to Joshua Peraza, Arthur Sonzogni, Matthew Denton, chromium...@chromium.org, mpdento...@chromium.org, rsesek...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Fix unsafe buffer usage in seccomp_broker_process_unittest.cc
Refactored buffer handling in seccomp broker integration tests to use
modern C++ and Chromium idioms. Key changes include:
- Replaced raw pointer and size parameters in `Syscaller::Readlink`
with `base::span<char>`.
- Converted C-style arrays to `std::array`.
- Replaced `memcmp` and `memset` with `base::span` comparisons and
`std::ranges::fill`.
- Used `base::SpanReader` to safely parse `inotify_event` structures.
These changes eliminate several `UNSAFE_TODO` markers and improve
overall memory safety by leveraging bounds-checked containers.
Initial patchset generated by headless gemini-cli using:
//agents/prompts/projects/spanification/run.py
Fixed: 506879694
Change-Id: Ic5741e76ec75e6317d6fa1152e67fc69db51c006
Reviewed-by: Matthew Denton <mpde...@chromium.org>
Commit-Queue: Arthur Sonzogni <arthurs...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1659482}
Files:
- M sandbox/linux/integration_tests/seccomp_broker_process_unittest.cc
Change size: M
Delta: 1 file changed, 51 insertions(+), 43 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Matthew Denton
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages