Revert "Enable kWebViewSurfaceControlForTV by default" [chromium/src : main]
0 views
Skip to first unread message
Vasiliy Telezhnikov (Gerrit)
11:11 AM (8 hours ago) 11:11 AM
to Chromium LUCI CQ, Bo Liu, chromium...@chromium.org
Vasiliy Telezhnikov has uploaded the change for review![]( "Open in Gerrit")
Vasiliy Telezhnikov would like Chromium LUCI CQ and Bo Liu to review this change.
Commit message
Revert "Enable kWebViewSurfaceControlForTV by default"
This reverts commit 95f519125f9718a95ffb5262c08d85672b477aed.
Reason for revert: Causes problems on MediaTek SoCs
Original change's description:
> Enable kWebViewSurfaceControlForTV by default
>
> We're launching the feature. Feature flag is checked in two places[1][2]
>
> [2] is gated on IsUsingThreadSafeMediaForWebView which is enabled only
> on webview. [1] is checked in few places, but all of them are webview
> specific code except [3].
>
> [3] already returns true for clank universally and now will start
> returning true for webview/tv (it already returns true for non-tv).
>
> Based on this, we don't need any special handling of the feature flag
> between clank/webview, we can just turn it on.
>
> [1] https://source.chromium.org/chromium/chromium/src/+/main:components/viz/common/features.cc;drc=ad0b5be27291850e9e7dd78b33fdf31949168d50;l=441
> [2] https://source.chromium.org/chromium/chromium/src/+/main:gpu/config/gpu_finch_features.cc;drc=ad0b5be27291850e9e7dd78b33fdf31949168d50;l=775
> [3] https://source.chromium.org/chromium/chromium/src/+/main:components/viz/common/features.cc;drc=ad0b5be27291850e9e7dd78b33fdf31949168d50;l=451
>
> Bug: 40113791
> Change-Id: I8ff09d755c9ae866134fec496f6f7c50eccc57de
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7218369
> Reviewed-by: Bo Liu <bo...@chromium.org>
> Commit-Queue: Vasiliy Telezhnikov <vas...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1553484}
Bug: 40113791
Change-Id: I260f9f9e904d020a8c5b446b025d4411d1585d04
Change diff
diff --git a/gpu/config/gpu_finch_features.cc b/gpu/config/gpu_finch_features.cc
index 72bcb30..149fa65 100644
--- a/gpu/config/gpu_finch_features.cc
+++ b/gpu/config/gpu_finch_features.cc
@@ -63,7 +63,7 @@
// Hardware Overlays for WebView.
BASE_FEATURE(kWebViewSurfaceControl, base::FEATURE_DISABLED_BY_DEFAULT);
-BASE_FEATURE(kWebViewSurfaceControlForTV, base::FEATURE_ENABLED_BY_DEFAULT);
+BASE_FEATURE(kWebViewSurfaceControlForTV, base::FEATURE_DISABLED_BY_DEFAULT);
// This is used as default state because it's different for webview and chrome.
// WebView hardcodes this as enabled in AwMainDelegate.
@@ -94,7 +94,7 @@
kRelaxLimitAImageReaderMaxSizeToOneManufacturerBlocklist{
&kRelaxLimitAImageReaderMaxSizeToOne,
"RelaxLimitAImageReaderMaxSizeToOneManufacturerBlocklist",
- "*Broadcom*|*Google*"};
+ "*Broadcom*"};
const base::FeatureParam<std::string>
kRelaxLimitAImageReaderMaxSizeToOneDeviceBlocklist{
&kRelaxLimitAImageReaderMaxSizeToOne,
Change information
Files:
- M gpu/config/gpu_finch_features.cc
Change size: XS
Delta: 1 file changed, 2 insertions(+), 2 deletions(-)
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Vasiliy Telezhnikov (Gerrit)
11:59 AM (7 hours ago) 11:59 AM
to Rubber Stamper, Chromium LUCI CQ, Bo Liu, chromium...@chromium.org
Attention needed from Bo Liu
Vasiliy Telezhnikov added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Vasiliy Telezhnikov . resolved
Please, take a look. Hope to land it before the branch today.
Related details
Attention is currently required from:
- Bo Liu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rubber Stamper (Gerrit)
12:00 PM (7 hours ago) 12:00 PM
to Vasiliy Telezhnikov, Chromium LUCI CQ, Bo Liu, chromium...@chromium.org
Attention needed from Bo Liu
Message from Rubber Stamper![]( "Open in Gerrit")
The change is not in the configured time window. Rubber Stamper is only allowed to review reverts within 14 day(s). Learn more: go/rubber-stamper-user-guide.
Related details
Attention is currently required from:
- Bo Liu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Bo Liu (Gerrit)
12:01 PM (7 hours ago) 12:01 PM
to Vasiliy Telezhnikov, Bo Liu, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Vasiliy Telezhnikov
Bo Liu voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Vasiliy Telezhnikov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Vasiliy Telezhnikov (Gerrit)
12:37 PM (6 hours ago) 12:37 PM
to Bo Liu, Chromium LUCI CQ, chromium...@chromium.org
Vasiliy Telezhnikov voted and added 1 comment![]( "Open in Gerrit")
Votes added by Vasiliy Telezhnikov
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Vasiliy Telezhnikov . resolved
Thanks for the review.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
1:40 PM (5 hours ago) 1:40 PM
to Vasiliy Telezhnikov, Bo Liu, chromium...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit-Queue: Vasiliy Telezhnikov <vas...@chromium.org>
Reviewed-by: Bo Liu <bo...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1567903}
Files:
- M gpu/config/gpu_finch_features.cc
Change size: XS
Delta: 1 file changed, 2 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Bo Liu
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages