[Model Picker & Canvas] Add strings for context menu section headers [chromium/src : main]

0 views
Skip to first unread message

Josiah Kiehl (Gerrit)

unread,
5:13 PM (4 hours ago) 5:13 PM
to Khalid Peer, Roman Arora, AyeAye, chromium...@chromium.org, Sophie Chang
Attention needed from Khalid Peer

Josiah Kiehl voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Khalid Peer
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I2e533ead13b27ed277a8d6cefddaa8952827d700
Gerrit-Change-Number: 7485997
Gerrit-PatchSet: 4
Gerrit-Owner: Josiah Kiehl <ki...@google.com>
Gerrit-Reviewer: Josiah Kiehl <ki...@google.com>
Gerrit-Reviewer: Khalid Peer <khali...@chromium.org>
Gerrit-CC: Roman Arora <roman...@chromium.org>
Gerrit-CC: Sophie Chang <sophi...@chromium.org>
Gerrit-Attention: Khalid Peer <khali...@chromium.org>
Gerrit-Comment-Date: Thu, 15 Jan 2026 22:13:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Khalid Peer (Gerrit)

unread,
5:45 PM (3 hours ago) 5:45 PM
to Josiah Kiehl, Chromium LUCI CQ, Roman Arora, AyeAye, chromium...@chromium.org, Sophie Chang
Attention needed from Josiah Kiehl

Khalid Peer added 2 comments

Patchset-level comments
File-level comment, Patchset 4 (Latest):
Khalid Peer . unresolved

Do we also need to add

Commit Message
Line 7, Patchset 4 (Latest):[Model Picker & Canvas] Add strings for context menu section headers
Khalid Peer . unresolved

Based on https://screenshot.googleplex.com/4hBCcN2yRoPAst5, do we also need to add strings for the "Media" and "Tools" section headers as well?

Open in Gerrit

Related details

Attention is currently required from:
  • Josiah Kiehl
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I2e533ead13b27ed277a8d6cefddaa8952827d700
    Gerrit-Change-Number: 7485997
    Gerrit-PatchSet: 4
    Gerrit-Owner: Josiah Kiehl <ki...@google.com>
    Gerrit-Reviewer: Josiah Kiehl <ki...@google.com>
    Gerrit-Reviewer: Khalid Peer <khali...@chromium.org>
    Gerrit-CC: Roman Arora <roman...@chromium.org>
    Gerrit-CC: Sophie Chang <sophi...@chromium.org>
    Gerrit-Attention: Josiah Kiehl <ki...@google.com>
    Gerrit-Comment-Date: Thu, 15 Jan 2026 22:45:38 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Josiah Kiehl (Gerrit)

    unread,
    5:46 PM (3 hours ago) 5:46 PM
    to Chromium LUCI CQ, Khalid Peer, Roman Arora, AyeAye, chromium...@chromium.org, Sophie Chang
    Attention needed from Khalid Peer

    Josiah Kiehl added 2 comments

    Patchset-level comments
    Khalid Peer . resolved

    Do we also need to add

    Josiah Kiehl

    Done

    Commit Message
    Line 7, Patchset 4 (Latest):[Model Picker & Canvas] Add strings for context menu section headers
    Khalid Peer . resolved

    Based on https://screenshot.googleplex.com/4hBCcN2yRoPAst5, do we also need to add strings for the "Media" and "Tools" section headers as well?

    Josiah Kiehl

    No, the version that was approved was the right one.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Khalid Peer
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I2e533ead13b27ed277a8d6cefddaa8952827d700
      Gerrit-Change-Number: 7485997
      Gerrit-PatchSet: 4
      Gerrit-Owner: Josiah Kiehl <ki...@google.com>
      Gerrit-Reviewer: Josiah Kiehl <ki...@google.com>
      Gerrit-Reviewer: Khalid Peer <khali...@chromium.org>
      Gerrit-CC: Roman Arora <roman...@chromium.org>
      Gerrit-CC: Sophie Chang <sophi...@chromium.org>
      Gerrit-Attention: Khalid Peer <khali...@chromium.org>
      Gerrit-Comment-Date: Thu, 15 Jan 2026 22:46:42 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Khalid Peer <khali...@chromium.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Khalid Peer (Gerrit)

      unread,
      5:48 PM (3 hours ago) 5:48 PM
      to Josiah Kiehl, Chromium LUCI CQ, Roman Arora, AyeAye, chromium...@chromium.org, Sophie Chang
      Attention needed from Josiah Kiehl

      Khalid Peer voted and added 2 comments

      Votes added by Khalid Peer

      Code-Review+1

      2 comments

      Patchset-level comments
      Khalid Peer . resolved

      LGTM!

      Commit Message
      Line 7, Patchset 4 (Latest):[Model Picker & Canvas] Add strings for context menu section headers
      Khalid Peer . resolved

      Based on https://screenshot.googleplex.com/4hBCcN2yRoPAst5, do we also need to add strings for the "Media" and "Tools" section headers as well?

      Josiah Kiehl

      No, the version that was approved was the right one.

      Khalid Peer

      D'oh... I missed that we're not including all section headers in the UX-approved version. Thanks for the clarification!

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Josiah Kiehl
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement is not satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I2e533ead13b27ed277a8d6cefddaa8952827d700
        Gerrit-Change-Number: 7485997
        Gerrit-PatchSet: 4
        Gerrit-Owner: Josiah Kiehl <ki...@google.com>
        Gerrit-Reviewer: Josiah Kiehl <ki...@google.com>
        Gerrit-Reviewer: Khalid Peer <khali...@chromium.org>
        Gerrit-CC: Roman Arora <roman...@chromium.org>
        Gerrit-CC: Sophie Chang <sophi...@chromium.org>
        Gerrit-Attention: Josiah Kiehl <ki...@google.com>
        Gerrit-Comment-Date: Thu, 15 Jan 2026 22:48:25 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: Yes
        Comment-In-Reply-To: Khalid Peer <khali...@chromium.org>
        Comment-In-Reply-To: Josiah Kiehl <ki...@google.com>
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Duncan Mercer (Gerrit)

        unread,
        6:07 PM (3 hours ago) 6:07 PM
        to Josiah Kiehl, Khalid Peer, Chromium LUCI CQ, Roman Arora, AyeAye, chromium...@chromium.org, Sophie Chang
        Attention needed from Josiah Kiehl

        Duncan Mercer voted

        Code-Review+1
        Commit-Queue+2
        Open in Gerrit

        Related details

        Attention is currently required from:
        • Josiah Kiehl
        Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement is not satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I2e533ead13b27ed277a8d6cefddaa8952827d700
        Gerrit-Change-Number: 7485997
        Gerrit-PatchSet: 4
        Gerrit-Owner: Josiah Kiehl <ki...@google.com>
        Gerrit-Reviewer: Duncan Mercer <mer...@google.com>
        Gerrit-Reviewer: Josiah Kiehl <ki...@google.com>
        Gerrit-Reviewer: Khalid Peer <khali...@chromium.org>
        Gerrit-CC: Roman Arora <roman...@chromium.org>
        Gerrit-CC: Sophie Chang <sophi...@chromium.org>
        Gerrit-Attention: Josiah Kiehl <ki...@google.com>
        Gerrit-Comment-Date: Thu, 15 Jan 2026 23:07:06 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Josiah Kiehl (Gerrit)

        unread,
        6:13 PM (3 hours ago) 6:13 PM
        to Justin Donnelly, Khalid Peer, Chromium LUCI CQ, Roman Arora, AyeAye, chromium...@chromium.org, Sophie Chang

        Josiah Kiehl voted

        Auto-Submit+1
        Commit-Queue+1
        Open in Gerrit

        Related details

        Attention set is empty
        Submit Requirements:
          • requirement satisfiedCode-Coverage
          • requirement is not satisfiedCode-Owners
          • requirement is not satisfiedCode-Review
          • requirement is not satisfiedReview-Enforcement
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: I2e533ead13b27ed277a8d6cefddaa8952827d700
          Gerrit-Change-Number: 7485997
          Gerrit-PatchSet: 5
          Gerrit-Owner: Josiah Kiehl <ki...@google.com>
          Gerrit-Reviewer: Josiah Kiehl <ki...@google.com>
          Gerrit-Reviewer: Justin Donnelly <jdon...@chromium.org>
          Gerrit-Reviewer: Khalid Peer <khali...@chromium.org>
          Gerrit-CC: Roman Arora <roman...@chromium.org>
          Gerrit-CC: Sophie Chang <sophi...@chromium.org>
          Gerrit-Comment-Date: Thu, 15 Jan 2026 23:13:47 +0000
          Gerrit-HasComments: No
          Gerrit-Has-Labels: Yes
          satisfied_requirement
          unsatisfied_requirement
          open
          diffy

          Tommy Nyquist (Gerrit)

          unread,
          6:35 PM (2 hours ago) 6:35 PM
          to Josiah Kiehl, Justin Donnelly, Chromium LUCI CQ, Roman Arora, AyeAye, chromium...@chromium.org, Sophie Chang
          Attention needed from Josiah Kiehl

          Tommy Nyquist voted and added 1 comment

          Votes added by Tommy Nyquist

          Code-Review+1

          1 comment

          Patchset-level comments
          File-level comment, Patchset 5 (Latest):
          Tommy Nyquist . resolved

          lgtm

          Open in Gerrit

          Related details

          Attention is currently required from:
          • Josiah Kiehl
          Submit Requirements:
          • requirement satisfiedCode-Coverage
          • requirement satisfiedCode-Owners
          • requirement satisfiedCode-Review
          • requirement satisfiedReview-Enforcement
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: I2e533ead13b27ed277a8d6cefddaa8952827d700
          Gerrit-Change-Number: 7485997
          Gerrit-PatchSet: 5
          Gerrit-Owner: Josiah Kiehl <ki...@google.com>
          Gerrit-Reviewer: Josiah Kiehl <ki...@google.com>
          Gerrit-Reviewer: Justin Donnelly <jdon...@chromium.org>
          Gerrit-Reviewer: Tommy Nyquist <nyq...@chromium.org>
          Gerrit-CC: Roman Arora <roman...@chromium.org>
          Gerrit-CC: Sophie Chang <sophi...@chromium.org>
          Gerrit-Attention: Josiah Kiehl <ki...@google.com>
          Gerrit-Comment-Date: Thu, 15 Jan 2026 23:34:50 +0000
          Gerrit-HasComments: Yes
          Gerrit-Has-Labels: Yes
          satisfied_requirement
          open
          diffy

          Josiah Kiehl (Gerrit)

          unread,
          6:35 PM (2 hours ago) 6:35 PM
          to Tommy Nyquist, Justin Donnelly, Chromium LUCI CQ, Roman Arora, AyeAye, chromium...@chromium.org, Sophie Chang

          Josiah Kiehl voted Commit-Queue+2

          Commit-Queue+2
          Open in Gerrit

          Related details

          Attention set is empty
          Submit Requirements:
          • requirement satisfiedCode-Coverage
          • requirement satisfiedCode-Owners
          • requirement satisfiedCode-Review
          • requirement satisfiedReview-Enforcement
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: I2e533ead13b27ed277a8d6cefddaa8952827d700
          Gerrit-Change-Number: 7485997
          Gerrit-PatchSet: 5
          Gerrit-Owner: Josiah Kiehl <ki...@google.com>
          Gerrit-Reviewer: Josiah Kiehl <ki...@google.com>
          Gerrit-Reviewer: Justin Donnelly <jdon...@chromium.org>
          Gerrit-Reviewer: Tommy Nyquist <nyq...@chromium.org>
          Gerrit-CC: Roman Arora <roman...@chromium.org>
          Gerrit-CC: Sophie Chang <sophi...@chromium.org>
          Gerrit-Comment-Date: Thu, 15 Jan 2026 23:35:40 +0000
          Gerrit-HasComments: No
          Gerrit-Has-Labels: Yes
          satisfied_requirement
          open
          diffy

          Chromium LUCI CQ (Gerrit)

          unread,
          7:26 PM (1 hour ago) 7:26 PM
          to Josiah Kiehl, Tommy Nyquist, Justin Donnelly, Roman Arora, AyeAye, chromium...@chromium.org, Sophie Chang

          Chromium LUCI CQ submitted the change

          Change information

          Commit message:
          [Model Picker & Canvas] Add strings for context menu section headers
          Change-Id: I2e533ead13b27ed277a8d6cefddaa8952827d700
          Auto-Submit: Josiah Kiehl <ki...@google.com>
          Reviewed-by: Tommy Nyquist <nyq...@chromium.org>
          Commit-Queue: Josiah Kiehl <ki...@google.com>
          Cr-Commit-Position: refs/heads/main@{#1570085}
          Files:
          • M chrome/browser/ui/webui/cr_components/searchbox/searchbox_handler.cc
          • M components/contextual_tasks_strings.grdp
          • A components/contextual_tasks_strings_grdp/IDS_CONTEXTUAL_TASKS_CONTEXT_MENU_GEMINI_MODELS.png.sha1
          • A components/contextual_tasks_strings_grdp/IDS_CONTEXTUAL_TASKS_CONTEXT_MENU_MOST_RECENT_TABS.png.sha1
          Change size: S
          Delta: 4 files changed, 12 insertions(+), 0 deletions(-)
          Branch: refs/heads/main
          Submit Requirements:
          • requirement satisfiedCode-Review: +1 by Tommy Nyquist
          Open in Gerrit
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: merged
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: I2e533ead13b27ed277a8d6cefddaa8952827d700
          Gerrit-Change-Number: 7485997
          Gerrit-PatchSet: 6
          Gerrit-Owner: Josiah Kiehl <ki...@google.com>
          Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
          Gerrit-Reviewer: Josiah Kiehl <ki...@google.com>
          Gerrit-Reviewer: Justin Donnelly <jdon...@chromium.org>
          Gerrit-Reviewer: Tommy Nyquist <nyq...@chromium.org>
          open
          diffy
          satisfied_requirement
          Reply all
          Reply to author
          Forward
          0 new messages