[OTP] Include error code in default retrieval error message [chromium/src : main]
0 views
Skip to first unread message
Trang Mai (Gerrit)
9:34 AM (4 hours ago) 9:34 AM
to Dominic Battré, Min Qin, chromium...@chromium.org, mfoltz+wa...@chromium.org
Attention needed from Dominic Battré and Min Qin
Trang Mai voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Dominic Battré
- Min Qin
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dominic Battré (Gerrit)
10:39 AM (3 hours ago) 10:39 AM
to Trang Mai, Chromium LUCI CQ, Min Qin, chromium...@chromium.org, mfoltz+wa...@chromium.org
Attention needed from Min Qin and Trang Mai
Dominic Battré voted and added 1 comment![]( "Open in Gerrit")
Votes added by Dominic Battré
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Min Qin
- Trang Mai
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Min Qin (Gerrit)
11:17 AM (2 hours ago) 11:17 AM
to Trang Mai, Dominic Battré, Chromium LUCI CQ, chromium...@chromium.org, mfoltz+wa...@chromium.org
Attention needed from Trang Mai
Min Qin voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Trang Mai
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Trang Mai (Gerrit)
12:03 PM (2 hours ago) 12:03 PM
to Min Qin, Dominic Battré, Chromium LUCI CQ, chromium...@chromium.org, mfoltz+wa...@chromium.org
Trang Mai voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
12:08 PM (1 hour ago) 12:08 PM
to Trang Mai, Min Qin, Dominic Battré, chromium...@chromium.org, mfoltz+wa...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[OTP] Include error code in default retrieval error message
Include the underlying OneTimeTokenRetrievalError code in the default
mojom::ActionResult error message. This helps with debugging when an
unexpected error occurs.
Bug: 502908360
Change-Id: I9d2b58942e64a1ed00f5f4d769b9bbf89a263339
Reviewed-by: Dominic Battré <bat...@chromium.org>
Reviewed-by: Min Qin <qin...@chromium.org>
Commit-Queue: Trang Mai <tra...@google.com>
Cr-Commit-Position: refs/heads/main@{#1659602}
Files:
- M chrome/browser/actor/tools/attempt_otp_filling_tool.cc
- M chrome/browser/actor/tools/attempt_otp_filling_tool_unittest.cc
Change size: S
Delta: 2 files changed, 8 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Min Qin, +1 by Dominic Battré
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages