[Permissions] Defer SystemMediaSourceWin COM init to avoid re-entrancy crash [chromium/src : main]

0 views
Skip to first unread message

Ravjit Uppal (Gerrit)

unread,
May 21, 2026, 11:54:50 AM (11 days ago) May 21
to plantree, Chromium LUCI CQ, Thomas Nguyen, chromium...@chromium.org, Permissions Reviews, feature-me...@chromium.org
Attention needed from Thomas Nguyen and plantree

Ravjit Uppal voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Thomas Nguyen
  • plantree
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I1f0ec62660733ef37d58a95256922bcab0bf1c01
Gerrit-Change-Number: 7867474
Gerrit-PatchSet: 1
Gerrit-Owner: plantree <pengyu...@microsoft.com>
Gerrit-Reviewer: Ravjit Uppal <rav...@chromium.org>
Gerrit-Reviewer: Thomas Nguyen <tun...@chromium.org>
Gerrit-Reviewer: plantree <pengyu...@microsoft.com>
Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
Gerrit-Attention: Thomas Nguyen <tun...@chromium.org>
Gerrit-Attention: plantree <pengyu...@microsoft.com>
Gerrit-Comment-Date: Thu, 21 May 2026 15:54:36 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Ravjit Uppal (Gerrit)

unread,
May 26, 2026, 8:35:05 AM (6 days ago) May 26
to plantree, Chromium LUCI CQ, Thomas Nguyen, chromium...@chromium.org, Permissions Reviews, feature-me...@chromium.org
Attention needed from Thomas Nguyen and plantree

Ravjit Uppal voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Thomas Nguyen
  • plantree
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I1f0ec62660733ef37d58a95256922bcab0bf1c01
Gerrit-Change-Number: 7867474
Gerrit-PatchSet: 3
Gerrit-Owner: plantree <pengyu...@microsoft.com>
Gerrit-Reviewer: Ravjit Uppal <rav...@chromium.org>
Gerrit-Reviewer: Thomas Nguyen <tun...@chromium.org>
Gerrit-Reviewer: plantree <pengyu...@microsoft.com>
Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
Gerrit-Attention: Thomas Nguyen <tun...@chromium.org>
Gerrit-Attention: plantree <pengyu...@microsoft.com>
Gerrit-Comment-Date: Tue, 26 May 2026 12:34:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

plantree (Gerrit)

unread,
May 26, 2026, 9:49:49 PM (5 days ago) May 26
to Ravjit Uppal, Chromium LUCI CQ, Thomas Nguyen, chromium...@chromium.org, Permissions Reviews, feature-me...@chromium.org
Attention needed from Thomas Nguyen

plantree added 1 comment

Patchset-level comments
Open in Gerrit

Related details

Attention is currently required from:
  • Thomas Nguyen
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I1f0ec62660733ef37d58a95256922bcab0bf1c01
Gerrit-Change-Number: 7867474
Gerrit-PatchSet: 3
Gerrit-Owner: plantree <pengyu...@microsoft.com>
Gerrit-Reviewer: Ravjit Uppal <rav...@chromium.org>
Gerrit-Reviewer: Thomas Nguyen <tun...@chromium.org>
Gerrit-Reviewer: plantree <pengyu...@microsoft.com>
Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
Gerrit-Attention: Thomas Nguyen <tun...@chromium.org>
Gerrit-Comment-Date: Wed, 27 May 2026 01:49:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Thomas Nguyen (Gerrit)

unread,
May 28, 2026, 4:21:53 AM (4 days ago) May 28
to plantree, Ravjit Uppal, Chromium LUCI CQ, chromium...@chromium.org, Permissions Reviews, feature-me...@chromium.org
Attention needed from plantree

Thomas Nguyen voted and added 1 comment

Votes added by Thomas Nguyen

Code-Review+1

1 comment

Patchset-level comments
Thomas Nguyen . resolved

I am a bit worried about the UI (or any impact if the result of permission query is wrong). Perhaps it's a rare case and only happens once at singleton initialization.
For my curiosity, which is better between deferring the widget close and this approach?

Open in Gerrit

Related details

Attention is currently required from:
  • plantree
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I1f0ec62660733ef37d58a95256922bcab0bf1c01
    Gerrit-Change-Number: 7867474
    Gerrit-PatchSet: 3
    Gerrit-Owner: plantree <pengyu...@microsoft.com>
    Gerrit-Reviewer: Ravjit Uppal <rav...@chromium.org>
    Gerrit-Reviewer: Thomas Nguyen <tun...@chromium.org>
    Gerrit-Reviewer: plantree <pengyu...@microsoft.com>
    Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
    Gerrit-Attention: plantree <pengyu...@microsoft.com>
    Gerrit-Comment-Date: Thu, 28 May 2026 08:21:38 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Thomas Nguyen (Gerrit)

    unread,
    May 28, 2026, 4:22:05 AM (4 days ago) May 28
    to plantree, Ravjit Uppal, Chromium LUCI CQ, chromium...@chromium.org, Permissions Reviews, feature-me...@chromium.org
    Attention needed from plantree

    Thomas Nguyen voted Code-Review+0

    Code-Review+0
    Open in Gerrit

    Related details

    Attention is currently required from:
    • plantree
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I1f0ec62660733ef37d58a95256922bcab0bf1c01
      Gerrit-Change-Number: 7867474
      Gerrit-PatchSet: 3
      Gerrit-Owner: plantree <pengyu...@microsoft.com>
      Gerrit-Reviewer: Ravjit Uppal <rav...@chromium.org>
      Gerrit-Reviewer: Thomas Nguyen <tun...@chromium.org>
      Gerrit-Reviewer: plantree <pengyu...@microsoft.com>
      Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
      Gerrit-Attention: plantree <pengyu...@microsoft.com>
      Gerrit-Comment-Date: Thu, 28 May 2026 08:21:49 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      plantree (Gerrit)

      unread,
      May 31, 2026, 10:51:35 PM (2 hours ago) May 31
      to Thomas Nguyen, Ravjit Uppal, Chromium LUCI CQ, chromium...@chromium.org, Permissions Reviews, feature-me...@chromium.org
      Attention needed from Thomas Nguyen

      plantree added 1 comment

      Patchset-level comments
      Thomas Nguyen . resolved

      I am a bit worried about the UI (or any impact if the result of permission query is wrong). Perhaps it's a rare case and only happens once at singleton initialization.
      For my curiosity, which is better between deferring the widget close and this approach?

      plantree

      The UI impact is minimal — kNotDetermined just hides the "system settings" link in the PageInfo bubble. This only affects the very first bubble open before the posted task runs (next message loop iteration), which is unlikely in practice.

      Deferring the widget close would mean changing core views infrastructure (Widget::CloseWithReason or the occlusion tracker), which is riskier. Fixing it at the source avoids the message-pumping COM call entirely, which is more targeted and prevents other potential re-entrancy from the same root cause.

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Thomas Nguyen
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I1f0ec62660733ef37d58a95256922bcab0bf1c01
      Gerrit-Change-Number: 7867474
      Gerrit-PatchSet: 3
      Gerrit-Owner: plantree <pengyu...@microsoft.com>
      Gerrit-Reviewer: Ravjit Uppal <rav...@chromium.org>
      Gerrit-Reviewer: Thomas Nguyen <tun...@chromium.org>
      Gerrit-Reviewer: plantree <pengyu...@microsoft.com>
      Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
      Gerrit-Attention: Thomas Nguyen <tun...@chromium.org>
      Gerrit-Comment-Date: Mon, 01 Jun 2026 02:51:10 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Thomas Nguyen <tun...@chromium.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages