[GlowUp] Update toolbar search field background color [chromium/src : main]
0 views
Skip to first unread message
Thomas Lukaszewicz (Gerrit)
May 27, 2026, 6:52:22 PM (22 hours ago) May 27
to Mickey Burks, chromium...@chromium.org
Attention needed from Mickey Burks
Thomas Lukaszewicz added 1 comment![]( "Open in Gerrit")
File chrome/browser/ui/color/material_chrome_color_mixer.cc
Line 464, Patchset 1:
if (features::IsWebuiRefresh2026Enabled()) {
mixer[ui::kColorToolbarSearchFieldBackground] = {ui::kColorSysSurface4};
}Thomas Lukaszewicz . unresolved
Could we define a separate function that is called at the end of this for overrides specific to refresh 2026? I.e. something like `ApplyChromeRefresh2026ColorOverrides(ui::ColorMixer& mixer)` in the anonymous namespace
Related details
Attention is currently required from:
- Mickey Burks
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mickey Burks (Gerrit)
9:27 AM (8 hours ago) 9:27 AM
to Thomas Lukaszewicz, chromium...@chromium.org
Attention needed from Thomas Lukaszewicz
Mickey Burks added 1 comment![]( "Open in Gerrit")
File chrome/browser/ui/color/material_chrome_color_mixer.cc
Line 464, Patchset 1:
if (features::IsWebuiRefresh2026Enabled()) {
mixer[ui::kColorToolbarSearchFieldBackground] = {ui::kColorSysSurface4};
}Thomas Lukaszewicz . resolved
Could we define a separate function that is called at the end of this for overrides specific to refresh 2026? I.e. something like `ApplyChromeRefresh2026ColorOverrides(ui::ColorMixer& mixer)` in the anonymous namespace
Attention is currently required from:
- Thomas Lukaszewicz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Thomas Lukaszewicz (Gerrit)
2:33 PM (2 hours ago) 2:33 PM
to Mickey Burks, chromium...@chromium.org
Attention needed from Mickey Burks
Thomas Lukaszewicz voted and added 1 comment![]( "Open in Gerrit")
Votes added by Thomas Lukaszewicz
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Mickey Burks
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mickey Burks (Gerrit)
3:33 PM (1 hour ago) 3:33 PM
to Thomas Lukaszewicz, chromium...@chromium.org
Mickey Burks voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages