Implement Renderer-side Backing for Immutable Data optimization [chromium/src : main]
AI Code Reviewer (Gerrit)
AI Code Reviewer added 4 comments![]( "Open in Gerrit")
const Vector<scoped_refptr<RawData>>& data() const {Blink Style Guide: Naming - Use 'CamelCase' for all function names. All function names should use CamelCase()-style names, beginning with an uppercase letter. Please rename `data()` to `Data()`.
To keep this interaction as brief and non-intrusive as possible, please consider responding with one of following options:
**Done** | **OK But Won't Fix**: reason | **Later**: b/<bug_id> | **Invalid:** reason
_This comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent)._
_AI reviews can sometimes be inaccurate; We appreciate your π feedback π to help us improve._
_[File a bug](http://go/blink-c++-code-review-agent-feedback) | [Provide feedback on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4) | [Opt-out](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)_
bool retired_ = false;nit: Blink Style Guide: Naming - Precede boolean values with words like βisβ and βdidβ. Consider renaming `retired_` to `is_retired_`.
To keep this interaction as brief and non-intrusive as possible, please consider responding with one of following options:
**Done** | **OK But Won't Fix**: reason | **Later**: b/<bug_id> | **Invalid:** reason
_This comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent)._
_AI reviews can sometimes be inaccurate; We appreciate your π feedback π to help us improve._
_[File a bug](http://go/blink-c++-code-review-agent-feedback) | [Provide feedback on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4) | [Opt-out](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)_
static void Create(Blink Style Guide: Don't mix Create () factory methods and public constructors in one class. Since this class has a static `Create()` factory method, the constructor should be made private.
To keep this interaction as brief and non-intrusive as possible, please consider responding with one of following options:
**Done** | **OK But Won't Fix**: reason | **Later**: b/<bug_id> | **Invalid:** reason
_This comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent)._
_AI reviews can sometimes be inaccurate; We appreciate your π feedback π to help us improve._
_[File a bug](http://go/blink-c++-code-review-agent-feedback) | [Provide feedback on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4) | [Opt-out](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)_
auto* backing = new RendererBlobBacking(std::move(secondary_remote),Blink Style Guide: Do not use `new` and `delete`. Blink bans bare new/delete. Please avoid using bare `new` here.
To keep this interaction as brief and non-intrusive as possible, please consider responding with one of following options:
**Done** | **OK But Won't Fix**: reason | **Later**: b/<bug_id> | **Invalid:** reason
_This comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent)._
_AI reviews can sometimes be inaccurate; We appreciate your π feedback π to help us improve._
_[File a bug](http://go/blink-c++-code-review-agent-feedback) | [Provide feedback on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4) | [Opt-out](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)_
Related details
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromeperf@appspot.gserviceaccount.com (Gerrit)
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
πΏ Job linux-perf/blink_perf.owp_storage failed.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/1607a23b890000
Related details
- Daniel Murphy
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromeperf@appspot.gserviceaccount.com (Gerrit)
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
πΏ Job linux-perf/blink_perf.owp_storage failed.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/15297dfb890000
chromeperf@appspot.gserviceaccount.com (Gerrit)
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
πΏ Job linux-perf/blink_perf.owp_storage failed.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/122a51b9890000
chromeperf@appspot.gserviceaccount.com (Gerrit)
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
πΏ Job android-pixel4-perf/blink_perf.owp_storage failed.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/11f8610b890000
chromeperf@appspot.gserviceaccount.com (Gerrit)
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
πΏ Job android-pixel9-perf/blink_perf.owp_storage failed.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/113e8b83890000