Revert "[composebox] Don't shrink composebox once expanded." [chromium/src : main]
0 views
Skip to first unread message
Fuhsin Liao (Gerrit)
Jun 18, 2026, 1:04:23 AM (6 days ago) Jun 18
to Nihar Majmudar, Chromium LUCI CQ, Marlon Facey, chromium...@chromium.org
Attention needed from Marlon Facey and Nihar Majmudar
Fuhsin Liao has uploaded the change for review![]( "Open in Gerrit")
Fuhsin Liao would like Nihar Majmudar, Chromium LUCI CQ and Marlon Facey to review this change.
Commit message
Revert "[composebox] Don't shrink composebox once expanded."
This reverts commit 5e566eb628b7778ee61d7dca0e6f86025d1d4edd.
Reason for revert: This cl has caused test failures on 'android-desktop-17-x64-rel-brya-tests'
Failure Link: https://ci.chromium.org/ui/p/chromium/builders/ci/android-desktop-x64-rel-15-tests/20680/overview
Original change's description:
> [composebox] Don't shrink composebox once expanded.
>
> This change makes it so once the composebox expands to a certain height,
> it doesn't shrink if text is deleted/smart compose text is hidden. The
> only way to reset the height if if the "x" button is clicked.
>
> Also adds padding-block to input, mirror, and smart compose divs to
> remove flickering when accepting smart compose text in realbox/omnibox.
>
> NO_IFTTT=Added in both composebox.ts and composebox_mixin.ts
>
> After: https://screencast.googleplex.com/cast/NTc0MTU4NzY2ODY2NDMyMHxiM2VmM2I0Mi02Zg
> Bug: 524694141
> Change-Id: Icfe397dd18951765c6d8ba628e2b12ecfaf1a68c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7951584
> Commit-Queue: Nihar Majmudar <nih...@google.com>
> Reviewed-by: Marlon Facey <mfa...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1647968}
Bug: 524694141
Change-Id: I341e5286f8283ae312c81abdabcbf274cb894e99
Change diff
Change information
Files:
- M chrome/test/data/webui/cr_components/composebox/composebox_input_test.ts
- M ui/webui/resources/cr_components/composebox/composebox.ts
- M ui/webui/resources/cr_components/composebox/composebox_input.css
- M ui/webui/resources/cr_components/composebox/composebox_input.ts
- M ui/webui/resources/cr_components/composebox/composebox_mixin.ts
Change size: M
Delta: 5 files changed, 28 insertions(+), 111 deletions(-)
Related details
Attention is currently required from:
- Marlon Facey
- Nihar Majmudar
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
rubber-stamper@appspot.gserviceaccount.com (Gerrit)
Jun 18, 2026, 1:05:57 AM (6 days ago) Jun 18
to Fuhsin Liao, android-bu...@system.gserviceaccount.com, Nihar Majmudar, Chromium LUCI CQ, Marlon Facey, chromium...@chromium.org, oshima...@chromium.org
Attention needed from Marlon Facey and Nihar Majmudar
rubber-...@appspot.gserviceaccount.com voted Bot-Commit+1![]( "Open in Gerrit")
| Bot-Commit | +1 |
Related details
Attention is currently required from:
- Marlon Facey
- Nihar Majmudar
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Fuhsin Liao (Gerrit)
Jun 18, 2026, 1:09:21 AM (6 days ago) Jun 18
to rubber-...@appspot.gserviceaccount.com, android-bu...@system.gserviceaccount.com, Nihar Majmudar, Chromium LUCI CQ, Marlon Facey, chromium...@chromium.org, oshima...@chromium.org
Attention needed from Marlon Facey and Nihar Majmudar
Fuhsin Liao voted![]( "Open in Gerrit")
| Auto-Submit | +1 |
| Code-Review | +1 |
| Commit-Queue | +2 |
| Owners-Override | +1 |
Related details
Attention is currently required from:
- Marlon Facey
- Nihar Majmudar
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jun 18, 2026, 2:42:14 AM (6 days ago) Jun 18
to Fuhsin Liao, rubber-...@appspot.gserviceaccount.com, android-bu...@system.gserviceaccount.com, Nihar Majmudar, Marlon Facey, chromium...@chromium.org, oshima...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Revert "[composebox] Don't shrink composebox once expanded."
This reverts commit 5e566eb628b7778ee61d7dca0e6f86025d1d4edd.
Reason for revert: This cl has caused test failures on 'android-desktop-17-x64-rel-brya-tests'
Failure Link: https://ci.chromium.org/ui/p/chromium/builders/ci/android-desktop-x64-rel-15-tests/20680/overview
Original change's description:
> [composebox] Don't shrink composebox once expanded.
>
> This change makes it so once the composebox expands to a certain height,
> it doesn't shrink if text is deleted/smart compose text is hidden. The
> only way to reset the height if if the "x" button is clicked.
>
> Also adds padding-block to input, mirror, and smart compose divs to
> remove flickering when accepting smart compose text in realbox/omnibox.
>
> NO_IFTTT=Added in both composebox.ts and composebox_mixin.ts
>
> After: https://screencast.googleplex.com/cast/NTc0MTU4NzY2ODY2NDMyMHxiM2VmM2I0Mi02Zg
> Bug: 524694141
> Change-Id: Icfe397dd18951765c6d8ba628e2b12ecfaf1a68c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7951584
> Commit-Queue: Nihar Majmudar <nih...@google.com>
> Reviewed-by: Marlon Facey <mfa...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1647968}
Bug: 524694141
Change-Id: I341e5286f8283ae312c81abdabcbf274cb894e99
Commit-Queue: Fuhsin Liao <fuhsi...@google.com>
Reviewed-by: Fuhsin Liao <fuhsi...@google.com>
Owners-Override: Fuhsin Liao <fuhsi...@google.com>
Auto-Submit: Fuhsin Liao <fuhsi...@google.com>
Cr-Commit-Position: refs/heads/main@{#1648829}
Files:
- M chrome/test/data/webui/cr_components/composebox/composebox_input_test.ts
- M ui/webui/resources/cr_components/composebox/composebox.ts
- M ui/webui/resources/cr_components/composebox/composebox_input.css
- M ui/webui/resources/cr_components/composebox/composebox_input.ts
- M ui/webui/resources/cr_components/composebox/composebox_mixin.ts
Change size: M
Delta: 5 files changed, 28 insertions(+), 111 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Fuhsin Liao, Bot-Commit+1 by rubber-...@appspot.gserviceaccount.com
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nihar Majmudar (Gerrit)
Jun 18, 2026, 8:24:37 AM (5 days ago) Jun 18
to Chromium LUCI CQ, Fuhsin Liao, rubber-...@appspot.gserviceaccount.com, android-bu...@system.gserviceaccount.com, Marlon Facey, chromium...@chromium.org, oshima...@chromium.org
Nihar Majmudar added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Nihar Majmudar . unresolved
@fuhsi...@google.com, Are you sure this is caused by this CL? This looks completed unrelated and I think this revert should be reverted
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nihar Majmudar (Gerrit)
Jun 18, 2026, 8:25:04 AM (5 days ago) Jun 18
to Chromium LUCI CQ, Fuhsin Liao, rubber-...@appspot.gserviceaccount.com, android-bu...@system.gserviceaccount.com, Marlon Facey, chromium...@chromium.org, oshima...@chromium.org
Attention needed from Fuhsin Liao
Nihar Majmudar added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Nihar Majmudar . unresolved
@fuhsi...@google.com, Are you sure this is caused by this CL? This looks completed unrelated and I think this revert should be reverted
Nihar Majmudar
(Or is the failure link correct)
Related details
Attention is currently required from:
- Fuhsin Liao
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Fuhsin Liao (Gerrit)
Jun 18, 2026, 11:17:58 AM (5 days ago) Jun 18
to Chromium LUCI CQ, rubber-...@appspot.gserviceaccount.com, android-bu...@system.gserviceaccount.com, Nihar Majmudar, Marlon Facey, chromium...@chromium.org, oshima...@chromium.org
Fuhsin Liao added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Nihar Majmudar . resolved
Nihar Majmudar@fuhsi...@google.com, Are you sure this is caused by this CL? This looks completed unrelated and I think this revert should be reverted
(Or is the failure link correct)
Fuhsin Liao
Sorry I attached the wrong failure link. This is the one: https://ci.chromium.org/ui/p/chrome/builders/ci/android-desktop-17-x64-rel-brya-tests/106/overview
Please check the 'CrComponentsComposeboxTest.ComposeboxInput' test
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages