[Mac] In all the plists, define the LSMinimumSystemVersion based on MACOSX_DEPLOYMENT_TARGET. (issue 10810031)

134 views
Skip to first unread message

rse...@chromium.org

unread,
Jul 19, 2012, 9:18:25 PM7/19/12
to tha...@chromium.org, chromium...@chromium.org, jamiewal...@chromium.org, dcaiaf...@chromium.org, sanj...@chromium.org, sad...@chromium.org, ben+...@chromium.org, wez+...@chromium.org, am...@chromium.org, hclam...@chromium.org, j...@chromium.org, garyka...@chromium.org, joi+watc...@chromium.org, lambroslam...@chromium.org, dari...@chromium.org, simonmor...@chromium.org, alexeyp...@chromium.org, sergey...@chromium.org
Reviewers: Nico,

Description:
[Mac] In all the plists, define the LSMinimumSystemVersion based on
MACOSX_DEPLOYMENT_TARGET.

The LSMinimumSystemVersion must be of the form |n.n.n| [1] but the
MACOSX_DEPLOYMENT_TARGET is only |n.n|, so add an extra |.0| to the value in
the plist key.

[1]
https://developer.apple.com/library/mac/#documentation/CoreFoundation/Conceptual/CFBundles/BundleTypes/BundleTypes.html

BUG=137676
TEST=none
TBR=mac people

Please review this at https://chromiumcodereview.appspot.com/10810031/

SVN Base: svn://svn.chromium.org/chrome/trunk/src

Affected files:
M ash/shell/cocoa/app-Info.plist
M chrome/app/app-Info.plist
M chrome/app/app_mode-Info.plist
M chrome/app/helper-Info.plist
M content/shell/mac/app-Info.plist
M content/shell/mac/helper-Info.plist
M remoting/host/installer/mac/uninstaller/remoting_uninstaller-Info.plist
M remoting/host/remoting_me2me_host-Info.plist


Index: ash/shell/cocoa/app-Info.plist
diff --git a/ash/shell/cocoa/app-Info.plist b/ash/shell/cocoa/app-Info.plist
index
8c70f981428b6c77b9a9855612bef22a90654fea..9f04fc7146988dd5b79ad0571a53c6eda5a4b341
100644
--- a/ash/shell/cocoa/app-Info.plist
+++ b/ash/shell/cocoa/app-Info.plist
@@ -23,7 +23,7 @@
<key>CFBundleVersion</key>
<string>1</string>
<key>LSMinimumSystemVersion</key>
- <string>${MACOSX_DEPLOYMENT_TARGET}</string>
+ <string>${MACOSX_DEPLOYMENT_TARGET}.0</string>
<key>NSHumanReadableCopyright</key>
<string>Copyright © 2012 Google Inc. All rights reserved.</string>
<key>NSMainNibFile</key>
Index: chrome/app/app-Info.plist
diff --git a/chrome/app/app-Info.plist b/chrome/app/app-Info.plist
index
b1e122f1c02f2032851eeaebeaf47429504ed263..8344232143beb7e22141c71ba9f1c46993c641a9
100644
--- a/chrome/app/app-Info.plist
+++ b/chrome/app/app-Info.plist
@@ -236,7 +236,7 @@
<key>LSHasLocalizedDisplayName</key>
<string>1</string>
<key>LSMinimumSystemVersion</key>
- <string>10.5.0</string>
+ <string>${MACOSX_DEPLOYMENT_TARGET}.0</string>
<key>NSPrincipalClass</key>
<string>BrowserCrApplication</string>
<key>NSSupportsAutomaticGraphicsSwitching</key>
Index: chrome/app/app_mode-Info.plist
diff --git a/chrome/app/app_mode-Info.plist b/chrome/app/app_mode-Info.plist
index
f89e0bc747d7e06f01b56d83b5350575f6b60a04..9ac4fb458398721bac95620b370cf57c725d6953
100644
--- a/chrome/app/app_mode-Info.plist
+++ b/chrome/app/app_mode-Info.plist
@@ -29,7 +29,7 @@
<key>LSFileQuarantineEnabled</key>
<true/>
<key>LSMinimumSystemVersion</key>
- <string>10.5.0</string>
+ <string>${MACOSX_DEPLOYMENT_TARGET}.0</string>
<key>NSAppleScriptEnabled</key>
<true/>
</dict>
Index: chrome/app/helper-Info.plist
diff --git a/chrome/app/helper-Info.plist b/chrome/app/helper-Info.plist
index
fdf38532ecf297b14675845b00234f152b24774a..ff2c3df3617eb0f8bcfb5d51b3af0b6a6faed8f2
100644
--- a/chrome/app/helper-Info.plist
+++ b/chrome/app/helper-Info.plist
@@ -21,7 +21,7 @@
<key>LSFileQuarantineEnabled</key>
<true/>
<key>LSMinimumSystemVersion</key>
- <string>10.5.0</string>
+ <string>${MACOSX_DEPLOYMENT_TARGET}.0</string>
<key>LSUIElement</key>
<string>1</string>
<key>NSSupportsAutomaticGraphicsSwitching</key>
Index: content/shell/mac/app-Info.plist
diff --git a/content/shell/mac/app-Info.plist
b/content/shell/mac/app-Info.plist
index
c8a53105a72eedab4dd7f7420bfc308bf11230fe..84e98b243724361f94a5b2be60bcbd2c3cdabdfa
100644
--- a/content/shell/mac/app-Info.plist
+++ b/content/shell/mac/app-Info.plist
@@ -25,7 +25,7 @@
<key>NSPrincipalClass</key>
<string>NSApplication</string>
<key>LSMinimumSystemVersion</key>
- <string>10.5.0</string>
+ <string>${MACOSX_DEPLOYMENT_TARGET}.0</string>
<key>LSFileQuarantineEnabled</key>
<true/>
<key>NSSupportsAutomaticGraphicsSwitching</key>
Index: content/shell/mac/helper-Info.plist
diff --git a/content/shell/mac/helper-Info.plist
b/content/shell/mac/helper-Info.plist
index
2208e701319ae117dbca1546596d1c39adafc2d2..646d48ff1748a5584aa090adbe3ed66c480c7086
100644
--- a/content/shell/mac/helper-Info.plist
+++ b/content/shell/mac/helper-Info.plist
@@ -21,7 +21,7 @@
<key>LSFileQuarantineEnabled</key>
<true/>
<key>LSMinimumSystemVersion</key>
- <string>10.5.0</string>
+ <string>${MACOSX_DEPLOYMENT_TARGET}.0</string>
<key>LSUIElement</key>
<string>1</string>
<key>NSSupportsAutomaticGraphicsSwitching</key>
Index:
remoting/host/installer/mac/uninstaller/remoting_uninstaller-Info.plist
diff --git
a/remoting/host/installer/mac/uninstaller/remoting_uninstaller-Info.plist
b/remoting/host/installer/mac/uninstaller/remoting_uninstaller-Info.plist
index
f435845dc6e25f0d44443b39316ac1d9001ba94c..0b90c2fac8be374a69b442e0abe34ef76245d322
100644
---
a/remoting/host/installer/mac/uninstaller/remoting_uninstaller-Info.plist
+++
b/remoting/host/installer/mac/uninstaller/remoting_uninstaller-Info.plist
@@ -23,7 +23,7 @@
<key>CFBundleVersion</key>
<string>VERSION_FULL</string>
<key>LSMinimumSystemVersion</key>
- <string>${MACOSX_DEPLOYMENT_TARGET}</string>
+ <string>${MACOSX_DEPLOYMENT_TARGET}.0</string>
<key>NSHumanReadableCopyright</key>
<string>Copyright © 2012 COPYRIGHT_BY All rights reserved.</string>
<key>NSMainNibFile</key>
Index: remoting/host/remoting_me2me_host-Info.plist
diff --git a/remoting/host/remoting_me2me_host-Info.plist
b/remoting/host/remoting_me2me_host-Info.plist
index
c8af61176cacf30fe6f29268ff9c4f5721c73cca..6bbd3c256318629cf57a166f3de7a18f52fecf7e
100644
--- a/remoting/host/remoting_me2me_host-Info.plist
+++ b/remoting/host/remoting_me2me_host-Info.plist
@@ -23,10 +23,10 @@
<key>CFBundleShortVersionString</key>
<string>VERSION_SHORT</string>
<key>LSMinimumSystemVersion</key>
- <string>${MACOSX_DEPLOYMENT_TARGET}</string>
+ <string>${MACOSX_DEPLOYMENT_TARGET}.0</string>
<key>NSHumanReadableCopyright</key>
<string>Copyright © 2012 COPYRIGHT_BY All rights reserved.</string>
<key>LSUIElement</key>
<string>1</string>
</dict>
-</plist>
\ No newline at end of file
+</plist>


tha...@chromium.org

unread,
Jul 19, 2012, 9:20:51 PM7/19/12
to rse...@chromium.org, chromium...@chromium.org, jamiewal...@chromium.org, dcaiaf...@chromium.org, sanj...@chromium.org, sad...@chromium.org, ben+...@chromium.org, wez+...@chromium.org, am...@chromium.org, hclam...@chromium.org, j...@chromium.org, garyka...@chromium.org, joi+watc...@chromium.org, lambroslam...@chromium.org, dari...@chromium.org, simonmor...@chromium.org, alexeyp...@chromium.org, sergey...@chromium.org
lgtm

(ninja processes this correctly, right?)

https://chromiumcodereview.appspot.com/10810031/

rse...@chromium.org

unread,
Jul 19, 2012, 9:22:11 PM7/19/12
to tha...@chromium.org, chromium...@chromium.org, jamiewal...@chromium.org, dcaiaf...@chromium.org, sanj...@chromium.org, sad...@chromium.org, ben+...@chromium.org, wez+...@chromium.org, am...@chromium.org, hclam...@chromium.org, j...@chromium.org, garyka...@chromium.org, joi+watc...@chromium.org, lambroslam...@chromium.org, dari...@chromium.org, simonmor...@chromium.org, alexeyp...@chromium.org, sergey...@chromium.org
On 2012/07/20 01:20:50, Nico wrote:
> lgtm

> (ninja processes this correctly, right?)

Yes. As do the official builders, based on this already being done in some
but
not all the plists.

https://chromiumcodereview.appspot.com/10810031/

commi...@chromium.org

unread,
Jul 19, 2012, 9:22:27 PM7/19/12
to rse...@chromium.org, tha...@chromium.org, chromium...@chromium.org, jamiewal...@chromium.org, dcaiaf...@chromium.org, sanj...@chromium.org, sad...@chromium.org, ben+...@chromium.org, wez+...@chromium.org, am...@chromium.org, hclam...@chromium.org, j...@chromium.org, garyka...@chromium.org, joi+watc...@chromium.org, lambroslam...@chromium.org, dari...@chromium.org, simonmor...@chromium.org, alexeyp...@chromium.org, sergey...@chromium.org
CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rse...@chromium.org/10810031/1


https://chromiumcodereview.appspot.com/10810031/

commi...@chromium.org

unread,
Jul 19, 2012, 11:03:32 PM7/19/12
to rse...@chromium.org, tha...@chromium.org, chromium...@chromium.org, jamiewal...@chromium.org, dcaiaf...@chromium.org, sanj...@chromium.org, sad...@chromium.org, ben+...@chromium.org, wez+...@chromium.org, am...@chromium.org, hclam...@chromium.org, j...@chromium.org, garyka...@chromium.org, joi+watc...@chromium.org, lambroslam...@chromium.org, dari...@chromium.org, simonmor...@chromium.org, alexeyp...@chromium.org, sergey...@chromium.org
Change committed as 147607

https://chromiumcodereview.appspot.com/10810031/
Reply all
Reply to author
Forward
0 new messages