mac: Unbreak shared build. (issue 10389178)

0 views

Skip to first unread message

tha...@chromium.org

unread,

May 16, 2012, 4:02:22 PM5/16/12

to lambros...@chromium.org, chromium...@chromium.org, jamiewal...@chromium.org, dcaiaf...@chromium.org, simonmor...@chromium.org, hclam...@chromium.org, wez+...@chromium.org, am...@chromium.org, sanj...@chromium.org, garyka...@chromium.org, lambroslam...@chromium.org, alexeyp...@chromium.org, sergey...@chromium.org

Reviewers: Lambros,

Description:
mac: Unbreak shared build.

It was broken by https://chromiumcodereview.appspot.com/10384140.

SOLINK_MODULE(target)
out/Release/remoting_host_prefpane.prefPane/Contents/MacOS/remoting_host_prefpane
Undefined symbols:
"_modp_b64_decode", referenced from:
-[Me2MePreferencePane onApply:] in me2me_preference_pane.o
ld: symbol(s) not found

This doesn't happen in the components build because the prefpane still
depends on base via

tools/gyp-explain.py remoting_host_prefpane modp_b64
These paths lead from remoting/remoting.gyp:remoting_host_prefpane#target to
third_party/modp_b64/modp_b64.gyp:modp_b64#target:
remoting/remoting.gyp:remoting_host_prefpane#target ->
remoting/remoting.gyp:remoting_base#target -> base/base.gyp:base#target ->
third_party/modp_b64/modp_b64.gyp:modp_b64#target

BUG=none
TEST=none
TBR=lambroslambrou

Please review this at https://chromiumcodereview.appspot.com/10389178/

SVN Base: svn://svn.chromium.org/chrome/trunk/src

Affected files:
M remoting/remoting.gyp

Index: remoting/remoting.gyp
diff --git a/remoting/remoting.gyp b/remoting/remoting.gyp
index
681cad6734e49f6bfbb9abbad01e1722ce5971a7..9651831079ef292dc494a046bc331f7a0f94c645
100644
--- a/remoting/remoting.gyp
+++ b/remoting/remoting.gyp
@@ -396,6 +396,7 @@
# include the files directly, instead of depending on the target.
'../third_party/jsoncpp/source/src/lib_json/json_reader.cpp',
'../third_party/jsoncpp/source/src/lib_json/json_writer.cpp',
+ '../third_party/modp_b64/modp_b64.cc',
'host/me2me_preference_pane.h',
'host/me2me_preference_pane.mm',
],

lambros...@chromium.org

unread,

May 16, 2012, 4:03:52 PM5/16/12

to tha...@chromium.org, chromium...@chromium.org, jamiewal...@chromium.org, dcaiaf...@chromium.org, simonmor...@chromium.org, hclam...@chromium.org, wez+...@chromium.org, am...@chromium.org, sanj...@chromium.org, garyka...@chromium.org, lambroslam...@chromium.org, alexeyp...@chromium.org, sergey...@chromium.org