policy: Decouple LocalFilesCleanup from g_browser_process [chromium/src : main]
0 views
Skip to first unread message
Jun Ishiguro (Gerrit)
5:20 AM (8 hours ago) 5:20 AM
to Hidehiko Abe, Chromium LUCI CQ, chromium...@chromium.org, Enterprise Policy Reviews
Attention needed from Hidehiko Abe
Jun Ishiguro added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Hidehiko Abe
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hidehiko Abe (Gerrit)
8:14 AM (5 hours ago) 8:14 AM
to Jun Ishiguro, Chromium LUCI CQ, chromium...@chromium.org, Enterprise Policy Reviews
Attention needed from Jun Ishiguro
Hidehiko Abe voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Jun Ishiguro
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jun Ishiguro (Gerrit)
9:40 AM (4 hours ago) 9:40 AM
to Hidehiko Abe, Chromium LUCI CQ, chromium...@chromium.org, Enterprise Policy Reviews
Jun Ishiguro voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
9:46 AM (4 hours ago) 9:46 AM
to Jun Ishiguro, Hidehiko Abe, chromium...@chromium.org, Enterprise Policy Reviews
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
policy: Decouple LocalFilesCleanup from g_browser_process
Replace direct access to g_browser_process->local_state() in
LocalFilesCleanup with explicit constructor dependency injection of
PrefService. This resolves the TODO in local_files_cleanup.cc, improves
testability, and makes class dependencies explicit.
In UserCloudPolicyManagerAsh::ConnectManagementService(), where
LocalFilesCleanup is instantiated, inject the existing local_state_
member variable via pointer extraction (&local_state_.get()).
TAG=agy
Bug: b:404133022
Change-Id: Idbde4e2c39e4b30ee01a966879b0eca37db41260
Commit-Queue: Jun Ishiguro <ju...@google.com>
Reviewed-by: Hidehiko Abe <hide...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1658701}
Files:
- M chrome/browser/ash/policy/core/user_cloud_policy_manager_ash.cc
- M chrome/browser/ash/policy/skyvault/local_files_cleanup.cc
- M chrome/browser/ash/policy/skyvault/local_files_cleanup.h
Change size: S
Delta: 3 files changed, 10 insertions(+), 6 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Hidehiko Abe
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages